gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
105,730 Commits 12 Branches 481 Tags 2.4 GiB
1fe277e988
Commit Graph

37 Commits

Author SHA1 Message Date
Michal Čihař
1fe277e988 Use $this instead of accessing DBI from globals 
We're already in the object scope, there is no need to go to globals for
self.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-04-11 11:19:33 +02:00
Michal Čihař
f9ef2eb37e Improve performance with SkipLockedTables 
We now fetch all table status in one query, so this has pretty much same
speed as SkipLockedTables disabled.

Issue #12129

Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-04-07 09:25:53 +02:00
Michal Čihař
e875d4b50b Adjust tracking test to new code 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-04-06 11:58:20 +02:00
Michal Čihař
f42674aa0f Better document why these aliases are needed 
It's no longer for MySQL forward compatibility, but rather for
possibility to switch between SHOW TABLES and INFORMATION_SCHEMA using
DisableIS directive.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-04-06 11:05:31 +02:00
Michal Čihař
635f83a634 Remove unused method 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-04-06 11:04:25 +02:00
Michal Čihař
6c712a3c15 Revert "Remove compatibility code with MySQL < 5.0" 
This is still needed

Fixes #12161

This reverts commit edd264c91f.
 2016-04-06 10:55:38 +02:00
Michal Čihař
c136a74705 Cache current user information for DBI lifetime 
We query this information quite often, so it makes sense to fetch it
only once from the MySQL server.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-04-06 09:45:53 +02:00
Michal Čihař
5bd9fc4e40 Check if DBG is set and store the result 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-03-08 14:23:25 +01:00
Michal Čihař
1b9ea10f11 Move logging helpers to class 
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-03-08 11:14:28 +01:00
Durgesh
0b64827930 Refactored url parmeters generating, Issue #11990 
Signed-off-by: Durgesh <007durgesh219@gmail.com>
 2016-02-22 14:36:41 +05:30
Michal Čihař
edd264c91f Remove compatibility code with MySQL < 5.0 
It doesn't seem to be needed now.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-02-12 17:20:44 +01:00
Michal Čihař
94dccc6a00 Remove MySQL version caching 
In my testing the session/cache access is slower than fetching single
value from MySQL and calculating the values.

Also the caching would need some logic for invalidation as the server
can be upgraded or configuration changed.

Fixes #11924

Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-02-08 10:59:38 +01:00
Michal Čihař
c2c85cd15c Fix class names 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-01-28 17:15:47 +01:00
Michal Čihař
ed96969ff9 Merge branch 'QA_4_5' 2016-01-28 09:23:27 +01:00
Michal Čihař
cbca7ca202 Show MySQL error messages in user language 
Fixes #11789

Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-01-13 08:49:02 +01:00
Marc Delisle
9df4afb256 This one needed a lettered operator 
Signed-off-by: Marc Delisle <marc@infomarc.info>
 2016-01-05 17:23:41 -05:00
Marc Delisle
68f8adfd84 No letters for logical operators 
https://github.com/dseguy/clearPHP/blob/master/rules/no-letter-logical.md

Signed-off-by: Marc Delisle <marc@infomarc.info>
 2016-01-05 17:17:43 -05:00
Michal Čihař
a74efb0c30 Simplify getting first element of an array 
Calling current() after reset() is duplicate as reset() already returns
current index value.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-01-05 12:37:50 +01:00
Michal Čihař
e1c9dec998 Merge commit '912f96114dc803404e2854ebb5796757a4eeedb6' 2016-01-05 08:21:32 +01:00
Michal Čihař
55b317c699 Remove /*overload*/ prefix from mb_* calls 
I believe this was temporary flagging to see which code is migrated and
can be safely removed now.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-01-04 16:35:28 +01:00
Marc Delisle
911f8274c7 Clarify class and variable name 
Signed-off-by: Marc Delisle <marc@infomarc.info>
 2015-12-31 08:09:47 -05:00
Michal Čihař
58ba4b83b8 Merge branch 'QA_4_5' 2015-12-28 11:51:20 +01:00
Marc Delisle
d9bec7f085 HTML line break shown after a MySQL connection error message 
Signed-off-by: Marc Delisle <marc@infomarc.info>
 2015-12-07 09:02:07 -05:00
Michal Čihař
0d15a96427 Merge branch 'QA_4_5' 2015-12-04 12:14:41 +01:00
Marc Delisle
84f57eaf2f Clarify comment 
Signed-off-by: Marc Delisle <marc@infomarc.info>
 2015-11-26 14:23:57 -05:00
Hugues Peccatte
f9d582bd09 Make PHPCS happy. 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2015-11-08 15:58:48 +01:00
Madhura Jayaratne
4c300ff574 Remove unnecessary check 
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
 2015-11-02 20:51:19 +11:00
Hugues Peccatte
21460a01c0 Merge branch 'master' into useNamespaces_master 2015-09-18 23:17:22 +02:00
Hugues Peccatte
42169e0258 Fix merge. 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2015-09-10 08:09:51 +02:00
Hugues Peccatte
42c0ebac85 Merge branch 'master' into useNamespaces_master 2015-09-09 22:05:00 +02:00
Hugues Peccatte
b1038cfefa Merge branch 'master' into useNamespaces_master 2015-09-04 22:37:45 +02:00
Hugues Peccatte
1b4b456626 Set namespace on DBI's classes (except DBIDummy). 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2015-09-01 22:18:47 +02:00
Hugues Peccatte
3e5da41078 Move PMA\SystemDatabase to PMA\libraries\SystemDatabase. 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2015-09-01 21:30:22 +02:00
Hugues Peccatte
7f8f34e89d Remove classes require_once. 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2015-09-01 21:30:22 +02:00
Hugues Peccatte
58b10807c8 Rename classes files. 
Rename classes.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2015-09-01 21:30:22 +02:00
Hugues Peccatte
0761fb1801 Rename classes files. 
Rename classes.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2015-09-01 21:30:21 +02:00
Hugues Peccatte
f0ba28fc1d Set namespace on Advisor, Config, Console and Util classes. 
Set namespace on DbQbe.
Set namespace to 'DbSearch'.
Split Advisor.class.php file.
Change Advisor namespace.
Rename DbQbe class and file.
Set namespace on DisplayResults.
Set namespace on Error.
Use namespace for ErrorHandler.
Add class autoloader.
Change ErrorHandler filename.
Remove some require.
Update Config namespace path.
Update PMA_Util to PMA\libraries\Util.
Rename Font and File classes files.
Use namespace for Footer.
Set namespace in all libraries classes.
Namespace OutputBuffering.
Export SubPartition.
Rename Partition file.
Namespace PDF.
Namespace RecentFavoriteTable.
Replace PMA_Response by Response and PMA_Message by Message.
Update uses and calls.
Fix unit tests.
Fix SqlParser autoload.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2015-09-01 21:22:52 +02:00