Maurício Meneghini Fauth
3baad2eb1c
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
William Desportes
3a49cb33bb
Move defining envs to defineTestingGlobals
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 13:35:36 +02:00
William Desportes
fe32a359dc
Move PMA_VERSION calls into defineVersionConstants() for tests
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 13:26:48 +02:00
William Desportes
a6c469611a
Minor fixes
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 13:19:23 +02:00
William Desportes
5195520883
Coding standard fixes
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 02:18:05 +02:00
William Desportes
13eaeadbf9
Clean bootstrap-dist file
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 02:07:45 +02:00
Maurício Meneghini Fauth
8dd310fb6a
Remove assignments in if conditions
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-16 01:35:19 -03:00
Maurício Meneghini Fauth
a64393e7f5
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
William Desportes
d5db177729
Fix some phpstan warnings and update baselines
...
Ref: https://github.com/phpstan/phpstan/issues/3287
Ref: https://github.com/vimeo/psalm/issues/3350
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-11 22:50:06 +02:00
Maurício Meneghini Fauth
f80d3e3bd4
Remove unnecessary annotations
...
@package, @subpackage and others.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
63dbcd01d9
Remove or ignore side effects in PHP files
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 20:22:37 -03:00
Maurício Meneghini Fauth
fdbf6ade80
Add environment config to test bootstrap
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-04 14:00:41 -03:00
Maurício Meneghini Fauth
77518d341e
Remove unused use statements
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 21:20:58 -03:00
Maurício Meneghini Fauth
dd06cd38f8
Defines rules for double quote usage
...
Makes sure that any use of double quotes strings are warranted.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
Maurício Meneghini Fauth
1a14b3e4d3
Remove vim modelines
...
These settings are no longer required as they are guaranteed through
other coding standard tools.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
e99f3ace5c
Move DbiDummy extension to the test directory
...
DbiDummy extension is only used for testing purposes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-28 18:00:36 -03:00
Maurício Meneghini Fauth
7ef47312db
Remove remaining calls to old DI container
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-17 15:02:08 -03:00
Hugues Peccatte
1b5131863f
Get rid of old container in DatabaseInterface
...
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-06-15 21:40:21 +02:00
Maurício Meneghini Fauth
e1f9ae00cd
Add a trailing comma in multi-line arrays
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-14 14:09:26 -03:00
Maurício Meneghini Fauth
38e5b12c1c
Define an absolute path to use for require statements
...
Fixes #6167
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-22 14:37:31 -02:00
William Desportes
d9153ae069
Add TESTSUITE_PORT for selenium tests
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-10-11 11:30:05 +02:00
Maurício Meneghini Fauth
244d4e8e81
Replace Template::get calls in libraries/classes
...
Uses Template::render() instead of Template::get().
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 18:18:24 -03:00
Maurício Meneghini Fauth
b9c0463d96
Use short array syntax instead of long array syntax
...
Replaces array() with [].
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
dc8c92bfd8
Enable strict mode in test files
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-16 04:36:04 -03:00
Maurício Meneghini Fauth
76a4b086a6
Remove runkit dependency
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-30 22:25:57 -03:00
Michal Čihař
deed987f15
Always define PMA_Config in tests
...
It is needed for template rendering, so most tests need it.
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-25 10:21:18 +02:00
Michal Čihař
e4ca1ae98f
Remove cell_align_left superglobal
...
It can be replaced by proper CSS.
Issue #11731
Issue #12262
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-10 13:04:45 +02:00
Michal Čihař
a82f8fc768
Move databaase interface load to static method
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 14:46:56 +02:00
Michal Čihař
942e44afe7
Merge pull request #13499 from nijel/theme
...
Move Theme object out of session
2017-07-18 09:45:11 +02:00
Michal Čihař
8b00b90372
Remove last uses of PMA_MYSQL_INT_VERSION define
...
It is only kept as name in Advisor for now.
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-07-17 15:27:27 +02:00
Michal Čihař
e05d5f4bf4
Remove PMA_MYSQL_STR_VERSION
...
Replace it by DatabaseInterface::getVersionString.
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-07-17 15:06:30 +02:00
Michal Čihař
302a10e43b
Remove no longer used PMA_MYSQL_VERSION_COMMENT define
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-07-17 14:55:57 +02:00
Michal Čihař
51fb18612a
Move Theme object out of session
...
Honestly I don't see good reason for storing Theme in session as loading
it from the session will take about same time as loading it from the
disk.
Additionally it seems that current code really didn't really use the
object stored in session, it was constructed with every request anyway
(by ThemeManager::initializeTheme).
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-07-17 14:18:35 +02:00
Michal Čihař
6521f7de39
Add wrapper around PHP date function to ease testing
...
This way Tracker tests run on PHP 7 as well.
Issue #13484
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-07-12 17:22:48 +02:00
Maurício Meneghini Fauth
ca910e8de8
Move classes to PhpMyAdmin namespace
...
- Move Table to PhpMyAdmin namespace
- Move Template to PhpMyAdmin namespace
- Move ThemeManager to PhpMyAdmin namespace
- Move Theme to PhpMyAdmin namespace
- Move Tracker to PhpMyAdmin namespace
- Move Transformations to PhpMyAdmin namespace
- Move TypesMySQL to PhpMyAdmin namespace
- Move Types to PhpMyAdmin namespace
- Move Util to PhpMyAdmin namespace
- Move VersionInformation to PhpMyAdmin namespace
- Move Url to PhpMyAdmin namespace
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-07-08 10:54:21 -03:00
Maurício Meneghini Fauth
13c0f7bc3c
Move classes to PhpMyAdmin namespace
...
- Move Advisor to PhpMyAdmin namespace
- Move Bookmark to PhpMyAdmin namespace
- Move Charsets to PhpMyAdmin namespace
- Move Config class to PhpMyAdmin namespace
- Move Console class to PhpMyAdmin namespace
- Move Core to PhpMyAdmin namespace
- Move DatabaseInterface to PhpMyAdmin namespace
- Move DbList to PhpMyAdmin namespace
- Move DbQbe to PhpMyAdmin namespace
- Move DbSearch to PhpMyAdmin namespace
- Move DisplayResults to PhpMyAdmin namespace
- Move Encoding to PhpMyAdmin namespace
- Move Error to PhpMyAdmin namespace
- Move ErrorHandler to PhpMyAdmin namespace
- Move File to PhpMyAdmin namespace
- Move Font to PhpMyAdmin namespace
- Move Footer to PhpMyAdmin namespace
- Move Header to PhpMyAdmin namespace
- Move Index to PhpMyAdmin namespace
- Move IndexColumn to PhpMyAdmin namespace
- Move LanguageManager to PhpMyAdmin namespace
- Move Language to PhpMyAdmin namespace
- Move Linter to PhpMyAdmin namespace
- Move ListAbstract to PhpMyAdmin namespace
- Move ListDatabase to PhpMyAdmin namespace
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-06-28 21:17:18 -03:00
Maurício Meneghini Fauth
e330402b5b
Refactor the core functions into static methods
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-06-03 00:52:22 -03:00
Michal Čihař
941e861aba
Define major version
...
This will be later used as compatiblity check for themes.
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-05-15 09:47:15 +02:00
Luís Pedro Algarvio
8e91ad5b35
Implement AUTOLOAD_FILE constant ( #13213 )
...
Replace hardcoded paths for autoload.php with vendor defined AUTOLOAD_FILE constant.
Signed-off-by: Luís Pedro Algarvio <lp.algarvio@gmail.com>
2017-05-04 12:24:11 +02:00
Michal Čihař
15909c30bc
Update to use motranslator 3.0
...
It uses PSR-4 prefix for PhpMyAdmin namespace.
See https://github.com/phpmyadmin/sql-parser/issues/126
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-01-23 12:33:22 +01:00
Michal Čihař
8633f44db0
Remove code for PMA_TEST_HEADERS
...
It's no longer necessary.
Issue #12079
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-01-08 10:58:19 +01:00
Michal Čihař
b56f101039
Remove is_ajax_request global
...
We already have the same information on Response object, so let's use it
from there.
Issue #11731
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-12-07 17:54:34 +01:00
Michal Čihař
8b87e6ae00
Switch to MoTranslator 2.0
...
It changes API (to consistenly use camelCase) and removes use of eval().
See #6363 , #11993 and phpmyadmin/motranslator#5
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-10-13 13:24:35 +02:00
Michal Čihař
0ebdd9b6b5
Use environment for configuring tests only on CLI
...
See https://httpoxy.org/ for possible problems.
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-09-16 12:00:32 +02:00
Michal Čihař
2148df85f1
Merge branch 'QA_4_6'
2016-08-30 15:53:06 +02:00
Michal Čihař
f3ca367efa
Fix number formatting with different settings of precision in PHP
...
- fixed Util::formatNumber to avoid rounding issues to mess up display
- force precision = 14 to ensure we get sane behavior
With precision set to higher value many things do not behave as expected
producing strange numbers in various places.
For example with precision=19 you get:
php > echo round(1.2, 2);
1.199999999999999956
Fixes #12303
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-08-30 15:51:18 +02:00
Michal Čihař
7d650bd548
Use phpmyadmin/shapefile instead of embedded bfShapeFile
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-24 15:52:40 +02:00
Michal Čihař
19f76066f2
Separate adding string and Message objects to Message
...
This way we can rely on type checking and avoid potential problems with
escaping.
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-16 15:16:29 +02:00
Michal Čihař
912bf964c7
Replace embedded php-gettext library with motranslator
...
Fixes #12018
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-24 11:49:43 +01:00
Michal Čihař
b8c39d413d
Do not try to run selenium tests if not told so
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-22 09:26:28 +01:00