Commit Graph

107 Commits

Author SHA1 Message Date
William Desportes
50e900a1bf
Remove all @test annotations
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-11-08 23:01:26 +01:00
Maurício Meneghini Fauth
db3da81056 Remove some useless comments
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-13 19:56:56 -03:00
William Desportes
ddfdbc2134
Remove some useless doc blocks and fix some coding standard warnings
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-18 00:14:32 +02:00
William Desportes
a80153a633
Add typehints using phpcbf on test/*
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-17 22:52:42 +02:00
Maurício Meneghini Fauth
47f0960dce Add return type declaration to test methods
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-07 11:31:33 -03:00
Maurício Meneghini Fauth
dfa5f92c31 Add return type declaration to fetch row methods
DatabaseInterface's fetchArray, fetchAssoc, fetchRow and fetchSingleRow
methods.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-29 20:32:04 -03:00
charliewindred
7d792e88f6
Removed underscores from unit test methods
Removed underscore prefixes from unit test method calls.

Signed-off-by: charliewindred <charliewindred@gmail.com>
2020-06-02 23:52:32 +02:00
William Desportes
761045bcc9
Move getSystemSchemas and isSystemSchema to Query\Utilities
If you think the class name could be better, feel free to improve it.
Everybody know naming classes is difficult ^^
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 01:42:53 +02:00
Maurício Meneghini Fauth
199e3d9813 Fix coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 21:08:55 -03:00
William Desportes
4d61ef2313
Split some code out of DatabaseInterface
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-26 13:18:01 +02:00
William Desportes
e184b470cd
Fix testDuplicateInfo after last commit, it does return -1
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-26 13:15:18 +02:00
William Desportes
a300a25319
Replace assertEquals({false,true} by assert{false,true}
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-26 13:13:15 +02:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
William Desportes
49a6d6e8d0
Use AbstractTestCase instead of PmaTestCase for all tests not needing mockResponse
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-22 01:45:50 +02:00
William Desportes
7e81b0b3d7
Merge callProtectedMethod and callPrivateFunction into callFunction
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 22:59:29 +02:00
William Desportes
ae575ffb14
Fix running tests in --process-isolation
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 16:21:20 +02:00
William Desportes
8f7d3d1fa7
Fix test cases after backupGlobals = false
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 02:07:45 +02:00
William Desportes
6eaa55e805
Call parent's setUp and tearDown
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 21:31:13 +02:00
William Desportes
0b2c24ee26
Use ::class in tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 12:15:40 +02:00
William Desportes
54e0250dae
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-18 12:50:30 +02:00
William Desportes
62a6591d3f
Fix some phpcs issues after latest phpcs 3.5.5 release
I left the false positives unfixed: https://github.com/squizlabs/PHP_CodeSniffer/issues/2937#issuecomment-615498860
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-18 01:01:38 +02:00
William Desportes
9a8e311a76
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-22 17:06:52 +01:00
William Desportes
818b9f76bf
Fix more broken queries on Windows CI
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-22 16:59:26 +01:00
William Desportes
9d595f8d0b
Fix some issues reported by Scrutinizer
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-14 23:28:20 +01:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824 Use short versions of scalar types in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
42166cac37 Remove use statements within the same namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 19:47:56 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
8ec4209002 Fix some coding standard issues
- Inverts yoda comparisons
- Removes parentheses from return
- Removes useless ternary operators
- Adds paretheses to new instances
- Adds trailing array comma

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 00:38:34 -03:00
Maurício Meneghini Fauth
285907991e Add coding standard rules for whitespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 22:29:54 -03:00
William Desportes
ef7a121c84
Fix phpstan & phpcs after 850c125684
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-16 23:59:01 +01:00
William Desportes
d6aa52c9e7
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-16 23:47:21 +01:00
William Desportes
850c125684
Fix #14732 Can't rename primary key with auto increment
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-16 23:46:35 +01:00
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
77518d341e Remove unused use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 21:20:58 -03:00
Maurício Meneghini Fauth
f97d957f00 Add PHPStan PHPUnit extensions and rules
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-07 15:32:32 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
William Desportes
f8688c2774
Merge branch 'QA_4_9' into 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-20 14:47:24 +02:00
William Desportes
3b116de260
Fix tests for "NULL wrongly checked on field change"
Pull-request: #15445
Introduced-by: bef259c510

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-20 14:42:43 +02:00
Maurício Meneghini Fauth
e99f3ace5c Move DbiDummy extension to the test directory
DbiDummy extension is only used for testing purposes

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-28 18:00:36 -03:00
Maurício Meneghini Fauth
e1f9ae00cd Add a trailing comma in multi-line arrays
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-14 14:09:26 -03:00
Maurício Meneghini Fauth
7be0f6bfae Reference class names in use statements
Sort use statements

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 00:14:26 -03:00
Maurício Meneghini Fauth
92cc67fbf7 Replace assertContains() with assertStringContainsString()
Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.
Using assertNotContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringNotContainsString() or assertStringNotContainsStringIgnoringCase() instead.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-24 16:32:28 -03:00
Maurício Meneghini Fauth
182491a73f Add void return type declaration for tests
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-22 21:33:55 -03:00
Maurício Meneghini Fauth
25e480666e Fix doc comments alignment
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 15:09:32 -02:00
Maurício Meneghini Fauth
23c3579804 Format array declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
76d8bfdafa Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-12 21:04:19 -02:00
William Desportes
f0b51c144f
Remove unused code in tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-29 19:15:41 +01:00
Maurício Meneghini Fauth
d745d1ce01 Retrieve parameters from $_POST in Table class
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:59 -02:00