Commit Graph

265 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
887f531a4d Use Expression[] in Util::getUniqueCondition
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-05 16:06:55 -03:00
Maurício Meneghini Fauth
9d18234581 Refactor Util::getUniqueCondition method
Passes the Statement instance directly instead of the
$analyzed_sql_results array.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-05 13:49:44 -03:00
charliewindred
ca3c5e17b0 Remove underscore prefix from method names
Removed underscore from method names for PSR-12 compliance.
Signed-off-by: charliewindred <charliewindred@gmail.com>
2020-06-02 16:44:16 +01:00
William Desportes
761045bcc9
Move getSystemSchemas and isSystemSchema to Query\Utilities
If you think the class name could be better, feel free to improve it.
Everybody know naming classes is difficult ^^
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 01:42:53 +02:00
CommanderRoot
5a1c5acccc
Fix #16147
Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
2020-05-30 03:26:45 +02:00
Maurício Meneghini Fauth
199e3d9813 Fix coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 21:08:55 -03:00
William Desportes
aff8b646aa
Extract Util::getConditionValue from Util:getUniqueCondition
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-27 21:48:42 +02:00
William Desportes
aba5e27a82
Some code fixes and improvements
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-27 18:55:58 +02:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
bd979dd1ff Remove useless elseif with if
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 22:53:44 -03:00
Maurício Meneghini Fauth
94955f187a Fix function call signatures indentation
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 04:22:02 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
9269d75fb4 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 20:22:18 -03:00
William Desportes
3db033224e
Add more typehints and improve some code for Util class
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 01:43:24 +02:00
Maurício Meneghini Fauth
80a45fa0ae Break too long lines
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-16 18:08:20 -03:00
William Desportes
cc981860a7
Coding standard fixes and baselines updates
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-15 23:20:14 +02:00
William Desportes
e22f83218f
Merge #16122 - Remove mysql extension checks as it was removed in php 7.0
Pull-request: #16122

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-15 22:48:28 +02:00
William Desportes
f7db653d4f
Improve some typehints
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-15 22:25:55 +02:00
William Desportes
fcd41f6c85
Remove some mysql extension assertions
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-15 22:17:58 +02:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
William Desportes
b7af1364c6
Psalm auto fixes manualy reviewed and edited
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-28 23:18:59 +02:00
William Desportes
783381ced1
Use camel case for Util::convertBitDefaultValue
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-03 09:31:49 +02:00
William Desportes
cfb791c3be
Allow null for Util::convertBitDefaultValue function
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-03 09:31:08 +02:00
William Desportes
986f639210
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-03 09:06:08 +02:00
Peter Kroon
ae640ebcce
Fix #16048 - Allow NULL as default bit value.
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-03 08:56:48 +02:00
Maurício Meneghini Fauth
27accdf5cc Remove BrowseUploadFileBlock HTML generator
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-31 22:25:24 -03:00
Maurício Meneghini Fauth
10f880bd8f Fix type error with Util::backquote
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-10 13:30:25 -03:00
CommanderRoot
ce2dd25202
Fix typo in Util.php
Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
2020-02-23 13:31:37 +01:00
CommanderRoot
8485c3e09f
Fix typo
Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
2020-02-23 01:24:52 +01:00
William Desportes
9a8e311a76
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-22 17:06:52 +01:00
William Desportes
9ed31d6fa1
Fix #15830 - strftime issue on windows for Japanese users
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-22 14:50:38 +01:00
William Desportes
01cd7dc33b
Some code improvements suggested by Scrutinizer
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-14 22:23:16 +01:00
Jayati Shrivastava
aadade55ce
Fix #15795 - Broken link on "MySQL said"
Signed-off-by: Jayati Shrivastava <gaurijove@gmail.com>
2020-02-12 22:35:34 +01:00
William Desportes
349a2f17bb
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-11 23:43:04 +01:00
William Desportes
71a02a92d4
Fix edge cases on #15200 - server-side HTTPS detection misses support for Forwarded HTTP Extension (RFC 7239)
Ref: 6729c89b17 (r37198800)
Ref: 6729c89b17 (r37198800)

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-11 23:42:15 +01:00
William Desportes
504af564ab
Merge #15916 - Improve documentation URLs
Pull-request: #15916
Fixes: #14947
Fixes: #15790
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-09 18:21:34 +01:00
William Desportes
954abc9d6e
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-07 16:17:30 +01:00
William Desportes
6729c89b17
Fix php notices on #15200 - server-side HTTPS detection misses support for Forwarded HTTP Extension (RFC 7239)
Ref: 3db8949ad3 (commitcomment-37079212)
Fixes: 3db8949ad3

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-07 16:12:12 +01:00
Jayati Shrivastava
4186865b75 Documentation link
Signed-off-by: Jayati Shrivastava <gaurijove@gmail.com>
2020-02-05 09:55:29 +05:30
William Desportes
c0ef2b8a4d
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-25 21:12:00 +01:00
corey buckley
fcb451d70b
Tests added for convertBitDefaultValue. Consider valid database names with single quotes. Change regex to only replace if digits between b'..'
Signed-off-by: Corey Buckley <coreybuckley13@gmail.com>
2020-01-25 21:00:53 +01:00
Corey Buckley
07c4a73eb0
Changes trim to regex in convertBitDefaultValue
Fixes the issue described in #15831.

Signed-off-by: Corey Buckley <coreybuckley13@gmail.com>
2020-01-25 20:59:16 +01:00
William Desportes
d042b6e2bb
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-24 23:25:07 +01:00
William Desportes
3db8949ad3
Fix #15200 - server-side HTTPS detection misses support for Forwarded HTTP Extension (RFC 7239)
Fixes: #15200
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-24 22:56:55 +01:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824 Use short versions of scalar types in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
6b7af13f8f Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 00:33:24 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
8ec4209002 Fix some coding standard issues
- Inverts yoda comparisons
- Removes parentheses from return
- Removes useless ternary operators
- Adds paretheses to new instances
- Adds trailing array comma

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 00:38:34 -03:00