gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
125,608 Commits 12 Branches 481 Tags 2.4 GiB
2722ea717d
Commit Graph

349 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
785f8c1c00
Use constructor property promotion where possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 19:39:02 -03:00
Maurício Meneghini Fauth
b0bc4f460e
Use null safe object operator where possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 18:21:56 -03:00
Maurício Meneghini Fauth
5aeaca0a9a
Remove unnecessary global vars from QBE controller 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 17:51:18 -03:00
Maurício Meneghini Fauth
613678f8f5
Replace assignments with null coalesce equal operator 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 17:03:05 -03:00
Maurício Meneghini Fauth
2a4803a81b
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 15:18:28 -03:00
Maurício Meneghini Fauth
0fa4ebdc59
Fix coding standard issues and update SA baselines 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 12:50:47 -03:00
ru-asdx
6dca8e722b
Ref #17769 - replace superglobals with serverrequest in database/ controllers (#17991) 
* replace superglobals with serverrequest in database/ controllers

Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>

* fix trailing whitespace

Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>

* Update libraries/classes/Controllers/Database/QueryByExampleController.php

Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

* Update libraries/classes/Controllers/Database/QueryByExampleController.php

Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

* Update libraries/classes/Controllers/Database/QueryByExampleController.php

Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

* Update libraries/classes/Controllers/Database/QueryByExampleController.php

Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

* Update libraries/classes/Controllers/Database/TrackingController.php

Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

* Update libraries/classes/Controllers/Database/TrackingController.php

Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

---------

Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>
Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 12:35:18 -03:00
Evgeny Skorlov
673882b281 libraries/classes/Controllers/Database/ExportController.php 
Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>
 2023-02-20 12:29:09 -03:00
Kamil Tekiela
69f7a915eb Replace getTablesFull with getTables 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-18 14:33:41 +00:00
Kamil Tekiela
2b35303aae
Remove redundant code (#18063) 
PHPStorm has been a little annoying with showing all these code issues. I took some time to analyse most of them and fix whichever were easy to fix. This kind of change should improve future maintenance as developers do not need to wonder what a line of code does. Code that has no impact on functionality should be removed.

* Remove redundant variables
* Invert condition for better clarity
* Remove some of the redundant casts
* Replace switch with an if
* Fix foreach variable
* Remove redundant variable concat
* Remove redundant concats
* Replace for loop with str_repeat
* Remove always true param
* Turn property $position into local var
* Turn Pdf properties into local vars
* Remove unused properties in Pdf
* Change ternary into condition
* Remove redundant assignments
   They are immediately overwritten with a different value.
* Redundant array append
* Collapse if statements into assignments
* Use boolean constants instead of variables
* Remove unneeded parameter
* Remove null-coalesce
* Unnecessary assignment
* Remove redundant isset
* Remove readOnly flag for InsertEdit fields
* Remove function_exists and $mode var
* Remove duplicate condition
* Remove redundant elseif
* Remove redundant isset
* Use hasBodyParam()
* Simplify isRoutesCacheFileValid()
   Psalm complains but is wrong.

https://github.com/phpmyadmin/phpmyadmin/pull/18063

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-15 09:11:05 -03:00
Kamil Tekiela
8a1d6f1eaa Convert var annotations to typed properties 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-12 21:31:04 +00:00
Maurício Meneghini Fauth
ede1e82c28
Refactor DB designer JS to use modules 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-04 18:26:08 -03:00
Evgeny Skorlov
1eb0e001d8
replace superglobas with serverrequest in database/designercontroller 
Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-01-27 11:49:30 -03:00
Kamil Tekiela
7a22334167
Designer controller globals (#17985) 
* Remove globals from DesignerController
* Remove $GLOBALS['params'] in ManageController
* Remove $GLOBALS['params']
* Remove $GLOBALS['total_num_tables']
* Remove $GLOBALS['tooltip_truename']
* Remove $GLOBALS['tooltip_aliasname']
* Remove $GLOBALS['pos']
* Remove $GLOBALS['tables'] (partially)
* Remove $GLOBALS['num_tables'] (partially)
* Remove redundant calls to Util::getDbInfo()
* Move unrelated functionality out of getDbInfo()
* Extract new method getTableListPosition()
* Code style changes
* Update phpstan-baseline.neon

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-01-26 22:58:24 -03:00
ru-asdx
85443b1f5c
replace superglobals with serverrequest in Structure/AddPrefixController, Structure/AddPrefixTableController, (#17980) 
Structure/ChangePrefixFormController, Structure/CopyFormController.php Structure/CopyTableController

Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>
 2023-01-10 21:28:14 -03:00
Maurício Meneghini Fauth
fdf474abf9
Merge pull request #17981 from kamil-tekiela/getTables-investigation 
Improve some type inference in various places

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-12-24 13:44:45 -03:00
Kamil Tekiela
70af3e9c1c Remove $GLOBALS['script_display_field'] & $GLOBALS['fullTableNames'] 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-12-20 18:55:03 +00:00
Kamil Tekiela
ba110e8638 Remove $GLOBALS['tab_pos'] 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-12-20 18:55:03 +00:00
Kamil Tekiela
8b0cf8c16c Remove dependancy in Database/StructureController 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-12-16 20:58:47 +00:00
Kamil Tekiela
47d9ad9b23 Remove always false $_error 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-12-14 17:17:47 +00:00
Kamil Tekiela
7c1bfec7f5 Removal of globals 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-12-13 09:43:01 -03:00
Maurício Meneghini Fauth
66f0c2869a
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-30 15:34:47 -03:00
William Desportes
ddd512cd8b
Fix #15887 - Drop table errors ignored 
Fixes: #15887

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-26 00:22:54 +01:00
Maurício Meneghini Fauth
ca489f3b41
Improve type of DatabaseInterface::getLowerCaseNames() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-19 15:50:14 -03:00
Maurício Meneghini Fauth
d0d90551c3 Remove the dblist global variable 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-13 21:08:00 -03:00
Maurício Meneghini Fauth
7b723d6318
Refactor SavedSearches class to use Exceptions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-10 00:22:37 -03:00
Maurício Meneghini Fauth
77f9ebb61a
Improve error message when UseDbSearch config is disabled 
Replaces Html\Generator::mysqlDie() to avoid calling the exit construct.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-09 14:55:14 -03:00
Maurício Meneghini Fauth
f103bdc1e2
Replace $_REQUEST with ServerRequest in Util::getDbInfo() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-08 00:06:25 -03:00
Maurício Meneghini Fauth
97aac39a40
Remove the sub_part global variable 
It's only used inside Util::getDbInfo() for pagination when not
exporting.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-07 22:06:59 -03:00
Maurício Meneghini Fauth
4044c3bc3c
Remove unnecessary global variable 'data' 
Replaces it with a regular varible.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-06 13:22:46 -03:00
Kamil Tekiela
94ba7d69d2 Remove $params array 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-05 21:24:10 +00:00
Kamil Tekiela
959849f446
Introduce ServerRequest::hasBodyParam() (#17870) 
* Drop Sql::setUiProp()
* Remove ternary operator
* Improve array guard
* Remove redundant isset
* Implement hasBodyParam()
* Add has() and hasQueryParam()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-05 13:04:45 -03:00
pistej
1d619c11ad
Ref #17769 - ServerRequest Object instead superglobals - DB controllers (#17854) 
* Use ServerRequest Object instead superglobals - DB controllers

Signed-off-by: Jozef Pistej <pistej2@gmail.com>

* fixed phpstan

Signed-off-by: Jozef Pistej <pistej2@gmail.com>

Signed-off-by: Jozef Pistej <pistej2@gmail.com>
 2022-10-31 19:51:28 -03:00
Jozef Pistej
f089b5ae3d Use ServerRequest Object instead superglobals - DB/structure controllers 
Signed-off-by: Jozef Pistej <pistej2@gmail.com>
 2022-10-31 19:05:44 +01:00
Maria Papadopoulou
c7e9d9049a
Ref #17769 - Replaced superglobal in LintController (#17828) 
* Replaced superglobal in LintController

Signed-off-by: Maria Papadopoulou <1maria.papa@gmail.com>
 2022-10-29 14:22:52 -03:00
pistej
932933d357
Use ServerRequest Object instead superglobals - CollationController (#17818) 
* Use ServerRequest Object instead superglobals - CollationController controllers

Signed-off-by: Jozef Pistej <pistej2@gmail.com>
 2022-10-29 10:26:42 -03:00
Maurício Meneghini Fauth
187642560c
Fix Database QbeTest 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-20 03:07:47 -03:00
Maurício Meneghini Fauth
816bec5493
Merge pull request #17816 from pistej/server-request-db-controllers-1 
Use ServerRequest Object instead superglobals - MultiTableQuery
 2022-10-20 02:02:19 -03:00
Sebastian Walther
d569fe2f05 Use ServerRequestObject to access POST-vars 
Signed-off-by: Sebastian Walther <swalther@complex-it.de>
 2022-10-20 01:23:50 -03:00
Jozef Pistej
5e23fcde36 Use ServerRequest Object instead superglobals - MultiTableQuery controllers 
Signed-off-by: Jozef Pistej <pistej2@gmail.com>
 2022-10-19 22:48:37 +02:00
Kamil Tekiela
27fad8821e Make Routines a dependency 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-10-18 13:53:15 +01:00
Kamil Tekiela
3e5f101d6f Make Triggers a dependency 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-10-18 13:53:14 +01:00
Maurício Meneghini Fauth
0f57dfff5b
Merge pull request #17800 from kamil-tekiela/Fix-phpstan-issues-2 
Fix PHPStan issues 2
 2022-10-17 20:32:59 -03:00
Maurício Meneghini Fauth
3890d11dd8
Fix some coding style issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-16 17:18:54 -03:00
Maurício Meneghini Fauth
478b1c03a7
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-16 13:52:33 -03:00
Maurício Meneghini Fauth
4d1546f7c5
Fix indentation issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-16 13:41:31 -03:00
Kamil Tekiela
20ce0a8f2f Refactor $GLOBALS['display_page'] 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-10-15 20:15:50 +01:00
Luca Perna
40adf927c5
Move superglobals access to controllers (#17794) 
Related to #16276

Signed-off-by: Luca Perna <luca@perna.rocks>
 2022-10-14 08:34:42 -03:00
Arpit-Gulgulia
4302745a74 Fix:#17769 Signed-off-by: Arpit Jain <arpitgulgulia@gmail.com> 
Signed-off-by: Arpit-Gulgulia <arpitgulgulia@gmail.com>
 2022-10-13 17:36:20 +00:00
Maurício Meneghini Fauth
46fdea0d0e Remove unneeded writing to $_POST in Database\Structure controllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-12 18:07:10 -03:00