Commit Graph

120 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
4ff3724c3f
Use union with null instead of short nullable type
Since union type are now possible, using union with null makes more
clear that it is a union type.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-20 21:48:19 -03:00
Maurício Meneghini Fauth
0ab9e4ac77
Change PHPUnit data providers to use static methods
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-14 12:42:16 -03:00
Maurício Meneghini Fauth
47f1d677b3
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-01-28 13:09:51 -03:00
William Desportes
826ca21e78
Add a group for tests that require ext-xdebug and do not run well on Debian
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-01-28 09:11:01 +01:00
Maurício Meneghini Fauth
de03f00cae
Remove Core::fatalError method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-31 22:18:47 -03:00
Maurício Meneghini Fauth
640ecc5c08
Remove $message_args param from Core::fatalError()
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-31 21:49:54 -03:00
Maurício Meneghini Fauth
103968f352
Replace fatalError() with exception in Core::warnMissingExtension()
Also moves some other calls to Core::warnMissingExtension() to the
Common::checkRequiredPhpExtensions() method.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-31 20:25:55 -03:00
William Desportes
79d447be16
Merge branch 'QA_5_2'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-31 19:32:58 +01:00
Kamil Tekiela
ce628397ab Update Core.php
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-29 23:58:04 +01:00
Kamil Tekiela
f835485588 Remove remaining bits of Sanitize::jsFormat
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-17 21:31:07 +01:00
Maurício Meneghini Fauth
75cf045fa3
Extract url.php entry point into a route
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-08-06 15:02:49 -03:00
Maurício Meneghini Fauth
346923e20a
Set dbi only when the test needs it
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17637

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-14 02:21:45 -03:00
Maurício Meneghini Fauth
f47db6b1a0
Refactor PhpMyAdmin\Core::isAllowedDomain method
Simplifies the requirements and add more unit tests.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-04 23:32:06 -03:00
Maurício Meneghini Fauth
cf7fa38feb
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-26 01:39:57 -03:00
Maurício Meneghini Fauth
5f6966af30
Merge branch 'QA_5_1' into QA_5_2
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-26 01:00:39 -03:00
Maurício Meneghini Fauth
6553bbd5d9
Do not preserve global state for Core::downloadHeader tests
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-26 00:43:06 -03:00
Maurício Meneghini Fauth
924edd57fa
Add unit test for PhpMyAdmin\Core::downloadHeader
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-25 19:35:15 -03:00
Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-07 17:31:11 -03:00
Maurício Meneghini Fauth
411bacf613
Use Sodium for auth cookies encryption
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-13 18:46:04 -03:00
Maurício Meneghini Fauth
0bee94b27e
Merge branch 'QA_5_1-security' into master-security
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-11 14:31:56 -03:00
Maurício Meneghini Fauth
02e8588404
Merge branch 'QA_4_9-security' into QA_5_1-security
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-10 18:39:23 -03:00
Maurício Meneghini Fauth
d057b68aa1
Add unit tests
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-10 12:19:43 -03:00
Maurício Meneghini Fauth
8fd8c35ff2
Fix CoreTest::testMissingExtensionFatal test
The test fails when AJAX is true.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-25 16:34:39 -03:00
Maurício Meneghini Fauth
67e96cf40c
Get default config values from Config\Settings classes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-30 12:04:47 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
8f2f3eff40
Remove the Core::isValid method
This improves the type checking and simplifies the code.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-02 13:20:50 -03:00
Maurício Meneghini Fauth
5725516656
Inline Core::ifSetOr method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-01 13:29:05 -03:00
William Desportes
dd4f0571ac
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-14 14:42:12 +02:00
William Desportes
89365207c6
Add test cases for phpmyadmin/docker#328
Closes: phpmyadmin/docker#328

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-13 02:35:35 +02:00
Maurício Meneghini Fauth
355f6d9d20
Remove PhpMyAdmin\Config::enableBc method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-09 13:59:04 -03:00
Maurício Meneghini Fauth
262cbe45b9
Move some Core methods to Common class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-06 16:52:54 -03:00
Maurício Meneghini Fauth
9adaa912e1
Rename Response class to ResponseRenderer
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-30 12:35:22 -03:00
Maurício Meneghini Fauth
cab899d7b5
Fix some errors found by Psalm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-21 15:58:11 -03:00
Maurício Meneghini Fauth
5cfe084f9e
Fix failing unit test
PhpMyAdmin\Tests\CoreTest::testMissingExtensionFatalWithExtra
    Failed asserting that false is greater than 0.

https://github.com/phpmyadmin/phpmyadmin/runs/2842493560#step:6:573

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-16 17:01:00 -03:00
Maurício Meneghini Fauth
1ed9ab5dda
Fix failing unit test
Random Seeds: 1623610942, 1623612011, 1623680984

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-14 12:41:49 -03:00
Maurício Meneghini Fauth
f3b79d83c0
Add PHPUnit's Covers annotation on test classes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-04 23:39:26 -03:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors
Related to 62f142c9fa.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-03 16:50:33 -03:00
William Desportes
77b5e402c5
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-05-11 01:20:20 +02:00
Liviu-Mihail Concioiu
1c8f9b4d23 Replace secure.php.net with www.php.net and remove Polish and Persian from PHP documentation
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2021-04-26 14:32:03 +02:00
Maurício Meneghini Fauth
33d711215d
Remove the PMA_VERSION constant
Uses the PhpMyAdmin\Version::VERSION constant instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-08 22:22:55 -03:00
Maurício Meneghini Fauth
7e33d227f5
Rename the PMA_Config global variable to config
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-08 15:03:12 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 14:18:35 -03:00
Maurício Meneghini Fauth
db3da81056 Remove some useless comments
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-13 19:56:56 -03:00
William Desportes
0d97b16d16
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-10-13 14:13:03 +02:00
William Desportes
1fcb62e563
Flag 32 bit incompatible tests
Group:  32bit-incompatible

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-10-11 19:05:14 +02:00
Maurício Meneghini Fauth
f2e49a92c6 Fix some type errors detected by PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-30 19:23:01 -03:00
Maurício Meneghini Fauth
e5514a6b66 Fix some PHPStan errors
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-10 21:24:35 -03:00
William Desportes
0340f66740
Fix some tests having wrong typehints
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-17 23:55:49 +02:00
William Desportes
a80153a633
Add typehints using phpcbf on test/*
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-17 22:52:42 +02:00
Maurício Meneghini Fauth
47f0960dce Add return type declaration to test methods
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-07 11:31:33 -03:00