gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
125,608 Commits 12 Branches 481 Tags 2.4 GiB
2722ea717d
Commit Graph

60 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
4ff3724c3f
Use union with null instead of short nullable type 
Since union type are now possible, using union with null makes more
clear that it is a union type.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 21:48:19 -03:00
Maurício Meneghini Fauth
0ab9e4ac77
Change PHPUnit data providers to use static methods 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-14 12:42:16 -03:00
Maurício Meneghini Fauth
346923e20a
Set dbi only when the test needs it 
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17637

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-14 02:21:45 -03:00
Kamil Tekiela
d043ceedc6 Refactor $sql_data 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-03-17 20:46:27 +00:00
Kamil Tekiela
ade85420a8 Inline runQueryPost() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

import
 2022-03-17 20:45:31 +00:00
Kamil Tekiela
ad0acda8b2 Remove parameter 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-03-17 20:23:25 +00:00
Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-07 17:31:11 -03:00
Maurício Meneghini Fauth
58ed5bfa9e
Extract Simulate DML action from ImportController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-27 18:37:15 -03:00
Maurício Meneghini Fauth
0f678e8d7d
Merge branch 'QA_5_1' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-27 16:19:18 -03:00
Maurício Meneghini Fauth
3968808e76
Fix broken link in the Simulate DML query modal 
Fixes #17259

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-27 16:09:07 -03:00
Maurício Meneghini Fauth
3e0856c77b
Remove useless string concatenations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-27 21:40:22 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-15 17:05:40 -03:00
William Desportes
2c28a715b4
Add methods to DbiDummy and AbstractTestCase to control changing databases 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-08-24 02:01:00 +02:00
Maurício Meneghini Fauth
21431578db
Fix some errors found by PHPStan and Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-24 18:03:14 -03:00
Maurício Meneghini Fauth
f3b79d83c0
Add PHPUnit's Covers annotation on test classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-04 23:39:26 -03:00
William Desportes
85afe9a14f
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-12 19:01:36 +02:00
William Desportes
130f7af0c3
Fix tests for #16789 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-12 18:43:51 +02:00
William Desportes
f9e3824172
Add tests for #16789 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-12 18:40:58 +02:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 14:18:35 -03:00
Maurício Meneghini Fauth
db3da81056 Remove some useless comments 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-13 19:56:56 -03:00
Maurício Meneghini Fauth
fbaa1a946e Remove DBI mock from ImportTest 
Uses the DBI stub instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-11 09:09:42 -03:00
William Desportes
a80153a633
Add typehints using phpcbf on test/* 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-07-17 22:52:42 +02:00
Maurício Meneghini Fauth
47f0960dce Add return type declaration to test methods 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-07 11:31:33 -03:00
William Desportes
a300a25319
Replace assertEquals({false,true} by assert{false,true} 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-26 13:13:15 +02:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
0b9c35a056 Remove uses statements from the same namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-24 13:00:24 -03:00
William Desportes
6eaa55e805
Call parent's setUp and tearDown 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-20 21:31:13 +02:00
William Desportes
8ef5143901
Use AbstractTestCase on all unit tests 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-20 21:15:06 +02:00
William Desportes
0b2c24ee26
Use ::class in tests 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-20 12:15:40 +02:00
William Desportes
dfa718c1c6
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-17 16:48:09 +02:00
William Desportes
7fc4722155
Fix #16093 - Error importing utf-8 with bom sql file 
Do not use mb_ functions they are sensible to mb_internal_encoding()

Fixes: #16093

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-17 16:40:16 +02:00
William Desportes
d57de68ae4
Camel case some variables 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-16 00:24:08 +02:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-13 00:23:28 -03:00
William Desportes
972180a862
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-04 09:18:44 +02:00
William Desportes
13651548ae
#16093 - Move BOM stripping to a function and add tests 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-04 00:56:17 +02:00
William Desportes
54e0250dae
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-04-18 12:50:30 +02:00
William Desportes
62a6591d3f
Fix some phpcs issues after latest phpcs 3.5.5 release 
I left the false positives unfixed: https://github.com/squizlabs/PHP_CodeSniffer/issues/2937#issuecomment-615498860
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-04-18 01:01:38 +02:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations 
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
77518d341e Remove unused use statements 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-11 21:20:58 -03:00
Hugues Peccatte
3255e4ad7b Split Util class regarding the responsabilities (#15567) 
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.

There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.

* Split Util class regarding the responsabilities
* Split the buttonOrImage function

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-11-21 20:20:05 -03:00
William Desportes
a9df8a4dbb
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-05 23:15:34 +01:00
William Desportes
9e90099ffa
Merge branch 'QA_4_9' into QA_5_0 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-05 23:10:52 +01:00
William Desportes
f6272067a7
Improve test suite to make it 32bit compatible and more flexible 
Ref: #14906
- Fixes the case where you have FilterLanguages in the local config file
- Fixes the case where the php zip or php bz2 extension is not installed

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-05 22:19:27 +01:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines 
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
208b0e25e1 Use the router for the sql pages 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-08-03 21:25:27 -03:00
Maurício Meneghini Fauth
182491a73f Add void return type declaration for tests 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-22 21:33:55 -03:00
Maurício Meneghini Fauth
23c3579804 Format array declarations 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-07 14:31:39 -02:00