Commit Graph

19 Commits

Author SHA1 Message Date
Kamil Tekiela
aadd4a2d9a Move renderFooter & renderHeader to more appropriate classes
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-24 17:12:23 +00:00
William Desportes
8e721911f0
Merge branch 'QA_5_2'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2024-12-19 02:45:00 +01:00
Maurício Meneghini Fauth
e4375c250d
Merge header.twig and footer.twig into base.twig
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-23 00:32:18 -03:00
Maurício Meneghini Fauth
4adf5a4cad
Remove isAjax from Header and Footer classes
The header and footer will always be empty when the request is ajax, so
only the content part is necessary.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-22 20:42:52 -03:00
Maurício Meneghini Fauth
578ed90b8f
Remove the ResponseRenderer::disable() method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-13 18:13:27 -03:00
Maurício Meneghini Fauth
5e429ffc7d
Extract Footer::setHistory() into a middleware
This is always done after a response, so is better to extract it into a
middleware instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-08 17:11:57 -03:00
Maurício Meneghini Fauth
63ae297cf9
Rename Config\Settings::$DBG to $debug
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-03-17 15:28:20 -03:00
Maurício Meneghini Fauth
c9c286b32a
Replace DBG config array access with Debug class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-03-17 14:37:39 -03:00
Kamil Tekiela
8e4443b17b
Applying suggestions from static analysis tools (#19013)
* Drop array keys from lists

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Import UrlTest

When it doesn't exist in Prod, the code will still work the same.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Drop redundant return [];

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix object access checks

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use strict comparison

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Int keys should be specified as integers

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use empty string check instead of strlen

Potential null deprecations are replaced with loose condition.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use stripos instead of *substr

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify substr's 3rd param

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unnecessary defaults

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace isZeroBasedArray with array_is_list

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify texEscape()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify exportZeroBasedArray()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace for loop with array_diff

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace for with foreach

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove nullable param in backquoteCompat

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use null-coalescing operator

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Inline $result variable

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Turn $event into a constant

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Move selectDb outside the loop

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix code style order of operation

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unnecessary isset argument

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove line break

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use foreach instead of for

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-02-27 12:29:02 -03:00
Maurício Meneghini Fauth
a4276c6b09
Extract Config from Footer class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-12 19:09:33 -03:00
Maurício Meneghini Fauth
a858f08fec Move error related classes to the Error namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-01-05 13:28:23 -03:00
Maurício Meneghini Fauth
1129750eee
Replace server global with Current::$server
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-24 02:08:50 -03:00
Maurício Meneghini Fauth
48ea425d15
Fix some issues with Current::$table
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-17 15:51:33 -03:00
Maurício Meneghini Fauth
ef6c30c865
Replace table global var with static class property
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-17 15:51:29 -03:00
Maurício Meneghini Fauth
ec873965ed
Fix some issues with Current::$database
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-17 14:59:04 -03:00
Maurício Meneghini Fauth
711f6c0f14
Replace db global variable with static class property
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-17 14:58:59 -03:00
Kamil Tekiela
a3d237f0b4 Remove useless in_array
It's always going to be either true or false. There are no other options.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-07 02:15:44 +01:00
Maurício Meneghini Fauth
1ae995b9f1
Refactor the Core::getenv() method
Renames it to getEnv() and adds unit tests for it.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-09-28 16:09:46 -03:00
Maurício Meneghini Fauth
c2955cc2b2
Rename the directory libraries/classes/ to src/
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-30 15:59:28 -03:00