gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
130,953 Commits 12 Branches 481 Tags 2.4 GiB
295263d113
Commit Graph

24 Commits

Author SHA1 Message Date
Kamil Tekiela
6909ef45b3 Merge ColumnFull & Column 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-22 16:38:43 +00:00
Liviu-Mihail Concioiu
0fa9721ed4 Replace selected="selected" with selected 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2025-01-12 03:11:39 +01:00
Kamil Tekiela
8015e4de72 Move DatabaseInterface to Dbal 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-12-22 18:34:53 +00:00
Kamil Tekiela
7416561ecc Remove $GLOBALS['export_type'] from Tracker 
It could not have been anything than null.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-12-13 23:22:18 +00:00
Kamil Tekiela
dce24cca42 Make parameters a primitive type 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-12-13 23:19:53 +00:00
Kamil Tekiela
1f3081cc76 Cache isAnyTrackingInProgress 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-10-15 22:07:30 +01:00
Kamil Tekiela
26eed395e8 Make value objects readonly 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-08-16 11:40:56 +02:00
Maurício Meneghini Fauth
90ee00efd5
Create the 'pma' global variable for Twig templates 
Creates the Twig\PmaGlobalVariable class to handle the 'pma' Twig global
variable.

The idea of this global variable is to automatically inject in all
templates some useful information.

For now it only includes `pma.version` to get the phpMyAdmin version
and `pma.text_dir` to get the text direction ('ltr' or 'rtl').

Adding new variables to the `pma` global variable should be done with
caution.

- https://twig.symfony.com/doc/3.x/advanced.html#globals

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-07-09 20:30:48 -03:00
Kamil Tekiela
0773e5d9a9 Create LogType enum 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-05-17 00:36:15 +02:00
Kamil Tekiela
1b0df7ecca Rename LogTypeEnum to TrackedDataType 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-05-17 00:36:15 +02:00
Kamil Tekiela
6c96e792e3 Compile the HTML string before returning it 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-05-17 00:36:15 +02:00
Kamil Tekiela
54b5464ec2 Replace function casts with normal casts 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-03-03 15:07:57 +01:00
Kamil Tekiela
8e4443b17b
Applying suggestions from static analysis tools (#19013) 
* Drop array keys from lists

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Import UrlTest

When it doesn't exist in Prod, the code will still work the same.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Drop redundant return [];

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix object access checks

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use strict comparison

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Int keys should be specified as integers

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use empty string check instead of strlen

Potential null deprecations are replaced with loose condition.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use stripos instead of *substr

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify substr's 3rd param

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unnecessary defaults

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace isZeroBasedArray with array_is_list

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify texEscape()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify exportZeroBasedArray()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace for loop with array_diff

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace for with foreach

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove nullable param in backquoteCompat

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use null-coalescing operator

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Inline $result variable

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Turn $event into a constant

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Move selectDb outside the loop

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix code style order of operation

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unnecessary isset argument

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove line break

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use foreach instead of for

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-02-27 12:29:02 -03:00
Kamil Tekiela
79a68a4349
Add type hints instead of mixed (#18976) 
* Remove some empty() statements

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix docbloc

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type hint to getHtmlForOneKey()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to buildColumnCreationStatement()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add return type to fetchByMode()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getCompatibilities()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getDirContent

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getCharLists()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to executeSqlQuery()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to findLineNumberAndColumn

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to lint()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getHtmlForNewTables3NF()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getViewsAndCreateSqlViewStandIn()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getPossibleRowFormat()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getTableAltersArray()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getValuesForColumn()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getAvailableMimeTypes()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add types to TwigLintCommand

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to isRowCountApproximated

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getReplicationStatus()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type in formatVariable()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to fetchSingleRow()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getPages()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to CentralColumns::getParams()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to removeRelation()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getWarnings()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getTableCommentsArray()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix docbloc comment

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to sanitizeUrl()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to uploadProgressSetup()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to explodeMarkup()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add types in Table

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getHtmlForDataStatements()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-02-07 19:19:12 -03:00
Maurício Meneghini Fauth
3353b47721
Create ConnectionType enum 
Replaces Connection::TYPE_* constants with ConnectionType enum.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-01-29 12:47:15 -03:00
Kamil Tekiela
f150ed40a9 Update PHPDoc comments 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-01-12 14:57:46 +01:00
Kamil Tekiela
a6fe544cc0 Remove outdated comment 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-01-11 23:45:04 +01:00
Kamil Tekiela
349ae8de27 Replace mb_strstr 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-01-11 23:43:58 +01:00
Kamil Tekiela
4e8c62f885 Fix initialization of Relation and Tracker 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-01-09 18:09:39 +01:00
Maurício Meneghini Fauth
ec873965ed
Fix some issues with Current::$database 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-12-17 14:59:04 -03:00
Maurício Meneghini Fauth
711f6c0f14
Replace db global variable with static class property 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-12-17 14:58:59 -03:00
Kamil Tekiela
b658499250 Fix type hint in Tracking 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-12-07 02:15:44 +01:00
Kamil Tekiela
ed59318fbe Refactor getColumn and getColumns 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-09-02 16:24:55 +01:00
Maurício Meneghini Fauth
c2955cc2b2
Rename the directory libraries/classes/ to src/ 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-08-30 15:59:28 -03:00