Commit Graph

29 Commits

Author SHA1 Message Date
William Desportes
9178602e6c
Fix #14614 - "# 2014 - Commands out of sync; you can't run this command now" returned when stored procedure does not return any result set
Fixes: #14614
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-29 23:08:23 +02:00
William Desportes
2da5d8f390
Fix #14931 - count(): Parameter must be an array or an object that implements Countable, ./libraries/classes/Sql.php#1623
Fixes: #14931
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-23 08:53:12 +01:00
Dhyey Thakore
7d66500669 Fix #14607 - Count rows only if needed (#14821)
Signed-off-by: Dhyey Thakore <dhyey35@gmail.com>
(cherry picked from commit feca784567)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-03-05 16:13:38 -03:00
Vincent Milum Jr
31b40f71bb Fix for SYSTEM VERSIONED tables #14514, #14515, and #14516 (#14536)
Fixes #14514
Fixes #14515
Possible fix for #14516

 #14514 Tables which enable the new MariaDB 10.3 versioning show up as "SYSTEM VERSIONED" instead of "BASE TABLE" inside of information schema. This patch now checks for both, so these new table types don't incorrectly display as views.

 #14515 MariaDB 10.3 also supports INVISIBLE columns, which is optionally paired with SYSTEM VERSIONED tabled (or implemented separately). This patch helps handle this new column attribute.

 #14516 This patch cannot be fully tested and verified with current MariaDB builds. Version 10.3.9 (currently unreleased) corrects an issue with column information for SYSTEM VERSIONED columns that this patch relies on. https://jira.mariadb.org/browse/MDEV-16804 - the reason for checking with preg_match instead of adding to the list is because there are now combined "extra" information for columns, such as INVISIBLE columns. Just matching entire strings also has a bug with these other "extra" parameters.

Signed-off-by: Vincent Milum Jr <git@darkain.com>
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
(cherry picked from commit 3f6e360a4e)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-15 17:27:55 -02:00
Maurício Meneghini Fauth
e7e7d56c75 Retrieve parameters from $_POST in browse foreigners
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:59 -02:00
Maurício Meneghini Fauth
5109c1787e Retrieve parameters from $_POST in sql pages
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:58 -02:00
Madhura Jayaratne
00d90b3ae4 Fix #14548 [security] HTML injection in import warning messages
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2018-08-18 23:19:58 +10:00
Lakshay arora
0da5857b5d Fix for issues with spatial fields (#14125)
*  Fix for issues with spatial fields

Fixes the following issues:

1.    #14068 SPATIAL fields with no unique index/autoincrement error when clicking
      This error occurs when there is no unique column to uniquely identify a tuple. I've disabled the geomtery view and made view as wkt the default view in such cases.

2.    #14121 View spatial fields as WKT doesn't work

1.    #14067 IS NULL search operator produces no WHERE SQL with spatial fields

Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

* Fix for issues with spatial fields
This commit fixes view as BINARY not working in the previous commit.
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

* Fix for issues with spatial fields

Fixes typo in previous commits.

Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
(cherry picked from commit 9231620c2d)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-12 03:54:28 -03:00
Maurício Meneghini Fauth
d98658187a Replace PhpMyAdmin\Relation static calls
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-25 19:32:13 -03:00
Maurício Meneghini Fauth
0889b52c36 Replace static methods with instance methods
Replace PhpMyAdmin\Sql static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-27 17:39:16 -03:00
Maurício Meneghini Fauth
a862add418 Replace static methods with instance methods
Replace PhpMyAdmin\Operations static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-25 12:43:49 -03:00
Michal Čihař
89d40d5e8d Merge branch 'QA_4_7' 2018-01-16 16:02:38 +01:00
Michal Čihař
bed6fb4ebd Avois passing extension to Util::getImage
We do not use it anyway for quite some time and this way it's less
processing to generate the img tag.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-27 14:24:42 +01:00
Michal Čihař
22efbd263e Fix typo in transformation
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-14 10:48:43 +01:00
Maurício Meneghini Fauth
7f137aa587 Replace globals with DI in PhpMyAdmin\Bookmark
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-04 15:14:56 -02:00
Michal Čihař
feb56e7f49 Correctly define connection type
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-25 10:21:18 +02:00
Michal Čihař
63bae14110 Make some checks on variables more robust
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-02 16:18:21 +02:00
Michal Čihař
d2d32651bc Replace empty() by strlen()
In order to fix operation with database or table called 0.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-02 15:53:44 +02:00
Maurício Meneghini Fauth
1d4125f15c Add array type declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-24 23:49:59 -03:00
Maurício Meneghini Fauth
56fe75d730 Refactor sql_query_form functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-13 19:09:59 -03:00
Maurício Meneghini Fauth
15d8ee270f Refactor relation_cleanup functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-12 18:14:37 -03:00
Maurício Meneghini Fauth
1354b45b12 Refactor parse_analyze function to static method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-12 16:51:21 -03:00
Maurício Meneghini Fauth
82dc32305b Rename DisplayResults to Display/Results
Move libraries/classes/DisplayResults.php to libraries/classes/Display/Results.php

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-06 21:13:54 -03:00
Michal Čihař
f52beffd3d Merge branch 'QA_4_7' 2017-09-04 15:07:21 +02:00
Maurício Meneghini Fauth
e2c83b954b Refactor relation functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-08-22 20:51:27 -03:00
Maurício Meneghini Fauth
0d11ecc728 Refactor operations functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-08-20 21:28:36 -03:00
Michal Čihař
9404287ac0 Show MySQL warnings when executing SQL queries
Fixes #13408

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-08-01 16:29:44 +02:00
Maurício Meneghini Fauth
ca910e8de8 Move classes to PhpMyAdmin namespace
- Move Table to PhpMyAdmin namespace
- Move Template to PhpMyAdmin namespace
- Move ThemeManager to PhpMyAdmin namespace
- Move Theme to PhpMyAdmin namespace
- Move Tracker to PhpMyAdmin namespace
- Move Transformations to PhpMyAdmin namespace
- Move TypesMySQL to PhpMyAdmin namespace
- Move Types to PhpMyAdmin namespace
- Move Util to PhpMyAdmin namespace
- Move VersionInformation to PhpMyAdmin namespace
- Move Url to PhpMyAdmin namespace

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-07-08 10:54:21 -03:00
Maurício Meneghini Fauth
8f943ae1c0 Move classes to PhpMyAdmin namespace
- Move Sanitize to PhpMyAdmin namespace
- Move SavedSearches to PhpMyAdmin namespace
- Move Scripts to PhpMyAdmin namespace
- Move ServerStatusData to PhpMyAdmin namespace
- Move Sql to PhpMyAdmin namespace
- Move StorageEngine to PhpMyAdmin namespace
- Move SubPartition to PhpMyAdmin namespace
- Move SysInfoLinux to PhpMyAdmin namespace
- Move SysInfoSunOS to PhpMyAdmin namespace
- Move SysInfoWINNT to PhpMyAdmin namespace
- Move SysInfo to PhpMyAdmin namespace
- Move SystemDatabase to PhpMyAdmin namespace

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-07-07 01:46:08 -03:00