gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
127,175 Commits 12 Branches 481 Tags 2.4 GiB
2dd24efbe6
Commit Graph

101 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
9e9611d162
Replace config global with Config singleton 
This is as bad as the global variable, however at least will have better
static analysis of it.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-08-15 01:11:54 -03:00
Maurício Meneghini Fauth
2ba2e80d39
Refactor ErrorHandler::dispFatalError() to use a Response object 
Removes the dependency on ResponseRenderer for this method.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-08-09 16:47:56 -03:00
Maurício Meneghini Fauth
5dc23aec19
Create the ErrorHandling middleware 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-08-08 16:14:34 -03:00
Maurício Meneghini Fauth
22c6a2f9d8
Add a wrapper around the exit language construct 
Creates the PhpMyAdmin\ResponseRenderer::callExit() method as a wrapper
to the exit language construct. That makes the tests more correct as the
method will always stop the code execution.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-06-06 21:54:07 -03:00
Maurício Meneghini Fauth
a4940d79ec
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-06-06 14:46:01 -03:00
Maurício Meneghini Fauth
7b88ab16af
Fix a case where a fatal error message was not displayed 
A fatal error message was not displayed when the ResponseRenderer object
already had some HTML, because the output buffer is only displayed when
there is no HTML.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-06-03 17:01:51 -03:00
Kamil Tekiela
f4f2f93b1c NullableCompareToNullRector 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-27 21:58:12 +01:00
Kamil Tekiela
176645be7b Shorten else/if to elseif 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-12 00:12:58 +01:00
Kamil Tekiela
0bdcaba2d2
Add native property types (#18143) 
* Add native property types

Includes TypeHints.UnionTypeHintFormat

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Set some default values for properties

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Format and promote properties

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove redundant asserts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant cast

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $tmanager->theme is never null

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant variable

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix empty on $statementInfo bool

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant casts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant issets

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* getPacked() returns nullable string

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant if

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $this->content can be null

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify ThemeManager::getInstance()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use isset for checking if property is initialized

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use nullable instead of uninitialized property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* password is no longer nullable

I can't verify that none of the globals ever tried to set it to null, but the variable should never be nullable.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $same_wide_width param can be float or int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update Message.php

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast Sub_part to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix one line doc comments

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-26 23:30:41 -03:00
Maurício Meneghini Fauth
77957a69a5
Add trailing comma for multi-line functions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-24 20:48:46 -03:00
Maurício Meneghini Fauth
4ff3724c3f
Use union with null instead of short nullable type 
Since union type are now possible, using union with null makes more
clear that it is a union type.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 21:48:19 -03:00
Maurício Meneghini Fauth
48f671d956
Replace get_class() with ::class constant 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 18:58:13 -03:00
Kamil Tekiela
80c4db7253 Use strict check when type is known 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-19 23:19:54 +00:00
Kamil Tekiela
b6f0da1c09 Convert to first class callables 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-14 14:18:23 +00:00
Kamil Tekiela
8a1d6f1eaa Convert var annotations to typed properties 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-12 21:31:04 +00:00
Maurício Meneghini Fauth
930f8826d3
Remove dead code for old PHP versions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-12 13:59:40 -03:00
Maurício Meneghini Fauth
729b21b911
Extract Functions.ignorePhpErrors() into a module 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-12-10 19:24:20 -03:00
Maurício Meneghini Fauth
3bc3c7de4d
Extract Functions.ajaxShowMessage() into ajax-messages.js 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-12-06 08:21:58 -03:00
Kamil Tekiela
0e59b1a2c0 Redundant $error instanceof Error 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-10-15 21:16:04 +01:00
Maurício Meneghini Fauth
6a5cb9f66e
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-26 17:30:39 -03:00
Maurício Meneghini Fauth
9d7582a2c0
Hide deprecation notices 
Do not show deprecation notices when not in a development environment.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-26 16:27:00 -03:00
Maurício Meneghini Fauth
e4ea2308c0
Assign Messages global var to the window object 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-02 11:23:07 -03:00
Maurício Meneghini Fauth
a4f8c18808
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-20 14:48:45 -03:00
Maurício Meneghini Fauth
827e32a92e
Improve ErrorHandler::handleException to show errors 
It doesn't shows a blank page when not in development environment
anymore.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-19 20:56:24 -03:00
Maurício Meneghini Fauth
2c5143feda Remove ResponseRenderer::getFooter method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-04-09 12:32:14 -03:00
Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-07 17:31:11 -03:00
Maurício Meneghini Fauth
d1b99c4a15 Fix merge conflicts 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-11 10:07:02 -03:00
Isaac Bennetch
5127b31144 Fix merge conflicts 
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
 2022-02-10 23:38:23 -05:00
Maurício Meneghini Fauth
c04f85f2bb Fix path disclosure on misconfigured servers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-10 20:59:06 -06:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
9f3510d11a
Add bool return type where possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-14 20:11:51 -03:00
William Desportes
8d19bef81d
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-08-22 23:19:15 +02:00
William Desportes
38c263359e
Ref #17084 - comment the code and add a new test case 
And fix the modified test

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-08-20 02:30:02 +02:00
Craig McNeill
af835bc52c Fix ErrorHandler sliceErrors not returning errors 
Signed-off-by: Craig McNeill <craig@mmddata.ca>
 2021-08-18 14:40:52 -04:00
Maurício Meneghini Fauth
04d3c83559
Fix some errors found by PHPStan/Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-08-05 16:09:08 -03:00
Maurício Meneghini Fauth
9adaa912e1
Rename Response class to ResponseRenderer 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-30 12:35:22 -03:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors 
Related to 62f142c9fa.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-03 16:50:33 -03:00
Maurício Meneghini Fauth
9c32a55def
Turn errors into exceptions when in development env 
Changes error messages into ErrorException when using
`$cfg['environment'] = 'development';`.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-03 11:53:54 -03:00
Maurício Meneghini Fauth
3d539b78e6
Merge branch 'QA_5_1' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-27 16:07:09 -03:00
Maurício Meneghini Fauth
6b0a10d8ca
Rename the error_handler global to use camel case 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-16 12:11:51 -03:00
William Desportes
8992ef095f
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-14 11:54:03 +01:00
William Desportes
c4c32c374d
Fix #16729 - fix silencing code for PHP >= 8.0 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-12 19:23:03 +01:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 14:18:35 -03:00
Maurício Meneghini Fauth
4f574e53c3
Replace error report jquery-ui's dialog with a modal 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-01-12 17:28:23 -03:00
Maurício Meneghini Fauth
00151b5f1c
Remove some custom CSS utilities 
Uses Bootstrap equivalents instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-12-22 13:18:58 -03:00
Maurício Meneghini Fauth
db3da81056 Remove some useless comments 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-13 19:56:56 -03:00
Maurício Meneghini Fauth
e66be179ca Use camel case naming for class members 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-05 10:37:07 -03:00
William Desportes
bcf21c4081
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-07-28 18:12:30 +02:00
William Desportes
0e344b6a50
Fix #16256 - Warning: error_reporting() has been disabled for security reasons on php 7.x 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-07-25 19:49:52 +02:00