gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
127,175 Commits 12 Branches 481 Tags 2.4 GiB
2dd24efbe6
Commit Graph

281 Commits

Author SHA1 Message Date
Kamil Tekiela
0ac564169f Create method getHtmlForStoredProcedureResults() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-08-15 10:51:07 +01:00
Kamil Tekiela
f58c647271 Refactor $extraData and show_as_php 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-08-15 10:51:07 +01:00
Kamil Tekiela
d31c78c60b Refactor routine execution in Sql 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-08-15 10:51:07 +01:00
Maurício Meneghini Fauth
baa687b8c7
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-08-15 01:02:53 -03:00
Kamil Tekiela
910c43db3b Fix: Cannot execute stored procedure with SELECT using the SQL tab 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-08-07 13:59:48 +01:00
Sachin Bahukhandi
0c7848083d
Fixed the Pagination missing when using SELECT DISTINCT (#18493) 
Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com>
(cherry picked from commit 73efd6e03e)
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-07-13 15:11:23 -03:00
Sachin Bahukhandi
73efd6e03e
Fixed the Pagination missing when using SELECT DISTINCT (#18493) 
Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com>
 2023-07-13 15:09:06 -03:00
cbasguti
2a66496d61 fix: Format query not working inside view modal 
Query formatting didn't work inside Create view modal, when table has 0 rows.

Signed-off-by: cbasguti <sebastian.gutierrezj@udea.edu.co>
 2023-06-27 22:46:49 +02:00
Maurício Meneghini Fauth
6cda25211e
Replace jqPlot with Chart.js for the profiling chart 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-06-17 23:44:04 -03:00
Maurício Meneghini Fauth
70ff7dcd6b
Improve return type of Sql::getDetailedProfilingStats() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-06-07 16:01:10 -03:00
Maurício Meneghini Fauth
b38b011a48
Improve type declaration of Sql::getDetailedProfilingStats() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-06-07 16:01:10 -03:00
Maurício Meneghini Fauth
22c6a2f9d8
Add a wrapper around the exit language construct 
Creates the PhpMyAdmin\ResponseRenderer::callExit() method as a wrapper
to the exit language construct. That makes the tests more correct as the
method will always stop the code execution.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-06-06 21:54:07 -03:00
Maurício Meneghini Fauth
b8c26e9609
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-06-02 16:43:57 -03:00
Maurício Meneghini Fauth
64eceff4f9
Fix state times not getting summed in the profiling table 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-06-02 16:31:10 -03:00
Maurício Meneghini Fauth
1be42d13de
Create the Identifiers\Identifier interface 
Changes Dbal\DatabaseName, Dbal\TableName and Triggers\TriggerName to
implements the new Identifier\Identifier interface.
Moves Dbal\DatabaseName, Dbal\TableName and Triggers\TriggerName to the
Identifiers namespace.
Renames the tryFromValue() and fromValue() methods to just tryFrom() and
from() respectively.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-06-01 19:09:25 -03:00
Maurício Meneghini Fauth
e7d1ecbeae
Merge pull request #18419 from kamil-tekiela/UseIdenticalOverEqualWithSameTypeRector 
UseIdenticalOverEqualWithSameTypeRector
 2023-05-16 17:28:52 -03:00
Kamil Tekiela
4ec3b99ba3
Improve boolean conditions with arrays (#18417) 
* Remove empty() on array

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove boolean count()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-12 15:16:26 -03:00
Kamil Tekiela
0f351a5822 UseIdenticalOverEqualWithSameTypeRector 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-12 19:13:49 +01:00
Maurício Meneghini Fauth
77dc78e32b
Merge pull request #18410 from kamil-tekiela/never-type 
Add never type
 2023-05-12 11:21:49 -03:00
Kamil Tekiela
dc471985b9
Short boolean conditions (#18413) 
* Short boolean conditions

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify conditions

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-12 11:09:21 -03:00
Kamil Tekiela
111640ef36 Add never type 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-11 23:32:35 +01:00
Erki Aring
c716102d09
Add configuration option to allow shared bookmarks 
Signed-off-by: Erki Aring <erki@example.ee>
 2023-04-14 12:09:01 +03:00
Maurício Meneghini Fauth
6a2c12bdc8
Add missing traversable type hints 
Replace array type hint with mixed[] type hint, since it means the same.
This way it's possible to require traversable type hint for new code.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-04-02 01:32:12 -03:00
Maurício Meneghini Fauth
dd885dc7b8
Use single-line arrays when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-27 17:39:17 -03:00
Maurício Meneghini Fauth
e5698c85e9
Require single line for function calls 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-26 23:10:10 -03:00
Maurício Meneghini Fauth
437215cab2
Rename variables to use camel case format 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-26 21:47:50 -03:00
Kamil Tekiela
d698bdf80a Create DeleteLinkEnum 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-22 12:55:24 +00:00
Kamil Tekiela
8a5ce0b557 Split long lines 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-17 12:48:12 +00:00
Kamil Tekiela
555c6798eb Add native param types 
Includes TypeHints.UnionTypeHintFormat

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-17 12:45:18 +00:00
Kamil Tekiela
ef274bd7e8 Fix countRecords return int instead of mixed 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-08 19:56:50 +00:00
Kamil Tekiela
0bdcaba2d2
Add native property types (#18143) 
* Add native property types

Includes TypeHints.UnionTypeHintFormat

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Set some default values for properties

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Format and promote properties

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove redundant asserts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant cast

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $tmanager->theme is never null

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant variable

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix empty on $statementInfo bool

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant casts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant issets

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* getPacked() returns nullable string

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant if

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $this->content can be null

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify ThemeManager::getInstance()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use isset for checking if property is initialized

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use nullable instead of uninitialized property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* password is no longer nullable

I can't verify that none of the globals ever tried to set it to null, but the variable should never be nullable.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $same_wide_width param can be float or int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update Message.php

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast Sub_part to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix one line doc comments

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-26 23:30:41 -03:00
Maurício Meneghini Fauth
77957a69a5
Add trailing comma for multi-line functions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-24 20:48:46 -03:00
Kamil Tekiela
902d1a1e77
Add native return type hints (#18126) 
* Add remaining native return type hints to flush out bugs

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast the mixed value to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* getAutoIncrement() is supposed to return string

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast values to string in DummyResult

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Make getCollation() return non-nullable string

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast seqInIndex to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast $cardinality to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* createFile may return false

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove redundant cast

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-23 15:43:36 -03:00
Maurício Meneghini Fauth
4ff3724c3f
Use union with null instead of short nullable type 
Since union type are now possible, using union with null makes more
clear that it is a union type.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 21:48:19 -03:00
Maurício Meneghini Fauth
785f8c1c00
Use constructor property promotion where possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 19:39:02 -03:00
Maurício Meneghini Fauth
613678f8f5
Replace assignments with null coalesce equal operator 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 17:03:05 -03:00
Kamil Tekiela
80c4db7253 Use strict check when type is known 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-19 23:19:54 +00:00
Kamil Tekiela
cfe54a501b Add union types 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-15 15:23:28 +00:00
Kamil Tekiela
8a1d6f1eaa Convert var annotations to typed properties 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-12 21:31:04 +00:00
Maurício Meneghini Fauth
0819043d0e
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-08 14:09:59 -03:00
William Desportes
2443570ce6
Merge #17851 - Fix #17028, #17683 - Re build query count management 
Pull-request: #17851
Fixes: #17028
Fixes: #17683

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-02-08 13:12:00 +01:00
Maurício Meneghini Fauth
ef385e2259
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-01 22:04:27 -03:00
Liviu-Mihail Concioiu
f45cd23222 Remove double quotes 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2023-01-31 22:57:56 +01:00
Maurício Meneghini Fauth
551c317aee
Merge pull request #17982 from kamil-tekiela/Elvis 
Remove usage of elvis operator

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-12-24 13:46:33 -03:00
Kamil Tekiela
6264f6f1ea
Various refactorings 2 (#17965) 
* Remove extra blank lines
* Remove useless param annotations
* Refactor Index::singleton
* Refactor Config.php
* Refactor Header::addRecentTable()
* Collapse return statement into a single line
* Refactor Message.php
* Convert $getUniqueCondition into a scalar
* Code style
* Fix invalid return phpdoc
* Remove unused variable
* Remove redundant empty array checks
* Refactor Export::closeFile()
* Simplify else statement
* Remove redundant else
* Refactor TablePartitionDefinition::getDetails
* Simpler returns
* Add types for getCellContent()
* Remove useless method mngInsideStructComm

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-12-24 12:54:23 -03:00
Kamil Tekiela
9a8dc40ae9 Remove usage of elvis operator 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-12-20 19:50:58 +00:00
William Desportes
b820730f84
Fix PR #17906 on master branch 
Pull-request: #17906

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-19 19:31:41 +01:00
William Desportes
a60437f04a
Merge branch 'QA_5_2' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-19 19:09:44 +01:00
iifawzi
b7bf83c24c Default to "Full texts" when running ANALYZE 
Signed-off-by: iifawzi <iifawzie@gmail.com>
 2022-11-18 17:00:10 +02:00
Kamil Tekiela
959849f446
Introduce ServerRequest::hasBodyParam() (#17870) 
* Drop Sql::setUiProp()
* Remove ternary operator
* Improve array guard
* Remove redundant isset
* Implement hasBodyParam()
* Add has() and hasQueryParam()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-05 13:04:45 -03:00