gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
127,175 Commits 12 Branches 481 Tags 2.4 GiB
2dd24efbe6
Commit Graph

577 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
9e9611d162
Replace config global with Config singleton 
This is as bad as the global variable, however at least will have better
static analysis of it.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-08-15 01:11:54 -03:00
Maurício Meneghini Fauth
baa687b8c7
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-08-15 01:02:53 -03:00
Maurício Meneghini Fauth
93fa48e286
Refactor the ServerRequest::getRoute() method 
Extracts the redirection to database and table pages to the
HomeController for an actual redirection instead of an implicit one.

Removes the Application::getRequest() method as the ServerRequest object
should be an immutable object.

Adds a Routing::$route static variable to be used at the places that the
ServerRequest object is not available.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-08-12 01:45:12 -03:00
Maurício Meneghini Fauth
5f9ba2e1d1
Extract Relation and Template dependencies from UserPreferences 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-08-09 15:04:34 -03:00
Maurício Meneghini Fauth
c0d04b6895
Add a Response object to ResponseRenderer class 
Uses a Response object to handle the HTTP headers and HTTP status code.

This makes the AbstractNetworkTestCase obsolete and removes it.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-08-07 22:27:48 -03:00
Kamil Tekiela
910c43db3b Fix: Cannot execute stored procedure with SELECT using the SQL tab 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-08-07 13:59:48 +01:00
Maurício Meneghini Fauth
a520e235eb
Move Core::sendHeaderLocation() to ResponseRenderer::redirect() 
Removes the IIS specific logic.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-08-06 17:43:42 -03:00
Maurício Meneghini Fauth
57fd47a170
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-08-06 14:08:54 -03:00
Maurício Meneghini Fauth
d3c01539c7
Fail tests with not supported queries 
Instead of marking them as incomplete.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-08-06 13:42:03 -03:00
Maurício Meneghini Fauth
63e6410728
Refactor the DbTableExists class 
- Changes static methods to instance methods
- Extract response handling to the controllers
- Add unit tests for the DbTableExists class
- Remove the AbstractController::hasDatabase() method

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-08-06 01:42:06 -03:00
Maurício Meneghini Fauth
eff6872c83
Fix PHPUnit 10.3 soft deprecations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-08-04 13:58:06 -03:00
Maurício Meneghini Fauth
45b58d7eea
Refactor JavaScriptMessagesController to return a Response object 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-07-30 17:22:18 -03:00
Maurício Meneghini Fauth
bd3d0a6c03
Merge pull request #18585 from kamil-tekiela/$triggers-!==-] 
Redesign Triggers::getDetails()
 2023-07-28 18:37:03 -03:00
Kamil Tekiela
93263d9ce3 Redesign Triggers::getDetails() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-07-28 22:28:24 +01:00
Kamil Tekiela
1a2d2a472b Remove session cache in Relation 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-07-27 12:02:12 +01:00
Maurício Meneghini Fauth
19dad3b153
Add a isAjax() method to ServerRequest class 
This method belongs to the ServerRequest class instead of the
ResponseRenderer class, as it's a request property.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-07-26 16:01:37 -03:00
Maurício Meneghini Fauth
c8a50637f4
Remove Template and ResponseRenderer dep from Routines class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-07-24 15:04:53 -03:00
Maurício Meneghini Fauth
32b92568f3
Inline the Events::getEditorForm() method 
Moves the response handling to the controller.
Removes the dependency on ResponseRenderer and Template from the Events
class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-07-23 18:28:28 -03:00
Maurício Meneghini Fauth
2a0d7e21a9
Inline the Triggers::getEditorForm() method 
Removes the dependency on ResponseRenderer and Template from the
Triggers class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-07-23 15:44:28 -03:00
Maximilian Krög
bb34e72917
Construct ReflectionProperty directly 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-07-21 19:07:30 +02:00
Maximilian Krög
7c842b6021
Change deprecated ReflectionProperty method call 
Is being deprecated in PHP 8.3

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-07-21 19:07:24 +02:00
Maurício Meneghini Fauth
ea30194be2
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-07-21 10:01:52 -03:00
Maximilian Krög
d716e30e60
Change deprecated ReflectionProperty method call 
Is being deprecated in PHP 8.3

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-07-20 01:30:37 +02:00
Maurício Meneghini Fauth
eaad8d8a1c
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-07-15 15:19:35 -03:00
William Desportes
4655646219
Fix testCheckFavoriteTable 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-07-14 17:47:32 +02:00
Maurício Meneghini Fauth
b0604623d8
Extract PageSettings dependency from controllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-07-06 20:17:34 -03:00
Maurício Meneghini Fauth
95ae4f7612
Extract Config\PageSettings initialization from constructor 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-07-06 16:37:40 -03:00
Maurício Meneghini Fauth
f23ab54ca9
Move the Export class to the Export namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-06-28 12:28:38 -03:00
Sachin Bahukhandi
aad3b57792
Fixed the test cases (#18479) 
* Fixed the test cases

Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com>

* Modified the docblocks as suggested

Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com>

* Update test/classes/Controllers/Table/ImportControllerTest.php

Added the changes suggested by team

Co-authored-by: William Desportes <williamdes@wdes.fr>
Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com>

* modified the docblock

Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com>

* modified the docblock

Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com>

* modified the docblock

Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com>

* modified the docblock

Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com>

* Removed sodium extension required check  as suggested

Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com>

---------

Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com>
Co-authored-by: William Desportes <williamdes@wdes.fr>
 2023-06-28 09:07:17 -03:00
Maurício Meneghini Fauth
531d6ad2c5
Merge pull request #18374 from MoonE/test-query-return-value 
Fix dummy query return value in tests
 2023-06-28 09:02:28 -03:00
ru-asdx
62a2b7fa34
Replace superglobals with serverrequest in ReplaceController (#18501) 
* Replace superglobals with serverrequest in ReplaceController

Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>

* fixes

Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>

---------

Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>
 2023-06-26 14:48:40 -03:00
Maurício Meneghini Fauth
826b1c7aaf
Replace system monitor setting popup with a collapse button 
Also replace settings links with buttons.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-06-19 21:31:21 -03:00
Maurício Meneghini Fauth
ddbc1afd28
Replace system monitor tab links with buttons 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-06-19 21:28:34 -03:00
Maurício Meneghini Fauth
b50b80da02
Fix Table\StructureControllerTest failing test 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-06-13 22:07:44 -03:00
Maurício Meneghini Fauth
de58d27326
Remove .pma-fieldset and related CSS classes 
Replaces most of them with the Bootstrap card component.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-06-11 00:37:39 -03:00
Maurício Meneghini Fauth
bea5211660
Add basic unit test for BrowseForeignersController class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-06-09 15:56:09 -03:00
Maurício Meneghini Fauth
3f2c53ef1d
Replace PHPUnit annotations with attributes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-06-07 11:44:01 -03:00
Maurício Meneghini Fauth
22c6a2f9d8
Add a wrapper around the exit language construct 
Creates the PhpMyAdmin\ResponseRenderer::callExit() method as a wrapper
to the exit language construct. That makes the tests more correct as the
method will always stop the code execution.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-06-06 21:54:07 -03:00
Maurício Meneghini Fauth
bc553ffcc3
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-29 17:35:29 -03:00
Maurício Meneghini Fauth
746a34c009
Fix the actions not being hidden in the Triggers, Routines, Events pages 
Fixes #17392

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-29 16:46:42 -03:00
Maurício Meneghini Fauth
5a344966a9
Move trigger row foreach loop into the list.twig template 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-25 16:03:45 -03:00
Maurício Meneghini Fauth
81e988aac8
Inline Triggers::main() into the Triggers\IndexController 
The main() method is handling the request/response, so it's better to
move this code to the controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-25 15:40:16 -03:00
Maurício Meneghini Fauth
74b1ffbf8c
Merge the DB and table trigger controllers 
They are equivalent in current form.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-25 15:39:36 -03:00
Maurício Meneghini Fauth
44f2b4d5bd
Merge pull request #18390 from ru-asdx/refactor-17769-p2 
Replace superglobals with serverrequest in GetFieldController
 2023-05-24 15:31:24 -03:00
Maurício Meneghini Fauth
9e56194fc0
Fix issue with inline edit with multiple SQL message box 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-23 15:38:18 -03:00
Kamil Tekiela
fccaaf65a3 Remove all new Psalm issues 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-19 16:33:01 +01:00
Maurício Meneghini Fauth
1102858ba8
Redesign the SQL message card 
Fixes color issues for the dark color mode of the Bootstrap theme.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-17 22:31:50 -03:00
Evgeny Skorlov
9590ba6bc1 Replace superglobals with serverrequest in GetFieldController with fixes 
Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>
 2023-05-10 23:03:11 +11:00
Maurício Meneghini Fauth
624126edc8
Redesign the database and table privileges pages 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-08 21:04:44 -03:00
William Desportes
5775005692
Fix LintControllerTest 
Probably due to sql-parser changes

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-05-04 22:32:44 +02:00