gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
127,175 Commits 12 Branches 481 Tags 2.4 GiB
2dd24efbe6
Commit Graph

70 Commits

Author SHA1 Message Date
Kamil Tekiela
f58c647271 Refactor $extraData and show_as_php 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-08-15 10:51:07 +01:00
Maurício Meneghini Fauth
9706a78544
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-07-13 17:53:07 -03:00
Maurício Meneghini Fauth
2cdf86d30c
Add unit test for 0c7848083d 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-07-13 17:35:50 -03:00
Maurício Meneghini Fauth
6cda25211e
Replace jqPlot with Chart.js for the profiling chart 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-06-17 23:44:04 -03:00
Maurício Meneghini Fauth
70ff7dcd6b
Improve return type of Sql::getDetailedProfilingStats() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-06-07 16:01:10 -03:00
Maurício Meneghini Fauth
3f2c53ef1d
Replace PHPUnit annotations with attributes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-06-07 11:44:01 -03:00
Maurício Meneghini Fauth
b8c26e9609
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-06-02 16:43:57 -03:00
Maurício Meneghini Fauth
64eceff4f9
Fix state times not getting summed in the profiling table 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-06-02 16:31:10 -03:00
Maximilian Krög
3228a19c2d
Improve FieldMetadata 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-04-07 21:46:19 +02:00
Maurício Meneghini Fauth
6a2c12bdc8
Add missing traversable type hints 
Replace array type hint with mixed[] type hint, since it means the same.
This way it's possible to require traversable type hint for new code.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-04-02 01:32:12 -03:00
Maurício Meneghini Fauth
dd885dc7b8
Use single-line arrays when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-27 17:39:17 -03:00
Maurício Meneghini Fauth
437215cab2
Rename variables to use camel case format 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-26 21:47:50 -03:00
Kamil Tekiela
276577ca2a
Remove $GLOBALS['PMA_PHP_SELF'] (#18149) 
* Remove $GLOBALS['PMA_PHP_SELF']

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove $GLOBALS['PMA_PHP_SELF'] from tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Moved cleanupPathInfo to Routing

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove parse_url from getRootPath

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove invalid tests

Surely, we never expect PATH to be backslash delimited. The code is not designed to handle this and the tests for this don't make much sense.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix trailing slash in path

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-27 17:56:27 -03:00
Maurício Meneghini Fauth
16a0660a78
Add native property types to test classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-27 01:17:22 -03:00
Maurício Meneghini Fauth
556594b4cd
Fix coding standard spacing issues 
- Fixes one line doc comments
- Fixes parent call spacing
- Fixes constant spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-24 21:06:17 -03:00
Maurício Meneghini Fauth
77957a69a5
Add trailing comma for multi-line functions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-24 20:48:46 -03:00
Kamil Tekiela
902d1a1e77
Add native return type hints (#18126) 
* Add remaining native return type hints to flush out bugs

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast the mixed value to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* getAutoIncrement() is supposed to return string

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast values to string in DummyResult

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Make getCollation() return non-nullable string

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast seqInIndex to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast $cardinality to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* createFile may return false

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove redundant cast

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-23 15:43:36 -03:00
Maurício Meneghini Fauth
4ff3724c3f
Use union with null instead of short nullable type 
Since union type are now possible, using union with null makes more
clear that it is a union type.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 21:48:19 -03:00
Maurício Meneghini Fauth
0ab9e4ac77
Change PHPUnit data providers to use static methods 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-14 12:42:16 -03:00
Maurício Meneghini Fauth
0819043d0e
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-08 14:09:59 -03:00
William Desportes
2443570ce6
Merge #17851 - Fix #17028, #17683 - Re build query count management 
Pull-request: #17851
Fixes: #17028
Fixes: #17683

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-02-08 13:12:00 +01:00
Kamil Tekiela
2bda275524 Add better type inference 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-12-20 18:55:03 +00:00
William Desportes
79d447be16
Merge branch 'QA_5_2' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-10-31 19:32:58 +01:00
William Desportes
e51e3fa71f
Fix typo in test data 
[ci skip]

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-10-31 14:54:53 +01:00
William Desportes
86b93afdfd
Replace '*' in query to count results 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-10-31 14:44:40 +01:00
William Desportes
8a2fbda34a
Ref #17028 - Use statement build instead of replacing tokens 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-10-31 14:37:54 +01:00
William Desportes
455016557e
Ref #17028 - Add test cases for queries 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-10-31 13:38:07 +01:00
Maurício Meneghini Fauth
63d57b1f1c
Push dbi and dummyDbi members down 
The idea is to only load the DBI when needed.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-13 00:15:53 -03:00
Maurício Meneghini Fauth
10b937511d
Replace $analyzedSqlResults array with StatementInfo object 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-24 21:35:30 -03:00
Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-07 17:31:11 -03:00
Maurício Meneghini Fauth
c411121fd8
Move Relation classes into the ConfigStorage namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-17 12:09:13 -03:00
Maurício Meneghini Fauth
0d81b2166a
Add test for Sql::executeQueryAndSendQueryResponse 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-11-15 19:51:16 -03:00
Maurício Meneghini Fauth
67e96cf40c
Get default config values from Config\Settings classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-30 12:04:47 -03:00
Maurício Meneghini Fauth
f3b79d83c0
Add PHPUnit's Covers annotation on test classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-04 23:39:26 -03:00
William Desportes
d20f7f7d0a
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-24 19:01:26 +02:00
William Desportes
64331802cb
Fix #16734 - Use SQL count instead of fetch and count results 
Ref: #15652

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-24 18:29:53 +02:00
Maurício Meneghini Fauth
33d711215d
Remove the PMA_VERSION constant 
Uses the PhpMyAdmin\Version::VERSION constant instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-08 22:22:55 -03:00
Maurício Meneghini Fauth
db3da81056 Remove some useless comments 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-13 19:56:56 -03:00
Maurício Meneghini Fauth
c57dda7315 Use DI for Sql class constructor 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-05 15:31:39 -03:00
Maurício Meneghini Fauth
992af332a0 Extract Sql::parseAndAnalyze method to SqlTest class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-05 13:58:51 -03:00
Maurício Meneghini Fauth
ceac762e09 Remove pmaThemePath and pmaThemeImage PHP globals 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-02 10:57:57 -03:00
Maurício Meneghini Fauth
971a773cc7 Make Sql::isJustBrowsing method static 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-10 23:25:34 -03:00
Maurício Meneghini Fauth
47f0960dce Add return type declaration to test methods 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-07 11:31:33 -03:00
William Desportes
a300a25319
Replace assertEquals({false,true} by assert{false,true} 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-26 13:13:15 +02:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
9269d75fb4 Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 20:22:18 -03:00
Maurício Meneghini Fauth
0b9c35a056 Remove uses statements from the same namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-24 13:00:24 -03:00
William Desportes
7e81b0b3d7
Merge callProtectedMethod and callPrivateFunction into callFunction 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-21 22:59:29 +02:00
William Desportes
ae575ffb14
Fix running tests in --process-isolation 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-21 16:21:20 +02:00
William Desportes
6eaa55e805
Call parent's setUp and tearDown 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-20 21:31:13 +02:00