Commit Graph

43 Commits

Author SHA1 Message Date
Michal Čihař
5491d67fb5 Avoid possible path traversal using MySQL username
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-30 10:05:46 +02:00
Michal Čihař
1363ce5749 Merge branch 'QA_4_6' into QA_4_6-security 2016-06-17 14:27:02 +02:00
Michal Čihař
58da975117 Add missing URL encoding
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-17 13:22:01 +02:00
Michal Čihař
a5950f9ecd Fix link to mariadb explain analyzer
- avoid double urlencoding of the query
- properly escape html entities

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-17 13:05:11 +02:00
Michal Čihař
ef1493d9b4 Move request conversion to generic code
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-17 09:35:57 +02:00
Michal Čihař
05a45fe23f Use https for links to bugs.mysql.com
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-05-17 10:41:13 +02:00
Michal Čihař
11089cbe41 Use https for links to dev.mysql.com
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-05-17 10:16:44 +02:00
Michal Čihař
bbe8efaf7c Use https for documentation links
Fixes #12225

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-05-10 15:04:29 +02:00
Michal Čihař
7e19be3a10 Check if sessions are working and report failures
- Always check for session_start erorrs and report them, this catches
  completely broken session storage or no free inodes for files
- Check whether session can be written, this catches the full disk case

Fixes #12204

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-04-21 12:09:50 +02:00
Michal Čihař
e0724d2660 Fixed check for ndb version
Fixes #12200

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-04-20 10:07:06 +02:00
Michal Čihař
02aa0729dc Make PMA_fatalError work even early
The messaging framework can not make assumptions about available objects
as this doesn't have to be satisfied in early PMA_fatalError case.

Issue #12056

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-03-01 15:36:05 +01:00
Michal Čihař
6d33a475eb Fixed rendering of messages without SQL query
It should get rounded boxes at bottom, but didn't get it.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-17 11:37:02 +01:00
Michal Čihař
a411cd0ca4 The cell_align_left is defined in common.inc.php so it should available in all cases
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-17 11:35:36 +01:00
Madhura Jayaratne
39559ddca5 Merge branch 'QA_4_5' into QA_4_6 2016-02-16 15:27:46 +11:00
Michal Čihař
bfe0e8814e Merge branch 'QA_4_5' into QA_4_6 2016-02-12 10:08:07 +01:00
Durgesh
de28889a30 Fix HTML rendering in error message, Issue #11872
Signed-off-by: Durgesh <007durgesh219@gmail.com>
2016-02-09 16:10:15 +05:30
Michal Čihař
47798a60e4 Show more used PHP extensions
This helps user to see what features are available.

Issue #11874

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-22 09:31:44 +01:00
Michal Čihař
20c74d2124 Consistent parameter type docs (number -> integer)
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 17:13:53 +01:00
Michal Čihař
55b317c699 Remove /*overload*/ prefix from mb_* calls
I believe this was temporary flagging to see which code is migrated and
can be safely removed now.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-04 16:35:28 +01:00
Marc Delisle
537951b043 Unset applied to the variables of a foreach loop as useless
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-12-22 05:08:39 -05:00
Marc Delisle
52f1cabcec Remove dead code
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-12-16 09:39:42 -05:00
Michal Čihař
4e44ba968b Reduce spacing between displayed SQL queries
Signed-off-by: Michal Čihař <michal@cihar.com>
2015-12-15 09:38:54 +01:00
Hugues Peccatte
8baf7c4a8a Update PHPDoc.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-12-11 23:21:54 +01:00
Michal Čihař
b94318c4cd Merge branch 'QA_4_5' 2015-12-07 15:37:08 +01:00
Hugues Peccatte
f9d582bd09 Make PHPCS happy.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-11-08 15:58:48 +01:00
Madhura Jayaratne
4a0b34b438 Merge branch 'QA_4_5' 2015-11-04 19:45:20 +11:00
Madhura Jayaratne
7c43e1f631 Fix #11603 Namespace clash for class Error
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-10-26 19:49:51 +11:00
Hugues Peccatte
e1dd0a9f97 Make PHPCS happy.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-10-18 22:51:01 +02:00
Hugues Peccatte
09f87f4770 Make PHPCS happy.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-10-07 22:09:55 +02:00
Hugues Peccatte
6f4676cdfc Merge remote-tracking branch 'origin/master' into useNamespaces_master 2015-10-04 18:04:49 +02:00
Hugues Peccatte
c752c01309 Merge branch 'master' into useNamespaces_master 2015-09-27 20:50:19 +02:00
Hugues Peccatte
71b62bcef9 Merge remote-tracking branch 'origin/master' into useNamespaces_master 2015-09-26 13:50:49 +02:00
Hugues Peccatte
b92491d799 Merge branch 'master' into useNamespaces_master 2015-09-12 00:53:39 +02:00
Hugues Peccatte
f08bc1a79c Merge branch 'master' into useNamespaces_master 2015-09-10 21:27:59 +02:00
Hugues Peccatte
42c0ebac85 Merge branch 'master' into useNamespaces_master 2015-09-09 22:05:00 +02:00
Hugues Peccatte
ececab6c8c Attempts to fix unit test.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-06 11:59:37 +02:00
Hugues Peccatte
178a6edd38 Add namespace on part of plugins classes.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-05 00:33:42 +02:00
Hugues Peccatte
b1038cfefa Merge branch 'master' into useNamespaces_master 2015-09-04 22:37:45 +02:00
Hugues Peccatte
e5e447e937 Set namespace on config classes.
Update config classes.
Add @noinspection tag.
Update documentation and script.
Set ConfigGenerator in a namespace.
Rename ConfigGenerator filename.
Remove ConfigGenerator requires.
Fix namespaces of mock objects.
Remove useless require.
Add missing 'use'.
Add missing require.
Update PHPDoc.
Fix class test typo.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:30:23 +02:00
Hugues Peccatte
7f8f34e89d Remove classes require_once.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:30:22 +02:00
Hugues Peccatte
58b10807c8 Rename classes files.
Rename classes.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:30:22 +02:00
Hugues Peccatte
0761fb1801 Rename classes files.
Rename classes.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:30:21 +02:00
Hugues Peccatte
f0ba28fc1d Set namespace on Advisor, Config, Console and Util classes.
Set namespace on DbQbe.
Set namespace to 'DbSearch'.
Split Advisor.class.php file.
Change Advisor namespace.
Rename DbQbe class and file.
Set namespace on DisplayResults.
Set namespace on Error.
Use namespace for ErrorHandler.
Add class autoloader.
Change ErrorHandler filename.
Remove some require.
Update Config namespace path.
Update PMA_Util to PMA\libraries\Util.
Rename Font and File classes files.
Use namespace for Footer.
Set namespace in all libraries classes.
Namespace OutputBuffering.
Export SubPartition.
Rename Partition file.
Namespace PDF.
Namespace RecentFavoriteTable.
Replace PMA_Response by Response and PMA_Message by Message.
Update uses and calls.
Fix unit tests.
Fix SqlParser autoload.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:22:52 +02:00