Maurício Meneghini Fauth
6a2c12bdc8
Add missing traversable type hints
...
Replace array type hint with mixed[] type hint, since it means the same.
This way it's possible to require traversable type hint for new code.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-04-02 01:32:12 -03:00
Maurício Meneghini Fauth
dd885dc7b8
Use single-line arrays when possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-27 17:39:17 -03:00
Maurício Meneghini Fauth
437215cab2
Rename variables to use camel case format
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-26 21:47:50 -03:00
Maurício Meneghini Fauth
556594b4cd
Fix coding standard spacing issues
...
- Fixes one line doc comments
- Fixes parent call spacing
- Fixes constant spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-24 21:06:17 -03:00
Maurício Meneghini Fauth
77957a69a5
Add trailing comma for multi-line functions
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-24 20:48:46 -03:00
Maurício Meneghini Fauth
785f8c1c00
Use constructor property promotion where possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-20 19:39:02 -03:00
Kamil Tekiela
8a1d6f1eaa
Convert var annotations to typed properties
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-12 21:31:04 +00:00
Kamil Tekiela
d1bda5c5dc
Refactor config forms
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-01-23 23:32:27 +00:00
Maurício Meneghini Fauth
b2eb6bf4c9
Extract config load and check from Config's constructor
...
This allows better handling of the user's config loading and validation.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-15 13:20:13 -03:00
Maurício Meneghini Fauth
66e2650e06
Replace Core::fatalError() calls in controllers
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-31 20:25:55 -03:00
Maurício Meneghini Fauth
ade173f948
Inline the Core::noCacheHeader() method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-23 20:43:57 -03:00
Maurício Meneghini Fauth
f0897a39f1
Extract header() calls from Core::headerJSON() method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-23 20:05:20 -03:00
Maurício Meneghini Fauth
8da8d3f8c8
Add types for Config\FormDisplay::save() parameters
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-12 19:19:36 -03:00
Maurício Meneghini Fauth
4cd6b23007
Add Http\ServerRequest::getQueryParam method
...
Similar to the Http\ServerRequest::getParsedBodyParam method, this
method retrives a single parameter from the request query, or the
default value if not available.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-10 23:00:33 -03:00
Maurício Meneghini Fauth
85f9d94f1b
Add basic routing system for setup pages
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-10 06:54:45 -03:00
Maurício Meneghini Fauth
6e3fa576c6
Use ServerRequest object for setup controller
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-09 17:05:13 -03:00
Maurício Meneghini Fauth
e05c51576c
Extract setup entry points into controllers
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-09 16:22:51 -03:00
Maurício Meneghini Fauth
9b3a1f7734
Merge branch 'QA_5_1-security' into master-security
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-13 17:41:16 -03:00
Maurício Meneghini Fauth
44eb12f15a
Improve query params filtering in Setup pages
...
Note: 'action_done' was not used since
c962ee4287 .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-13 15:05:43 -03:00
Kamil Tekiela
488e7cb5bf
Use array_keys whenever only keys are needed in foreach
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2021-11-29 20:37:39 +00:00
Maurício Meneghini Fauth
3531775b7c
Add type declarations to the controllers contructors
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-11 17:32:22 -03:00
Maurício Meneghini Fauth
8f2f3eff40
Remove the Core::isValid method
...
This improves the type checking and simplifies the code.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-02 13:20:50 -03:00
Maurício Meneghini Fauth
5725516656
Inline Core::ifSetOr method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-01 13:29:05 -03:00
Maurício Meneghini Fauth
a2ed4dfe68
Make controllers callable
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-30 13:16:29 -03:00
Maurício Meneghini Fauth
e8c28d1883
Remove some globals from Config::enableBc method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-08 19:49:26 -03:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors
...
Related to 62f142c9fa .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-03 16:50:33 -03:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 14:18:35 -03:00
Maurício Meneghini Fauth
d042998f6a
Remove FormDisplayTemplate dep from Setup\ConfigController
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-04 14:04:32 -03:00
Maurício Meneghini Fauth
1911ac6289
Remove Config\FormDisplay dep from Setup\HomeController
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-03 22:38:27 -03:00
Maurício Meneghini Fauth
65dd7e8278
Wrap settings tabs with Bootstrap's cards
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-02 18:51:11 -03:00
Maurício Meneghini Fauth
9a2989f3ac
Add Bootstrap for Setup pages
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-31 17:52:16 -03:00
William Desportes
b826234ebb
Fix #16526 - Fatal error: Uncaught TypeError: preg_replace(): Argument #3 ($subject)
...
Fatal error: Uncaught TypeError: preg_replace(): Argument #3 ($subject) must be of type array|string, null given in libraries/classes/Controllers/Setup/HomeController.php:30
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-12-11 21:05:06 +01:00
Maurício Meneghini Fauth
db3da81056
Remove some useless comments
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-13 19:56:56 -03:00
Maurício Meneghini Fauth
e5514a6b66
Fix some PHPStan errors
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-10 21:24:35 -03:00
Maurício Meneghini Fauth
f4582e083e
Use early exit when possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
3baad2eb1c
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
206199105e
Remove useless return type annotations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
676f48349a
Reference global funcs and consts via use statement
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4
Remove unnecessary annotations
...
@package, @subpackage and others.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf
Use one line for comments with a single line
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
39f42f848b
Remove some useless docblock comments
...
Fixes docblock spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
dd06cd38f8
Defines rules for double quote usage
...
Makes sure that any use of double quotes strings are warranted.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
Maurício Meneghini Fauth
e222cb8beb
Merge branch 'QA_5_0'
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-21 13:02:14 -03:00
Maurício Meneghini Fauth
08696bc55e
Merge branch 'QA_4_9' into QA_5_0
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-21 12:51:04 -03:00
Maurício Meneghini Fauth
1a14b3e4d3
Remove vim modelines
...
These settings are no longer required as they are guaranteed through
other coding standard tools.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
William Desportes
a2268169ae
Use strict compare for count function
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 17:44:49 +02:00
Maurício Meneghini Fauth
e1f9ae00cd
Add a trailing comma in multi-line arrays
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-14 14:09:26 -03:00
Maurício Meneghini Fauth
0feae32056
Rename Sanitize::sanitize to Sanitize::sanitizeMessage
...
...to avoid the PHP 4 constructor format
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 15:21:48 -03:00
Maurício Meneghini Fauth
c8f84fc748
Replace is_null with identical comparison with null
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 13:28:22 -03:00