gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
126,739 Commits 12 Branches 481 Tags 2.4 GiB
2fc35516ff
Commit Graph

750 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
74b1ffbf8c
Merge the DB and table trigger controllers 
They are equivalent in current form.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-05-25 15:39:36 -03:00
Maurício Meneghini Fauth
62ec1bcc2c
Merge pull request #18445 from kamil-tekiela/InsertEdit-pt4 
InsertEdit refactoring - part 4
 2023-05-24 21:16:01 -03:00
Maurício Meneghini Fauth
44f2b4d5bd
Merge pull request #18390 from ru-asdx/refactor-17769-p2 
Replace superglobals with serverrequest in GetFieldController
 2023-05-24 15:31:24 -03:00
Kamil Tekiela
7838a42a34 Move buildInsertSqlQuery to Generator 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-23 15:31:46 +01:00
Kamil Tekiela
1d180c5482 Use null as sentinel value in getColumn 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-19 16:33:01 +01:00
Kamil Tekiela
fccaaf65a3 Remove all new Psalm issues 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-19 16:33:01 +01:00
Kamil Tekiela
3b611f3945 Implement ColumnFull DTO 
This is MVP. In following commits the DTO will be expanded and improved.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-19 16:29:34 +01:00
Kamil Tekiela
97da6c9721 Don't catch exception into variable 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-12 23:09:51 +01:00
Kamil Tekiela
4ec3b99ba3
Improve boolean conditions with arrays (#18417) 
* Remove empty() on array

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove boolean count()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-12 15:16:26 -03:00
Maurício Meneghini Fauth
58c3e059c2
Merge pull request #18407 from kamil-tekiela/Useless-foreach 
Remove useless foreach
 2023-05-12 12:16:47 -03:00
Kamil Tekiela
dc471985b9
Short boolean conditions (#18413) 
* Short boolean conditions

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify conditions

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-12 11:09:21 -03:00
Kamil Tekiela
4a4f8ae063 Remove useless foreach 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-05-11 23:02:29 +01:00
Evgeny Skorlov
9590ba6bc1 Replace superglobals with serverrequest in GetFieldController with fixes 
Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>
 2023-05-10 23:03:11 +11:00
Kamil Tekiela
a01eefc4c2 Remove $timestampSeen which was always false 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-23 11:20:05 +01:00
Kamil Tekiela
36481a0dca Change if into its short form 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-23 11:20:05 +01:00
Kamil Tekiela
ae5b5a1a86 Remove $jsvkey and $vkey 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-23 11:20:05 +01:00
Kamil Tekiela
fbb185e7a9 Remove globals 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-23 11:20:05 +01:00
Kamil Tekiela
9124c19539 Remove $GLOBALS['columns_cnt'] 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-23 11:20:05 +01:00
Kamil Tekiela
bfe1f4facf Remove redundant argument 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-23 11:20:05 +01:00
Kamil Tekiela
b2357568a1 Use str_ends_with and str_starts_with 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-23 11:20:05 +01:00
Kamil Tekiela
269535a7a5 Change $tabindex into a private property 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-23 11:20:05 +01:00
Kamil Tekiela
a8070b5498 $tabindexForValue was always 0 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-23 11:20:05 +01:00
Kamil Tekiela
62459b33e5 Change RW param into a private property 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-23 11:20:05 +01:00
Kamil Tekiela
747941ece1 Move $returnToSqlQuery out of the method 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-23 11:20:04 +01:00
Kamil Tekiela
5cd6c16684 Instead of returning array, use array cast 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-20 16:53:19 +01:00
Kamil Tekiela
25b24966c1 Move getParamsForUpdateOrInsert into controller 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-20 16:53:19 +01:00
Kamil Tekiela
a852acb3e9 Move $isInsertignore out of getParamsForUpdateOrInsert 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-20 16:53:19 +01:00
Kamil Tekiela
8367af19be Remove unused $biggestMaxFileSize param 
Not sure if it should have been a global, but judging by the rest of the code, I believe it's no longer needed.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-20 16:53:19 +01:00
Kamil Tekiela
9800c3574f Move urlParamsInEditMode to ChangeController 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-20 16:53:18 +01:00
Evgeny Skorlov
4530585ad3
Replace superglobals with serverrequest in controllers 
Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-04-12 15:49:31 -03:00
Maurício Meneghini Fauth
514ed287c6
Merge pull request #18328 from MoonE/fieldmetadata 
Refactor DbiDummy and improve FieldMetadata
 2023-04-12 14:13:20 -03:00
Maurício Meneghini Fauth
4c15ace946
Merge pull request #18327 from kamil-tekiela/More-Tracking-refactoring 
More tracking refactoring
 2023-04-12 11:10:00 -03:00
Maurício Meneghini Fauth
7f1cddaf33
Merge pull request #18335 from kamil-tekiela/18332 
Fix boolean condition
 2023-04-09 18:59:30 -03:00
Kamil Tekiela
5d0de52112 Fix boolean condition 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-08 22:58:50 +01:00
Kamil Tekiela
bca265b82b Cast POST values to expected types 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-08 22:27:24 +01:00
Maximilian Krög
abf49ce9d4
Bettery types for DbiDummy / DummyResult 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-04-07 21:47:07 +02:00
Maximilian Krög
3228a19c2d
Improve FieldMetadata 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-04-07 21:46:19 +02:00
Kamil Tekiela
0be1d58b62 Move the code around 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-07 13:46:26 +01:00
Kamil Tekiela
ed586ac9cb Remove report_export param 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-07 13:46:26 +01:00
Kamil Tekiela
a89cedbed9 Fix bug introduced cca381a 
cca381a415

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-07 13:46:26 +01:00
Kamil Tekiela
8e88585f69 Merge if statements 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-07 13:46:26 +01:00
Kamil Tekiela
74a0c26129 Create DTO for TrackedData 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-07 13:46:26 +01:00
Kamil Tekiela
ce35872738 Reload data instead of modifying in place 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-06 00:01:11 +01:00
Kamil Tekiela
57f4fa7583 Remove $GLOBALS['msg'] 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-06 00:01:11 +01:00
Kamil Tekiela
62bd41870f Remove $GLOBALS['entries'] 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-06 00:00:49 +01:00
Kamil Tekiela
4f0a618187 Remove useless assignment 
Psalm incorrectly complains.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

sa
 2023-04-06 00:00:49 +01:00
Kamil Tekiela
15885ea495 Remove $GLOBALS['filter_users'] 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-05 17:34:46 +01:00
Kamil Tekiela
711cb95264 Remove $_POST 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-05 17:25:05 +01:00
Kamil Tekiela
bca99f1e4d Remove deleteTrackingReportRows() 
It's a hyperlink so it can't be both.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-05 17:05:50 +01:00
Kamil Tekiela
218d59c661 Move getTrackedData to Tracking 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-04-04 23:13:18 +01:00