Commit Graph

256 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
74b1ffbf8c
Merge the DB and table trigger controllers
They are equivalent in current form.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-25 15:39:36 -03:00
Maurício Meneghini Fauth
44f2b4d5bd
Merge pull request #18390 from ru-asdx/refactor-17769-p2
Replace superglobals with serverrequest in GetFieldController
2023-05-24 15:31:24 -03:00
Maurício Meneghini Fauth
9e56194fc0
Fix issue with inline edit with multiple SQL message box
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-23 15:38:18 -03:00
Kamil Tekiela
fccaaf65a3 Remove all new Psalm issues
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-05-19 16:33:01 +01:00
Maurício Meneghini Fauth
1102858ba8
Redesign the SQL message card
Fixes color issues for the dark color mode of the Bootstrap theme.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-17 22:31:50 -03:00
Evgeny Skorlov
9590ba6bc1 Replace superglobals with serverrequest in GetFieldController with fixes
Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>
2023-05-10 23:03:11 +11:00
Maurício Meneghini Fauth
624126edc8
Redesign the database and table privileges pages
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-08 21:04:44 -03:00
Maurício Meneghini Fauth
250a32b795 Add the Config::getCurrentServer() method
The Config::getCurrentServer() method returns the current server
configuration. It's an VO that is equivalent to
$GLOBALS['cfg']['Server'] setting.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-04-30 17:37:34 -03:00
Maurício Meneghini Fauth
aa119f7e62 Remove unused Config::$defaultServer property
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-04-30 13:23:27 -03:00
Kamil Tekiela
25b24966c1 Move getParamsForUpdateOrInsert into controller
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-20 16:53:19 +01:00
Kamil Tekiela
9800c3574f Move urlParamsInEditMode to ChangeController
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-20 16:53:18 +01:00
Evgeny Skorlov
4530585ad3
Replace superglobals with serverrequest in controllers
Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-04-12 15:49:31 -03:00
Maximilian Krög
3228a19c2d
Improve FieldMetadata
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-04-07 21:46:19 +02:00
Kamil Tekiela
357680474e Memoize Relation
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-04 11:59:29 +01:00
Maurício Meneghini Fauth
dd885dc7b8
Use single-line arrays when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-27 17:39:17 -03:00
Maurício Meneghini Fauth
437215cab2
Rename variables to use camel case format
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-26 21:47:50 -03:00
Kamil Tekiela
8eb023bcce Remove last public use of Tracker::isTracked
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-17 22:36:25 +00:00
Kamil Tekiela
938dd6f7f8 Remove getSqlResultForSelectableTables
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-17 22:36:25 +00:00
Kamil Tekiela
924fcc79f9 Refactor logic for getting Tracking status
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-17 22:36:21 +00:00
Kamil Tekiela
c0b367cc57 Create Tracking namespace
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-17 22:35:32 +00:00
Kamil Tekiela
8a5ce0b557 Split long lines
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-17 12:48:12 +00:00
Kamil Tekiela
3ecf14df34 Fixing erroneous params
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-17 12:47:43 +00:00
Maximilian Krög
e8e877b662
Small change to urlParams and errorUrl globals initialization
Default to emtpy array for urlParams, remove null initialazation for
errorUrl.

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-03-13 21:53:19 +01:00
Maximilian Krög
3891f2bca2
Add and use getters for GisVisualization properties
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-03-13 21:53:19 +01:00
Maximilian Krög
07388c10a7
Remove default width / height
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-03-13 21:53:17 +01:00
Maximilian Krög
6b9f0d8441
Add pos and rows properties
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-03-13 21:52:49 +01:00
Maximilian Krög
fa7ec73dd2
Make sure a spatial column is available
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-03-05 15:29:19 +01:00
Maximilian Krög
5d10439bd4 Refactor OpenLayer visualization code generation
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-03-04 15:50:50 -03:00
Maximilian Krög
5dac31a8c0 Use OpenLayers source.getExtent() instead of calculating from features
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-03-04 15:50:50 -03:00
Kamil Tekiela
142f15f373
Use quoteString in controllers (#18191)
* CreateController

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* FindReplaceController

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* SetVariableController

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* GetVariableController

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* UserGroupsFormController

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* TablesController

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-03 17:40:45 -03:00
Kamil Tekiela
276577ca2a
Remove $GLOBALS['PMA_PHP_SELF'] (#18149)
* Remove $GLOBALS['PMA_PHP_SELF']

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove $GLOBALS['PMA_PHP_SELF'] from tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Moved cleanupPathInfo to Routing

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove parse_url from getRootPath

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove invalid tests

Surely, we never expect PATH to be backslash delimited. The code is not designed to handle this and the tests for this don't make much sense.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix trailing slash in path

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-27 17:56:27 -03:00
Maurício Meneghini Fauth
f9c8035768
Add native parameter types to test classes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-27 01:54:03 -03:00
Maurício Meneghini Fauth
16a0660a78
Add native property types to test classes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-27 01:17:22 -03:00
Maurício Meneghini Fauth
556594b4cd
Fix coding standard spacing issues
- Fixes one line doc comments
- Fixes parent call spacing
- Fixes constant spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-24 21:06:17 -03:00
Maurício Meneghini Fauth
77957a69a5
Add trailing comma for multi-line functions
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-24 20:48:46 -03:00
Maurício Meneghini Fauth
cb67fa306d
Remove Reflection's setAccessible() method
This method is no-op since PHP 8.1.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-21 20:35:45 -03:00
Maurício Meneghini Fauth
4ff3724c3f
Use union with null instead of short nullable type
Since union type are now possible, using union with null makes more
clear that it is a union type.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-20 21:48:19 -03:00
Maurício Meneghini Fauth
0ab9e4ac77
Change PHPUnit data providers to use static methods
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-14 12:42:16 -03:00
Kamil Tekiela
78de670d61 Fix incomplete test after previous PR
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-01-28 14:01:26 +00:00
Maurício Meneghini Fauth
fdf474abf9
Merge pull request #17981 from kamil-tekiela/getTables-investigation
Improve some type inference in various places

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-24 13:44:45 -03:00
Kamil Tekiela
2bda275524 Add better type inference
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-20 18:55:03 +00:00
Kamil Tekiela
6735938f12 Remove dependancy in Table/StructureController
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-12-16 20:58:48 +00:00
Maurício Meneghini Fauth
13890a947a
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-16 11:53:18 -03:00
MoonE
4e529ae399
Refactor gis color (#17895)
* Use int srid in gis tests

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>

* Typecheck gis color

Only use array<int> as color

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2022-11-30 14:49:06 -03:00
Maurício Meneghini Fauth
95c9fa430c
Merge pull request #17889 from kamil-tekiela/Index-controllers
Refactor Index controllers
2022-11-30 13:58:56 -03:00
William Desportes
420485a41b
Fix tests after e28bc2d8f6
Ref: e28bc2d8f6

Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-20 18:29:07 +01:00
Maurício Meneghini Fauth
ca489f3b41
Improve type of DatabaseInterface::getLowerCaseNames()
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-19 15:50:14 -03:00
Maurício Meneghini Fauth
b2eb6bf4c9
Extract config load and check from Config's constructor
This allows better handling of the user's config loading and validation.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-15 13:20:13 -03:00
Maurício Meneghini Fauth
d0d90551c3 Remove the dblist global variable
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-13 21:08:00 -03:00
Kamil Tekiela
ff2e7f6334 Move methods to Indexes.php
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-11-11 22:24:27 +00:00