Commit Graph

18700 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
32e83d9097 Refactor ServerDatabasesController
Refactors PhpMyAdmin\Controllers\Server\ServerDatabasesController.

- Renames variables and methods to camelCase format.
- Moves request and response handling back to server_databases.php.
- Groups all HTML into templates/server/databases/index.twig.
- Improves unit tests.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-26 16:29:33 -02:00
Maurício Meneghini Fauth
7eb2bbc102 Remove libraries/check_user_privileges.inc.php
Replaces with CheckUserPrivileges::getPrivileges

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-22 18:18:21 -02:00
Jakub Vrana
c5ae592370 Actually set MYSQLI_OPT_LOCAL_INFILE
1e6b740e tried to set this but failed due to https://bugs.php.net/77496
and nobody probably ever tested it.

Tested: Executed `LOAD DATA LOCAL INFILE 'README' INTO TABLE text(text)`
SQL command successfully before, unsuceesfully after.

Signed-off-by: Jakub Vrana <jakub@vrana.cz>
2019-01-21 18:53:33 +01:00
Maurício Meneghini Fauth
1303def5df
Merge pull request #14864 from Tithugues/feature/remove-useless-parentheses
Remove useless parentheses
2019-01-21 14:06:42 -03:00
Hugues Peccatte
4321120b80 Fix PHPCS issue
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-21 12:27:26 +01:00
Maurício Meneghini Fauth
5702fdbad8 Extract HTML from Display\Results::_getDataForResettingColumnOrder
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-20 02:43:31 -02:00
Hugues Peccatte
f06883d2a7 Remove useless parenthesis
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-20 01:23:53 +01:00
Maurício Meneghini Fauth
8d031dc3d4 Extract HTML from Display\Results::_getSortByKeyDropDown
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-19 17:05:25 -02:00
Maurício Meneghini Fauth
e3fc8929d1 Extract HTML from Display\Results::_getTableHeaders
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-18 18:22:19 -02:00
Maurício Meneghini Fauth
0e9f587827 Fix 2FA configuration alignment
Changes string to "No Two-Factor Authentication":

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-16 04:35:28 -02:00
Maurício Meneghini Fauth
f9c168dbc1
Merge pull request #14850 from Tithugues/feature/group-str-replace
Group str_replace for performances
2019-01-16 02:55:53 -03:00
Maurício Meneghini Fauth
9385ccd404
Merge pull request #14859 from Tithugues/fix/fix-wrong-locale-code
Fix wrong locale code
2019-01-16 02:49:10 -03:00
Maurício Meneghini Fauth
a9f9e6db0c
Merge pull request #14861 from Tithugues/feature/use-elvis-operator
Use Elvis operator
2019-01-16 02:47:24 -03:00
Maurício Meneghini Fauth
9ab8066296
Merge pull request #14862 from Tithugues/feature/rewrite-concat-and-operations
Rewrite some concatenations or operations done in a long way
2019-01-16 02:25:43 -03:00
Maurício Meneghini Fauth
74d285e5e5
Merge pull request #14866 from Tithugues/fix/fix-wrong-case-in-function-names
Fix wrong case in function names
2019-01-16 02:24:33 -03:00
Maurício Meneghini Fauth
d4909c5198
Merge pull request #14857 from Tithugues/feature/remove-useless-proxies
Remove useless proxies
2019-01-16 02:20:08 -03:00
Maurício Meneghini Fauth
76fbe019da
Merge pull request #14856 from Tithugues/fix/escape-also-delimiter
Escape also delimiter
2019-01-16 02:19:24 -03:00
Maurício Meneghini Fauth
a1d3d334b4
Merge pull request #14855 from Tithugues/feature/reduce-nested-ifs
Reduce nested ifs
2019-01-16 02:16:38 -03:00
Maurício Meneghini Fauth
fedad552cc
Merge pull request #14849 from Tithugues/feature/replace-regexp-when-simple
Replace regular expressions when simple
2019-01-16 02:14:51 -03:00
Maurício Meneghini Fauth
071a3ff137
Merge pull request #14863 from Tithugues/fix/remove-useless-semicolon
Remove useless semicolon
2019-01-16 02:08:53 -03:00
Maurício Meneghini Fauth
f8f8d2ae05 Extract HTML from Display\Results::_getTableNavigation
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-15 23:12:12 -02:00
Maurício Meneghini Fauth
728f61ec5d Extract HTML from PhpMyAdmin\Sql
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-15 03:50:38 -02:00
Maurício Meneghini Fauth
f3ccef50c6
Merge pull request #14860 from Tithugues/feature/use-real-names-not-aliases
Use real function names, not their aliases
2019-01-14 22:55:37 -03:00
Maurício Meneghini Fauth
036a1877ae
Merge pull request #14848 from Tithugues/feature/update-phpdoc
Update PHPDoc
2019-01-14 22:52:54 -03:00
Maurício Meneghini Fauth
ca66136d99 Extract HTML from Sql::getHtmlForProfilingChart
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-14 02:33:33 -02:00
Maurício Meneghini Fauth
adef7b6f1c Extract HTML from Sql::getHtmlForBookmark
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-13 17:41:11 -02:00
Maurício Meneghini Fauth
2c5e6b17f6 Update PHPDoc returns
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-13 16:36:32 -02:00
Maurício Meneghini Fauth
8168dcf8ea Extract HTML from Sql::getHtmlForSqlQueryResults
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-13 12:39:50 -02:00
Maurício Meneghini Fauth
9a971add2e
Merge pull request #14858 from Tithugues/feature/these-configurations-doesnt-exist-anymore
These configurations don't exist anymore in PHP 7.1
2019-01-13 10:30:51 -03:00
Hugues Peccatte
a87900c2cf Update or add missing @throws
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-13 09:52:46 +01:00
Hugues Peccatte
9406e922cc Update PHPDoc
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-13 09:52:46 +01:00
Hugues Peccatte
46077c33f8 Remove useless casts
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-13 01:04:59 +01:00
Hugues Peccatte
b5607dc0c9 Fix wrong case in function names
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-13 00:23:36 +01:00
Hugues Peccatte
8b246760e6 Remove useless semicolon
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-13 00:21:51 +01:00
Hugues Peccatte
7ef90149c3 Rewrite some concatenations or operations done in a long way
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-13 00:18:47 +01:00
Hugues Peccatte
446fd2298e Use Elvis operator
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 23:58:02 +01:00
Hugues Peccatte
79e71d3e65 And this one is removed in PHP 7.1
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 23:43:06 +01:00
Hugues Peccatte
8e2a982ce7 These configurations doesn't exist anymore since PHP 5.4.0
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 23:40:02 +01:00
Hugues Peccatte
7f304c1154 Remove useless proxies
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 23:39:19 +01:00
Hugues Peccatte
280926e3f3 Escape also delimiter
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 23:38:39 +01:00
Hugues Peccatte
a8d801f176 Use real function names, not their aliases
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 23:37:52 +01:00
Hugues Peccatte
e5223b3455 Fix wrong locale code
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 23:36:14 +01:00
Hugues Peccatte
f1e140be05 Reduce nested ifs
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 23:06:04 +01:00
Maurício Meneghini Fauth
5acaa56819
Merge pull request #14854 from Tithugues/fix/fix-wrong-case-in-function-names
Fix wrong case in function names
2019-01-12 13:25:39 -03:00
Maurício Meneghini Fauth
9ed3d6eebf
Merge pull request #14851 from Tithugues/feature/replace-array-push-for-performances
Replace array_push for performances
2019-01-12 13:24:26 -03:00
Maurício Meneghini Fauth
8c8d570fd8
Merge pull request #14846 from Tithugues/feature/replace-if-return-by-return
Replace if+return by return
2019-01-12 13:19:56 -03:00
Maurício Meneghini Fauth
65d2693d85
Merge pull request #14845 from Tithugues/feature/replace-or-improve-for
Replace or improve use of 'for'
2019-01-12 13:18:05 -03:00
Hugues Peccatte
6358cd49dc Fix wrong case in function names
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 13:36:27 +01:00
Hugues Peccatte
d0797fff4d Group str_replace for performances
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 10:47:48 +01:00
Hugues Peccatte
7685733389 Replace or improve use of 'for'
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 09:43:25 +01:00