Commit Graph

43 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
William Desportes
1af61f88b3
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-23 12:34:24 +02:00
William Desportes
027f39057a
Merge branch 'QA_4_9' into QA_5_0
- Fixed css img urls for designer

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-23 12:22:37 +02:00
William Desportes
6d0f3083ca
Fix display field can return a boolean
[ci skip]

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-23 12:15:21 +02:00
William Desportes
a23f2ba51a
Fix some bugs with strange table and database names
- Fix export
- Fix split on . to have db and table
- Replace some $_REQUEST occurences
- Add translations to "add tables from another database" : "None" > strNone
- Refactor the ugly code that used globals to use an object "DesignerTable"
- Fix save a new added table
- Fix delete page items
- Fix more bugs

Fixes: #15446
Fixes: #13370
Fixes: #14945
Closes: #15438

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-23 00:55:41 +02:00
Hugues Peccatte
04616ff7fe Import instead of using FQN
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-07-05 23:21:14 +02:00
William Desportes
6cc352ac12
phpstan level 3 fixes
21 errors left

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 14:37:38 +02:00
Maurício Meneghini Fauth
7be0f6bfae Reference class names in use statements
Sort use statements

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 00:14:26 -03:00
Hugues Peccatte
9abd308837 Inject dependencies (#15271)
Inject dependencies instead of building them.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-06-01 15:13:41 -03:00
William Desportes
e453ad1320
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-27 19:15:57 +02:00
William Desportes
5566aa6976
Fix #15228 - Notice - Undefined index: foreign_keys_data
Fixes: #15228
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-26 23:45:20 +02:00
William Desportes
292d2db727
Merge branch 'QA_4_8' 2019-04-01 20:46:54 +02:00
William Desportes
b6b9926a08
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-01 16:27:24 +02:00
William Desportes
a80785198d
Fix #15141 - php notice Undefined index: designer_settings
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-01 16:12:24 +02:00
Maurício Meneghini Fauth
e49d46b277 Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-28 14:51:43 -02:00
Hugues Peccatte
9406e922cc Update PHPDoc
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-13 09:52:46 +01:00
Maurício Meneghini Fauth
23c3579804 Format array declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
4cee0cbc12 Adds space after not (!) and type cast
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:56:34 -02:00
Maurício Meneghini Fauth
3a7e1503ac Fix some coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-04 19:42:10 -02:00
Madhura Jayaratne
d676d6941f Issue phpmyadmin-security/267 SQL injection in Designer feature
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2018-12-26 22:48:47 +11:00
Maurício Meneghini Fauth
9eba565bf4 Remove unnecessary HTML closing tags
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-19 00:12:54 -02:00
William Desportes
69fb1d0237
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-30 23:50:56 +01:00
William Desportes
cc2b1c8b99
Fix #14352 - JavaScript errors with Designer
Closes: #14352

Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-30 11:29:31 +01:00
William Desportes
18c23df20f
Issue #13032 - fix designer on QA_4_8
Used cherry-pick : Merge pull request #14376 from williamdes/issue-13032-designer

Cherry-picked-from: cb2dae58be

Issue #13032 - fix designer

Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-29 20:19:02 +01:00
Tomas Votruba
637fe6de06 [cs] remove unused brackets, clean unused property assign
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
2018-11-26 17:54:40 +01:00
Tomas Votruba
bf720bad29 remove unused and fix @param, @var and @return annotation values
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
2018-11-24 21:47:26 +01:00
Maurício Meneghini Fauth
589ffd2bba Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-10-31 17:38:29 -03:00
William Desportes
56d59a9d67
Fixes #14223 - designer error
See: https://github.com/phpmyadmin/phpmyadmin/issues/14223#issuecomment-429312975
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-10-12 15:01:30 +02:00
Maurício Meneghini Fauth
d4b4124a5e Remove $GLOBALS['dbi'] from Relation class
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-08-30 19:05:09 -03:00
William Desportes
3dce65d913 phpstan level 1 (#14472)
* level +1
* Install sami/sami globaly to avoid dependency clash

Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-08-18 14:37:41 -03:00
Gemorroj
f020ffe03a fix designer
Signed-off-by: Gemorroj <wapinet@mail.ru>
2018-07-21 15:17:37 +03:00
Maurício Meneghini Fauth
2d58411bee Some coding style fixes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 21:30:06 -03:00
William Desportes
29eaf86fcc
Fix relations
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-06-15 21:37:45 +02:00
William Desportes
057c6faca2
Fix errors when database has no tables
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-06-15 21:37:43 +02:00
William Desportes
04fe7d0da9
Use php:rawurlencode/twig:url_encode in designer
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-06-15 21:37:42 +02:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
66f2e4a2dc Remove $dbi global from Database classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-22 22:46:41 -03:00
Maurício Meneghini Fauth
764f7a7dde Enable strict mode in Database classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-15 01:18:52 -03:00
Maurício Meneghini Fauth
d98658187a Replace PhpMyAdmin\Relation static calls
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-25 19:32:13 -03:00
Maurício Meneghini Fauth
c7f3d6e4e6 Rename $GLOBALS['PMD'] to $GLOBALS['designer']
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-24 17:45:48 -03:00
Maurício Meneghini Fauth
f21bc9668d Replace static methods with instance methods
Replace PhpMyAdmin\Database\Designer\Common static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-24 16:39:53 -03:00
Maurício Meneghini Fauth
7f62eef8a7 Rename PmdCommon to Database\Designer\Common
Rename PhpMyAdmin\PmdCommon to PhpMyAdmin\Database\Designer\Common.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-24 16:14:44 -03:00