Commit Graph

49 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
dd95a34b3a Add route parameter to index.php links
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-26 17:37:53 -03:00
Maurício Meneghini Fauth
ea3599194e Use the router for table operations page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-14 13:57:33 -03:00
Maurício Meneghini Fauth
208b0e25e1 Use the router for the sql pages
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-03 21:25:27 -03:00
Maurício Meneghini Fauth
469fd5c05c Use the router for the database operations page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-24 02:12:15 -03:00
Maurício Meneghini Fauth
4fe624fa93 Remove Charsets::getCollationDropdownBox method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-25 03:32:01 -03:00
Maurício Meneghini Fauth
e1f9ae00cd Add a trailing comma in multi-line arrays
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-14 14:09:26 -03:00
Maurício Meneghini Fauth
c8f84fc748 Replace is_null with identical comparison with null
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 13:28:22 -03:00
Maurício Meneghini Fauth
ce71901de5 Refactor js/functions.js to use a module
Adds Functions module in js/functions.js to reduce the number of global variables.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-22 17:44:21 -03:00
Hugues Peccatte
7b00f5d35a Update PHPDoc
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-14 21:59:57 +02:00
William Desportes
65b619c5a8
Merge branch 'QA_4_8'
[ci skip]
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-12 00:41:11 +02:00
William Desportes
47bd88dffa
Add support for auto-increment on ROCKSDB
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-11 23:53:07 +02:00
William Desportes
76dca69460
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-01 22:29:25 +02:00
Nugroho Latifolia
ad6fe25878
Fix #14673 - innodb & MySQL 8: DYNAMIC & COMPRESSED ROW_FORMAT missing
Fixes: #14673

Newer MySQL/MariaDB always return empty a.k.a '' on $innodb_file_format otherwise
        old versions of MySQL/MariaDB must be returning something or not empty.
        This patch is to support newer MySQL/MariaDB while also for backward compatibilities.

Signed-off-by: Nugroho Latifolia <nugroho.latifolia@gmail.com>
2019-04-01 22:17:07 +02:00
Maurício Meneghini Fauth
23c3579804 Format array declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
4cee0cbc12 Adds space after not (!) and type cast
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:56:34 -02:00
Maurício Meneghini Fauth
999b4d14f0 Fix some coding standard errors
- Fixes array identation
- Removes empty statements

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:25:08 -02:00
Maurício Meneghini Fauth
ef5d7dd66b Use Bootstrap buttons component
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-21 01:01:12 -02:00
Maurício Meneghini Fauth
9eba565bf4 Remove unnecessary HTML closing tags
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-19 00:12:54 -02:00
Maurício Meneghini Fauth
76d8bfdafa Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-12 21:04:19 -02:00
William Desportes
ca072c96d9
fix #14749 - Uncaught TypeError in routines
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-27 11:57:38 +01:00
Tomas Votruba
637fe6de06 [cs] remove unused brackets, clean unused property assign
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
2018-11-26 17:54:40 +01:00
Tomas Votruba
bf720bad29 remove unused and fix @param, @var and @return annotation values
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
2018-11-24 21:47:26 +01:00
Madhura Jayaratne
f049c127ca Retrieve parameters from $_POST in database and table operation pages
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2018-11-10 20:48:58 -02:00
Vincent Horváth
3cda8e6093
Fix for #14636 - Move operation causes SELECT * FROM undefined
- fixed params name in operation js file
- set value in global field table to new table name
- fixed refresh page after submit move table
- fixed back quote in message result

Signed-off-by: Vincent Horváth <win9400@gmail.com>
(cherry picked from commit 52024f1d2b)
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-10-25 23:14:21 +02:00
William Desportes
ff349c7e5c
Merge pull request #14656 from wincdev/FIX/issue-14636
Fixes: #14636 - Move operation causes SELECT * FROM `undefined`
2018-10-25 23:06:13 +02:00
Vincent Horváth
52024f1d2b - fixed params name in operation js file
- set value in global field table to new table name
- fixed refresh page after submit move table
- fixed back quote in message result

Signed-off-by: Vincent Horváth <win9400@gmail.com>
2018-10-11 17:02:41 +02:00
Maurício Meneghini Fauth
ae9b0b1862 Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-10-08 13:32:13 -03:00
Maurício Meneghini Fauth
28accc8f98 DatabaseInterface->getDefinition() can return false
Related to https://github.com/phpmyadmin/website/issues/81

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-10-08 13:26:43 -03:00
Maurício Meneghini Fauth
fff7c5736c Remove $GLOBALS['dbi'] from Operations class
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-09-15 18:51:39 -03:00
Maurício Meneghini Fauth
d4b4124a5e Remove $GLOBALS['dbi'] from Relation class
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-08-30 19:05:09 -03:00
Isaac Bennetch
0a254c6989 Fix many Uncaught TypeErrors on a database operations page.
Fixes #14574

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2018-08-18 00:54:31 -04:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
6cf8ee0831 Enable strict mode in some classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-15 01:03:57 -03:00
Madhura Jayaratne
c6dd6b56e2 Fix phpmyadmin-security#240 Multiple CSRF vulnerabilities
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2018-04-18 00:59:33 +10:00
Maurício Meneghini Fauth
d98658187a Replace PhpMyAdmin\Relation static calls
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-25 19:32:13 -03:00
Maurício Meneghini Fauth
a862add418 Replace static methods with instance methods
Replace PhpMyAdmin\Operations static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-25 12:43:49 -03:00
Michal Čihař
6b5d535da5 Adjust table operations to use POST
Issue #13866

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-12-15 12:37:02 +01:00
Michal Čihař
8dc0f4b819 Use session to indicate switching to new database
There is no reason to store this in cookies.

Issue #11688

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-28 15:51:33 +01:00
Michal Čihař
bed6fb4ebd Avois passing extension to Util::getImage
We do not use it anyway for quite some time and this way it's less
processing to generate the img tag.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-27 14:24:42 +01:00
Maurício Meneghini Fauth
cc2c4fc36d Replace globals with DI in Charsets class
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-09 11:31:42 -02:00
Madhura Jayaratne
ac64e36131 Merge branch 'QA_4_7' 2017-11-05 11:04:58 +11:00
Michal Čihař
2cf9b10134 Merge pull request #13682 from jakubstanecki/feature/13560-change-all-table-collations
Added change all table collations when changing database collation
2017-09-28 15:59:34 +02:00
Michal Čihař
50fd2770b8 Avoid referencing possibly unset variable
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-28 14:59:00 +02:00
Maurício Meneghini Fauth
1d4125f15c Add array type declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-24 23:49:59 -03:00
Jakub Stanecki
e3e4fa93fd Added change all table collations when changing database collation
Signed-off-by: Jakub Stanecki <staneckijakub@gmail.com>
2017-09-16 23:06:07 +02:00
Maurício Meneghini Fauth
e2c83b954b Refactor relation functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-08-22 20:51:27 -03:00
Maurício Meneghini Fauth
0d11ecc728 Refactor operations functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-08-20 21:28:36 -03:00