Commit Graph

171 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
8dd310fb6a Remove assignments in if conditions
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-16 01:35:19 -03:00
William Desportes
fcd41f6c85
Remove some mysql extension assertions
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-15 22:17:58 +02:00
Maurício Meneghini Fauth
064ba71ed4 Replace or operator in DatabaseInterface::query method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-15 16:42:59 -03:00
Maurício Meneghini Fauth
75fc2ed74f Remove dbi global from DatabaseInterface::load method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-15 16:24:14 -03:00
Maurício Meneghini Fauth
84139f4d51 Remove some useless variables
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 16:15:37 -03:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
William Desportes
cc82f092ce
Fix MissingClosureParamType errors
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-29 01:08:40 +02:00
William Desportes
9a8e311a76
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-22 17:06:52 +01:00
William Desportes
cc0c975e78
Fix _getSqlForTablesFull and getColumnsFull for Windows CI
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-22 16:59:26 +01:00
William Desportes
818b9f76bf
Fix more broken queries on Windows CI
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-22 16:59:26 +01:00
William Desportes
0455dab6bb
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-15 11:40:12 +01:00
William Desportes
39284cc877
Use isset for errno
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-15 01:42:40 +01:00
William Desportes
47d00d85ef
Fix Uncaught TypeError for strtoupper caught on Windows unit test suite
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-15 01:32:44 +01:00
William Desportes
8f0d7d3fc1
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-14 23:10:20 +01:00
William Desportes
150d72bec4
Fix #15958 - Uncaught TypeError when sorting tables by size or by rows
Fixes: #15958

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-14 23:08:35 +01:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824 Use short versions of scalar types in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
e1c69c6a14 Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-22 00:26:45 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
c231652c67 Remove useless comments in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 14:38:49 -03:00
Maurício Meneghini Fauth
8ec4209002 Fix some coding standard issues
- Inverts yoda comparisons
- Removes parentheses from return
- Removes useless ternary operators
- Adds paretheses to new instances
- Adds trailing array comma

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 00:38:34 -03:00
Maurício Meneghini Fauth
3f7204beb7 Add coding standard rule for self reference
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 23:31:20 -03:00
Maurício Meneghini Fauth
285907991e Add coding standard rules for whitespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 22:29:54 -03:00
William Desportes
249ee4dbd2
Improve JS and phpdoc by removing useless spaces
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-16 18:39:42 +01:00
William Desportes
5b787e7b6d
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-06 20:14:46 +01:00
William Desportes
bd808c8d4f
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-06 15:23:34 +01:00
William Desportes
156231d5bf
Fix not isset $GLOBALS['dblist']
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-06 15:22:35 +01:00
William Desportes
e3f9efe7e0
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-06 14:26:08 +01:00
William Desportes
d01dab811c
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-06 14:25:25 +01:00
William Desportes
6c35ea3be7
Fix #15724 - Fix 2FA disabled
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-06 14:17:03 +01:00
William Desportes
205790f6bd
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-30 17:55:50 +01:00
William Desportes
f9157f2ac4
Fix #15723 - Can't browse certain tables since 5.0.0 update
Fixes: #15723
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-30 17:54:00 +01:00
Maurício Meneghini Fauth
a168ec2948 Fix conding standard issue
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-21 19:02:07 -03:00
William Desportes
06701ab562
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-21 21:48:59 +01:00
William Desportes
9633175165
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-21 21:38:13 +01:00
William Desportes
f402a8f2cf
Merge #15681 - Fix #15608 DisableIS is broken on pma 4.9.2 with controluser configured
Fixes: #15608
Pull-request: #15681
Ref: 2bc8afea5f
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-21 21:34:05 +01:00
William Desportes
28e2814ee9
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-21 21:04:39 +01:00
William Desportes
aa2f369bf3
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-21 20:27:25 +01:00
Maurício Meneghini Fauth
542ba3025a Fix control user issue
Partially reverts commit 2bc8afea5f.

Fixes #15608
Related to #14433

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-21 14:56:59 -03:00
Maurício Meneghini Fauth
9d3f7519c9 Revert "Fix #14433 - "You do not have privileges to manipulate with the users!" on root superadmin"
This reverts commit b8650115be.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-21 14:54:40 -03:00
William Desportes
6e7e90169a
Fix a possibly undefined index as reported to our server
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-21 16:38:21 +01:00
William Desportes
31ee76f507
Fix a phpstan errpr
Introduced-by: c01377b161
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-18 23:03:47 +01:00
William Desportes
cc57586f25
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-18 22:42:20 +01:00
William Desportes
02304bcebf
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-18 21:48:27 +01:00
William Desportes
c01377b161
Fix undefined index for proxysql on @@version_comment and @@version
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-18 18:40:21 +01:00
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
dd2b05330a Remove useless parentheses
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-12 00:18:01 -03:00
Maurício Meneghini Fauth
f6a17433a2 Use null coalesce operator when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 20:16:58 -03:00
Maurício Meneghini Fauth
5e203f625a Extract an interface from DatabaseInterface class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-06 14:24:01 -03:00