gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
118,483 Commits 12 Branches 481 Tags 2.4 GiB
37abda64f7
Commit Graph

424 Commits

Author SHA1 Message Date
William Desportes
81a0fab9b3
Fix coding standard on setup/styles.css 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-16 11:49:39 +02:00
William Desportes
d93efc2eda
Fix Missing vendor-prefixed CSS gradients for Old Webkit (Safari 4+, Chrome). 
Why is this an issue?
CSS gradients in a cross-browser way requires using many different vendor-prefixed versions. There are currently five different vendor-prefixed versions of CSS gradient:

-ms-linear-gradient and -ms-radial-gradient for Internet Explorer 10+
-moz-linear-gradient and -moz-radial-gradient for Firefox 3.6+
-o-linear-gradient and -o-radial-gradient for Opera 11.10+
-webkit-linear-gradient and -webkit-radial-gradient for Safari 5+ and Chrome
-webkit-gradient for Safari 4+ and Chrome (aka "Old WebKit")
Meaning a simple two-color gradient that works across all browsers must look like this:

 background: -moz-linear-gradient(...); /* FF3.6+ */
 background: -webkit-gradient(...); /* Chrome,Safari4+ */
 background: -webkit-linear-gradient(...); /* Chrome10+,Safari5.1+ */
 background: -o-linear-gradient(...); /* Opera 11.10+ */
 background: -ms-linear-gradient(...); /* IE10+ */
It's easy to forget one or more gradient definitions with all of the various vendor prefix gradients available.
[By Codacy]

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-16 10:54:57 +02:00
William Desportes
076a84d259
Run stylelint on setup CSS styles 
Some errors are unfixed:
setup/styles.css
 459:5  ✖  Unexpected duplicate "background"                            declaration-block-no-duplicate-properties        
 459:5  ✖  Unexpected shorthand "background" after "background-image"   declaration-block-no-shorthand-property-overrides
 459:5  ✖  Unexpected shorthand "background" after "background-size"    declaration-block-no-shorthand-property-overrides
 460:5  ✖  Unexpected duplicate "background"                            declaration-block-no-duplicate-properties        
 460:5  ✖  Unexpected shorthand "background" after "background-image"   declaration-block-no-shorthand-property-overrides
 460:5  ✖  Unexpected shorthand "background" after "background-size"    declaration-block-no-shorthand-property-overrides
 461:5  ✖  Unexpected duplicate "background"                            declaration-block-no-duplicate-properties        
 461:5  ✖  Unexpected shorthand "background" after "background-image"   declaration-block-no-shorthand-property-overrides
 461:5  ✖  Unexpected shorthand "background" after "background-size"    declaration-block-no-shorthand-property-overrides
 462:5  ✖  Unexpected duplicate "background"                            declaration-block-no-duplicate-properties        
 462:5  ✖  Unexpected shorthand "background" after "background-image"   declaration-block-no-shorthand-property-overrides
 462:5  ✖  Unexpected shorthand "background" after "background-size"    declaration-block-no-shorthand-property-overrides
 473:5  ✖  Unexpected shorthand "background" after "background-image"   declaration-block-no-shorthand-property-overrides
 473:5  ✖  Unexpected shorthand "background" after "background-size"    declaration-block-no-shorthand-property-overrides
 474:5  ✖  Unexpected shorthand "background" after "background-image"   declaration-block-no-shorthand-property-overrides
 474:5  ✖  Unexpected shorthand "background" after "background-size"    declaration-block-no-shorthand-property-overrides
 475:5  ✖  Unexpected shorthand "background" after "background-image"   declaration-block-no-shorthand-property-overrides
 475:5  ✖  Unexpected shorthand "background" after "background-size"    declaration-block-no-shorthand-property-overrides
 476:5  ✖  Unexpected shorthand "background" after "background-image"   declaration-block-no-shorthand-property-overrides
 476:5  ✖  Unexpected shorthand "background" after "background-size"    declaration-block-no-shorthand-property-overrides

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-15 23:47:48 +02:00
Maurício Meneghini Fauth
585fdaea5a Fix PHP doc spacing and order 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 18:07:37 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations 
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
88cfde2bed Remove empty comments 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 13:33:38 -03:00
Maurício Meneghini Fauth
63dbcd01d9 Remove or ignore side effects in PHP files 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-19 20:22:37 -03:00
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments 
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
dd2b05330a Remove useless parentheses 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-12 00:18:01 -03:00
Maurício Meneghini Fauth
e222cb8beb Merge branch 'QA_5_0' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-09-21 13:02:14 -03:00
Maurício Meneghini Fauth
08696bc55e Merge branch 'QA_4_9' into QA_5_0 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-09-21 12:51:04 -03:00
Maurício Meneghini Fauth
427fbed55d Require POST method to delete servers in Setup 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-09-18 22:40:32 -03:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines 
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
b762a24238 Fix missing dbi global initialization on Setup 
Fixes #15337

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-17 19:25:51 -03:00
Maurício Meneghini Fauth
7be0f6bfae Reference class names in use statements 
Sort use statements

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-12 00:14:26 -03:00
Maurício Meneghini Fauth
1510ddcb67 Move Setup JavaScript files to js/setup/ directory 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-02 17:39:44 -03:00
Maurício Meneghini Fauth
e20601571b Fix ESLint errors in setup/scripts.js 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-02 17:39:44 -03:00
Maurício Meneghini Fauth
6f8e53cf5c Rename js/config.js variables to use camel case 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-05-30 00:42:22 -03:00
Maurício Meneghini Fauth
94a18417ee Declare $cfg global variable explicitly 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-05-14 13:03:23 -03:00
Maurício Meneghini Fauth
2210debbf9 Fix type error in setup script when adding new server 
Fixes #14312

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-03-15 14:38:58 -03:00
Maurício Meneghini Fauth
21b1ac53c8 Remove unnecessary require 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-03-06 18:36:59 -03:00
Maurício Meneghini Fauth
2b33194dcc Move setup/lib classes to libraries/classes/Setup 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-03-06 17:27:24 -03:00
Maurício Meneghini Fauth
d2d65d5a7b Create controllers for setup pages 
- Create PhpMyAdmin\Controllers\Setup\HomeController
- Create PhpMyAdmin\Controllers\Setup\ConfigController
- Create PhpMyAdmin\Controllers\Setup\FormController
- Create PhpMyAdmin\Controllers\Setup\ServersController
- Remove setup/frames directory

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-03-06 17:04:58 -03:00
Rob Ratcliffe
02c16b0acc Removing inline styles from php files and adding class to css 
Closes #14696

Signed-off-by: Rob Ratcliffe <rlr@tcliffe.codes>
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-24 21:06:29 -03:00
Maurício Meneghini Fauth
23c3579804 Format array declarations 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
4cee0cbc12 Adds space after not (!) and type cast 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-05 21:56:34 -02:00
Maurício Meneghini Fauth
999b4d14f0 Fix some coding standard errors 
- Fixes array identation
- Removes empty statements

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-05 21:25:08 -02:00
Maurício Meneghini Fauth
38e5b12c1c Define an absolute path to use for require statements 
Fixes #6167

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-12-22 14:37:31 -02:00
Maurício Meneghini Fauth
9eba565bf4 Remove unnecessary HTML closing tags 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-12-19 00:12:54 -02:00
William Desportes
cc2665121d
phpstan level 2 - fixes 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2018-11-25 13:57:57 +01:00
Maurício Meneghini Fauth
f24545e633 Refactor Config/FormDisplayTemplate 
Replaces $GLOBALS['PMA_Config'] with DI

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-06-06 15:47:00 -03:00
Maurício Meneghini Fauth
b25be9ee75 Refactor Config/FormDisplayTemplate methods 
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-06-05 22:47:17 -03:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax 
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
af148ad92b Enable strict mode in PHP files 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-16 04:36:04 -03:00
Maurício Meneghini Fauth
8f8e3c26c9 Replace .click() with .on() 
.click() event shorthand is deprecated

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-11 23:58:35 -03:00
Maurício Meneghini Fauth
ed76f7cffd Remove displayFieldsetBottomSimple method 
Can be replaced by displayFieldsetBottom(false)

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-10 19:19:43 -02:00
Paweł Skokowski
f863a896c1 Removed inline css in index.inc.php 
Signed-off-by: Paweł Skokowski <skokowskipawel@icloud.com>
 2017-10-20 23:40:07 +02:00
Maurício Meneghini Fauth
ef99fef8d6 Change ESLint's eqeqeq to error 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-09-25 21:30:14 -03:00
Maurício Meneghini Fauth
00e1ca9b66 Automatic fixes by ESLint 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-09-25 14:22:35 -03:00
Maurício Meneghini Fauth
1d4125f15c Add array type declarations 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-09-24 23:49:59 -03:00
Maurício Meneghini Fauth
b68b570773 Refactor setup/form_processing to static methods 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-09-14 17:51:34 -03:00
Maurício Meneghini Fauth
614b8a6978 Refactor setup/index functions to static methods 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-09-14 17:51:34 -03:00
Maurício Meneghini Fauth
695f51034d Refactor FormDisplay.tpl functions to static methods 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-09-14 11:53:56 -03:00
Maurício Meneghini Fauth
ce49e7f60f Refactor user_preferences functions to static methods 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-09-12 22:31:02 -03:00
Michal Čihař
a82f8fc768 Move databaase interface load to static method 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-09-06 14:46:56 +02:00
Michal Čihař
e065793dc8 Fold validity check with getting class 
There is no need to do this twice (once in ::get).

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-09-06 11:06:51 +02:00
Michal Čihař
953ef05b92 Use forms to define menu and titles on setup 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-09-06 11:05:10 +02:00
Michal Čihař
8490d3a571 Rewrite Setup settings forms as classes 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-09-06 11:05:09 +02:00
Michal Čihař
0b81218a10 Refactor configuration descriptions into class 
This avoids loading them all into global namespace on every request.

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-09-05 14:44:05 +02:00