Commit Graph

125 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
dd2b05330a Remove useless parentheses
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-12 00:18:01 -03:00
Maurício Meneghini Fauth
77518d341e Remove unused use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 21:20:58 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
Hugues Peccatte
3255e4ad7b Split Util class regarding the responsabilities (#15567)
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.

There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.

* Split Util class regarding the responsabilities
* Split the buttonOrImage function

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-11-21 20:20:05 -03:00
Oleg Abrazhaev
43e1d4cade use twig in Structure and Variables controller and add missing tests #14801 (#15534)
* use twig in Structure and Variables controller and add missing tests #14801

Signed-off-by: Oleg Abrazhaev <seyferseed@gmail.com>

* fix lint

Signed-off-by: Oleg Abrazhaev <seyferseed@gmail.com>

* Update templates/database/structure/overhead.twig

fix code review

Co-Authored-By: Maurício Meneghini Fauth <mauricio@fauth.dev>

* Update libraries/classes/Controllers/Database/StructureController.php

fix code review

Co-Authored-By: Maurício Meneghini Fauth <mauricio@fauth.dev>

* fix code review

Signed-off-by: Oleg Abrazhaev <seyferseed@gmail.com>
2019-10-29 22:48:29 -03:00
Maurício Meneghini Fauth
5b1256b737 Remove server common from MonitorController constructor
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-27 17:45:42 -03:00
Maurício Meneghini Fauth
ae05259f9c Move server replication entry point to routes file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-27 15:49:22 -03:00
Maurício Meneghini Fauth
bad2b8eca9 Move server variables entry point to routes file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-27 15:21:59 -03:00
Maurício Meneghini Fauth
a42b6a1588 Move server status variables to routes file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-27 14:31:44 -03:00
Maurício Meneghini Fauth
3804d4e8cc Move server status queries entry point to routes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-27 14:13:55 -03:00
Maurício Meneghini Fauth
11ace284fa Move srv status processes entry point to routes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-27 14:01:20 -03:00
Maurício Meneghini Fauth
4a793282a0 Move server status monitor entry point to routes file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-26 18:08:57 -03:00
Maurício Meneghini Fauth
110e00776e Move server status advisor to routes file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-26 15:55:52 -03:00
Maurício Meneghini Fauth
ed6d079f25 Move server status entry point logic to routes file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-26 14:54:26 -03:00
Maurício Meneghini Fauth
065f3f560c Move server sql entry point to the routes file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-26 14:30:00 -03:00
Maurício Meneghini Fauth
9372bae319 Move server collation entry point to routes.php
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-26 12:15:29 -03:00
Maurício Meneghini Fauth
3814d88e2c Refactor server binlog entry point
Moves entry point logic to the routes file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-21 11:05:12 -03:00
Maurício Meneghini Fauth
0c99e03a1e Refactor the server databases entry point
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-09 22:45:56 -03:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
dc7372fb99 Fix URL query issues with Util::getScriptNameForOption
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-22 17:30:18 -03:00
Maurício Meneghini Fauth
6625114b98 Fix database link in /server/databases
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-18 22:38:54 -03:00
Hugues Peccatte
c233a4364a Use right PHP function
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-07-16 23:21:25 -03:00
Maurício Meneghini Fauth
12561a598d Remove direct access to server_databases.php
Uses the router instead

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-09 21:51:49 -03:00
Maurício Meneghini Fauth
34a63c6a77 Add toArray method to Server\Plugin class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-02 00:57:53 -03:00
Maurício Meneghini Fauth
b9ec5071fe Add Server\Plugin value object
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-02 00:40:54 -03:00
Maurício Meneghini Fauth
711ef54eca Add Charsets::findCollationByName method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-28 02:17:57 -03:00
Maurício Meneghini Fauth
4fe624fa93 Remove Charsets::getCollationDropdownBox method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-25 03:32:01 -03:00
Maurício Meneghini Fauth
02766cf370 Add Charset and Collation value types
And refactor Charset class

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-23 05:19:53 -03:00
William Desportes
a2268169ae
Use strict compare for count function
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 17:44:49 +02:00
William Desportes
64c1b26bac
Use strict compare for booleans
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 17:41:54 +02:00
Maurício Meneghini Fauth
e1f9ae00cd Add a trailing comma in multi-line arrays
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-14 14:09:26 -03:00
Maurício Meneghini Fauth
7be0f6bfae Reference class names in use statements
Sort use statements

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 00:14:26 -03:00
Maurício Meneghini Fauth
05ce6ffed4 Rename js/server_*.js to js/server/*.js
Rename js/server_status_*.js to js/server/status/*.js

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-07 03:56:22 -03:00
Hugues Peccatte
9abd308837 Inject dependencies (#15271)
Inject dependencies instead of building them.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-06-01 15:13:41 -03:00
Hugues Peccatte
380707fbcd Define controllers as services in an external configuration file
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-19 01:54:44 +02:00
Maurício Meneghini Fauth
26a6a8dd4c Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-01 01:56:27 -03:00
William Desportes
ca3f027f7e
Fix #13178 - Issues with uppercase table and database names
Fixes: #13178
[ci skip]
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-28 21:32:31 +02:00
William Desportes
1524ec51c8
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-28 01:00:28 +02:00
Maurício Meneghini Fauth
5e828ec810 Create Server\ReplicationController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-04-06 20:26:06 -03:00
Maurício Meneghini Fauth
4d9da96469 Create server, database and table SqlControllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-23 22:41:29 -03:00
Maurício Meneghini Fauth
c9371d3a91 Rename Controller to AbstractController
Rename PhpMyAdmin\Controllers\Controller to
PhpMyAdmin\Controllers\AbstractController.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-11 15:57:14 -03:00
Maurício Meneghini Fauth
35e6b43ba8 Rename Status\Controller to Status\AbstractController
Rename PhpMyAdmin\Controllers\Server\Status\Controller to
PhpMyAdmin\Controllers\Server\Status\AbstractController.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-11 15:26:57 -03:00
Maurício Meneghini Fauth
7c828f7327 Remove PhpMyAdmin\Server\Status\Data::getHtmlForRefreshList()
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-25 20:42:44 -03:00
Maurício Meneghini Fauth
2074be7eab Create Server\Status\VariablesController
Extracts server_status_variables.php and Server\Status\Variables logic
to the controller.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-25 19:02:54 -03:00
Maurício Meneghini Fauth
e149a6188f Create Server\Status\QueriesController
Extracts server_status_queries.php and Server\Status\Queries logic to
the controller.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-25 00:53:57 -03:00
Maurício Meneghini Fauth
c485c311aa Create Server\Status\ProcessesController
Extracts server_status_processes.php and Server\Status\Processes logic
to controller.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-21 23:25:30 -03:00
Maurício Meneghini Fauth
12ae5553a6 Create Server\Status\MonitorController
Moves server_status_monitor.php logic to controller

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-21 02:23:23 -03:00
Maurício Meneghini Fauth
c9a31450fa Create server status abstract controller
Create PhpMyAdmin\Controllers\Server\Status\Controller abstract
controller.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-19 17:13:48 -03:00
Maurício Meneghini Fauth
5368c151b4 Create Server\Status\StatusController
- Extracts Server\Status and server_status.php logic to controller
- Extracts HTML to server/status/status/index template

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-18 15:59:59 -03:00