gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
117,025 Commits 12 Branches 481 Tags 2.4 GiB
39770eec88
Commit Graph

201 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments 
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
dd2b05330a Remove useless parentheses 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-12 00:18:01 -03:00
Maurício Meneghini Fauth
80a3c50bf5 Remove some useless if conditions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-11 20:43:57 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage 
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-01 14:10:07 -03:00
Maurício Meneghini Fauth
055087c063 Convert serverinfo bar to Bootstrap's breadcrumbs 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-11-30 13:43:42 -03:00
Maurício Meneghini Fauth
fdeb75b6cb Move WebDriver Maximize method to TestBase setUp 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-11-12 17:03:43 -03:00
Maurício Meneghini Fauth
1c9062ccd3 Move check relations entry point to routes file 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-11-06 21:11:21 -03:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines 
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
dd3753b8f1 Remove namespace in Selenium tests 
To improve readability.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-08-25 17:48:56 -03:00
Maurício Meneghini Fauth
277bf0715f Use the router for check relations page 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-08-19 20:28:08 -03:00
William Desportes
d9f2428032
Remove unused imports and fix an error reported by Scrutinizer 2019-06-22 17:55:58 +02:00
Maurício Meneghini Fauth
7be0f6bfae Reference class names in use statements 
Sort use statements

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-12 00:14:26 -03:00
Maurício Meneghini Fauth
a6e53e2022 Replace get_class($this) and __CLASS__ 
with static::class and class name

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-11 22:54:10 -03:00
Maurício Meneghini Fauth
0b3014207d Use camel case for most of the js/functions.js variables 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-05-27 00:55:10 -03:00
Maurício Meneghini Fauth
6bd2dbd5f2 Add support for PHPUnit 8 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-24 16:32:28 -03:00
Maurício Meneghini Fauth
182491a73f Add void return type declaration for tests 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-22 21:33:55 -03:00
Maurício Meneghini Fauth
25e480666e Fix doc comments alignment 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-07 15:09:32 -02:00
Maurício Meneghini Fauth
23c3579804 Format array declarations 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
4cee0cbc12 Adds space after not (!) and type cast 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-05 21:56:34 -02:00
Maurício Meneghini Fauth
3a7e1503ac Fix some coding standard errors 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-04 19:42:10 -02:00
William Desportes
f0b51c144f
Remove unused code in tests 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2018-11-29 19:15:41 +01:00
William Desportes
cc2665121d
phpstan level 2 - fixes 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2018-11-25 13:57:57 +01:00
William Desportes
bcefdd79fa
phpstan level 2 - Fix phpdoc 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2018-11-25 13:57:55 +01:00
Lakshay arora
2a07cee164 Automatically add index while editing an existing row and setting auto increment (#14417) 
* Automates the addition of PRIMARY KEY index when user tries to edit an existing row and set AUTO INCREMENT.
* Disables the popup on insert new column page when user sets AUTO INCREMENT and automatically sets the index to PRIMARY KEY.

Signed-off-by: Lakshay arora <arora.lakshya123@gmail.com>
 2018-10-23 16:33:36 -03:00
William Desportes
ea830e70b3
Try multiple browsers 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2018-10-11 11:30:38 +02:00
William Desportes
862788d782
Migrate tests to facebook/webdriver 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2018-10-11 11:30:06 +02:00
William Desportes
d9153ae069
Add TESTSUITE_PORT for selenium tests 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2018-10-11 11:30:05 +02:00
William Desportes
e816e45c18 phpstan level 0 (#14405) 
* Fix phpdoc @return

- Fixed @return typehint

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fix incorrect case on function calls

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Type hint + typo fix

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fixes

- @return fix
- @var fix
- Class names
- Throws fix
- test/classes/Plugins/Export/ExportSqlTest.php any() invoked with 1 parameter, 0 required
-  libraries/classes/Controllers/Table/TableStructureController.php Array has 2 duplicate keys with value 'columns_list'
- Call parent constructor  libraries/classes/Error.php

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Update config

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Access to an undefined property

- Access to an undefined property PhpMyAdmin\Plugins\Schema\Pdf\PdfRelationSchema::$diagram_row
- Access to an undefined property PhpMyAdmin\Plugins\Schema\Pdf\Pdf::$cMargin
- Undefined properties

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Update config

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fix bootstrap-phpstan

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fix typos and phpstan config

Fixes: #14399
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2018-06-25 20:34:46 -03:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax 
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
baf0985e5f Fix phpcs errors 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-18 01:59:38 -03:00
Maurício Meneghini Fauth
dc8c92bfd8 Enable strict mode in test files 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-16 04:36:04 -03:00
Maurício Meneghini Fauth
8c0637a282 Upgrade Selenium tests to PHPUnit 6.5 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-04-13 00:48:19 -03:00
Gabriel Caruso
6ff73257e2 Simplify returns 
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
 2018-01-16 10:16:56 -02:00
Michal Čihař
a5ebbd9e55 Fix exception handling in selenium tests 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-12-18 14:52:18 +01:00
Michal Čihař
7a6f85949a Fix mysqli class name 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-12-18 13:42:52 +01:00
Michal Čihař
1957af5663 Remove PmaSelenium prefix from Selenium tests 
It is good enough to have Selenium in the namespace.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-12-18 13:10:38 +01:00
Michal Čihař
8b8e68c6bf Use PSR-4 for loading selenium tests and adjust their names 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-12-18 13:09:01 +01:00
Michal Čihař
4c2c38f341 Remove type hinting from onNotSuccessfulTest 
Upstream has removed that as well.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-12-15 10:24:24 +01:00
Michal Čihař
fe493f6d46 Avoid horizontal scrolling 
It would have to subtract width of navigation and is not needed in most cases.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-29 10:31:34 +01:00
Michal Čihař
fd9150460e Use fully CSS based icons 
- themes can easier customize their look
- this better deals with previous JS code who relied on sprites (fixes #13815)

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-27 13:47:43 +01:00
Michal Čihař
cedad5f931 Remove sprites from the themes 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-13 14:12:12 +01:00
Michal Čihař
f1326358d2 Add separate wait for message to disappear 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-09-07 15:35:33 +02:00
Michal Čihař
e9dece41a9 Simplify waitAjax 
Wait only based on javascript flag.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-09-07 15:17:06 +02:00
Michal Čihař
580cb38562 We need to scroll relatively as getBoundingClientRect returns offset 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-09-07 15:17:06 +02:00
Michal Čihař
2abb2db01d Remove sleep after scrollToBottom, should not be necessary 
The javascript is executed synchronously, so there should be no delay.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-09-07 15:17:06 +02:00
Michal Čihař
037dde0e42 Share code for waiting for CodeMirror 
It takes some time to initialize, so we should wait for it.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-09-07 15:17:06 +02:00
Michal Čihař
c674ab8791 Try getting element directly in waitForElement 
This can avoid 3 round trips to Selenium server in most situations, so
it can help performance.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-09-07 15:17:06 +02:00
Michal Čihař
eae223215a Run Chrome tests on Windows 
It seems to perform way better with webdriver than OS X.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-09-07 15:17:06 +02:00
Michal Čihař
eabdf845c3 Fix waiting for AJAX popup disappear in Selenium tests 
Waiting for ajax_message_num_1 works only on first AJAX request and
we're doing more of them. This should remove need for many consequent
sleeps as we were actually not properly waiting for element.

Also it's better to wrap this logic in separate method as it is used in
many places in the code.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-09-07 15:17:06 +02:00