Maurício Meneghini Fauth
3a6cd6be21
Fix return type declaration of fetchAssoc method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-29 12:52:31 -03:00
William Desportes
b0021bf84d
Fixes : #16149 - Remove underscore prefix from all method names
...
Ref: #16159
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-03 00:21:24 +02:00
William Desportes
f433d5e7bc
Remove a typehint and document the edge case for _fetchValue
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-02 22:50:51 +02:00
William Desportes
802797c176
Move getConnectionParams to Config class
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 16:01:38 +02:00
William Desportes
36fa925914
Extract SQL query from DatabaseInterface::getColumnsFull
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 15:08:36 +02:00
William Desportes
73fb678d08
Extract SQL query from DatabaseInterface::getDatabasesFull
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 15:01:58 +02:00
William Desportes
ffcabac791
Simplify DatabaseInterface _fetchValue
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 14:54:33 +02:00
William Desportes
8e164bda85
Move _dbgQuery to Query\Utilities as debugLogQueryIntoSession
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 14:47:39 +02:00
William Desportes
eecab19b3e
Move versionToInt to Query\Utilities
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 14:18:03 +02:00
William Desportes
54e27c6a3d
Simplify DatabaseInterface fetchValue logic
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 14:17:01 +02:00
William Desportes
aadb6abfeb
Move usortComparisonCallback to Query\Utilities and remove 2 globals
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 10:34:02 +02:00
William Desportes
7e9d2ae4f9
Move more SQL queries into Query\Generator
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 02:16:02 +02:00
William Desportes
585304b685
Move formatError into Query\Utilities
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 01:44:02 +02:00
William Desportes
761045bcc9
Move getSystemSchemas and isSystemSchema to Query\Utilities
...
If you think the class name could be better, feel free to improve it.
Everybody know naming classes is difficult ^^
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 01:42:53 +02:00
William Desportes
312bf572f2
Move some compatibility handling into Query\Compatibility
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 01:26:07 +02:00
Maurício Meneghini Fauth
e2eac49ad2
Use closures to call private methods as callback
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-30 13:14:06 -03:00
William Desportes
9ce286070e
Merge #16142 - Split some code out of DatabaseInterface
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-27 18:35:07 +02:00
Maurício Meneghini Fauth
f4582e083e
Use early exit when possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
bd979dd1ff
Remove useless elseif with if
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 22:53:44 -03:00
Maurício Meneghini Fauth
2d02a15de3
Add static to closures that don't use $this
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 18:30:57 -03:00
William Desportes
4d61ef2313
Split some code out of DatabaseInterface
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-26 13:18:01 +02:00
Maurício Meneghini Fauth
3baad2eb1c
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
9269d75fb4
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 20:22:18 -03:00
William Desportes
11cb629bf0
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-24 01:27:19 +02:00
Petr Duda
ad00dfc24c
Fix #16130 - Local documentation links
...
Signed-off-by: Petr Duda <petrduda@seznam.cz>
2020-05-23 17:36:57 +02:00
Maurício Meneghini Fauth
80a45fa0ae
Break too long lines
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-16 18:08:20 -03:00
Maurício Meneghini Fauth
8dd310fb6a
Remove assignments in if conditions
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-16 01:35:19 -03:00
William Desportes
fcd41f6c85
Remove some mysql extension assertions
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-15 22:17:58 +02:00
Maurício Meneghini Fauth
064ba71ed4
Replace or operator in DatabaseInterface::query method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-15 16:42:59 -03:00
Maurício Meneghini Fauth
75fc2ed74f
Remove dbi global from DatabaseInterface::load method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-15 16:24:14 -03:00
Maurício Meneghini Fauth
84139f4d51
Remove some useless variables
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 16:15:37 -03:00
Maurício Meneghini Fauth
a64393e7f5
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
William Desportes
cc82f092ce
Fix MissingClosureParamType errors
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-29 01:08:40 +02:00
William Desportes
9a8e311a76
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-22 17:06:52 +01:00
William Desportes
cc0c975e78
Fix _getSqlForTablesFull and getColumnsFull for Windows CI
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-22 16:59:26 +01:00
William Desportes
818b9f76bf
Fix more broken queries on Windows CI
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-22 16:59:26 +01:00
William Desportes
0455dab6bb
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-15 11:40:12 +01:00
William Desportes
39284cc877
Use isset for errno
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-15 01:42:40 +01:00
William Desportes
47d00d85ef
Fix Uncaught TypeError for strtoupper caught on Windows unit test suite
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-15 01:32:44 +01:00
William Desportes
8f0d7d3fc1
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-14 23:10:20 +01:00
William Desportes
150d72bec4
Fix #15958 - Uncaught TypeError when sorting tables by size or by rows
...
Fixes : #15958
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-14 23:08:35 +01:00
Maurício Meneghini Fauth
206199105e
Remove useless return type annotations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824
Use short versions of scalar types in PHP docs
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
e1c69c6a14
Reference global funcs and consts via use statement
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-22 00:26:45 -03:00
Maurício Meneghini Fauth
f80d3e3bd4
Remove unnecessary annotations
...
@package, @subpackage and others.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf
Use one line for comments with a single line
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
c231652c67
Remove useless comments in PHP docs
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 14:38:49 -03:00
Maurício Meneghini Fauth
8ec4209002
Fix some coding standard issues
...
- Inverts yoda comparisons
- Removes parentheses from return
- Removes useless ternary operators
- Adds paretheses to new instances
- Adds trailing array comma
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 00:38:34 -03:00
Maurício Meneghini Fauth
3f7204beb7
Add coding standard rule for self reference
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 23:31:20 -03:00
Maurício Meneghini Fauth
285907991e
Add coding standard rules for whitespace
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 22:29:54 -03:00