gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
114,008 Commits 12 Branches 481 Tags 2.4 GiB
3aa7a35dae
Commit Graph

877 Commits

Author SHA1 Message Date
William Desportes
10745bb392
#15363 - substr can return false 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-08-20 16:43:31 +02:00
William Desportes
62a17fea45
Fix #14291 - Incorrect linkage from one table's value to another table 
Fixes: #14291
Pull-request: #15414

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-08-20 10:24:43 +02:00
William Desportes
c4640c64b3
Fix #15388 - Allow rollback if empty statement 
Fixes: #15388
Pull-request: #15408

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-08-20 10:16:24 +02:00
William Desportes
bef259c510
Fix NULL wrongly checked on field change 
Pull-request: #15445

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-08-20 10:04:42 +02:00
William Desportes
6f14206810
Fix #15363 - Remove unexpected quotes on text fields 
Fixes: #15363
Pull-request: #15409

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-08-20 10:03:27 +02:00
Hugues Peccatte
98a7479174 Fix NULL wrongly checked on field change 
When a field was requested to be changed, the "null" field was compared to its previous value. Unfortunately, both fields don't have the same value, so a change was always identified.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-08-19 18:00:18 +02:00
William Desportes
a0bf9b50d1
Fix PHP 7.4 deprecation: accessing offset on null/bool 
Pull-request: #15405
Ref: #15412
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-08-15 23:38:29 +02:00
William Desportes
b4d3b07476
Fix #15363 - Remove unexpected quotes on text fields 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-08-15 22:13:17 +02:00
Hugues Peccatte
c36a2cef02
Fix #15363 Remove unexpected quotes on text fields 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-08-15 20:53:36 +02:00
William Desportes
cfa1be5916
Fix #14950 - Left database overview "add column" triggers error 
Fixes: #14950
Fixes: #15430
Pull-request: #15431

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-08-15 20:42:52 +02:00
Kartik Kathuria
fd1bcc2415
Fix #15202 - escaped correctly password 
Fixes: #15202
Signed-off-by: Kartik Kathuria <kathuriakartik0@gmail.com>
 2019-08-15 20:27:58 +02:00
Shen Chen
e9ca69dcb7 [Bugfix] update if statement to make sure the field is not empty. 
Signed-off-by: Shen Chen <schen89@live.com>
 2019-08-13 23:59:32 -04:00
William Desportes
71a032de33
Fix #15427 - "FilterLanguages" option does not work 
Pull-request: #15426
Fixes: #15427
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-08-11 18:42:40 +02:00
Vadim Chernyshev
79c0c8a8f3 Fixed configuration for FilterLanguages 
Signed-off-by: Vadim Chernyshev <tryfunc@gmail.com>
 2019-08-11 19:13:54 +03:00
Hugues Peccatte
02225781f2 Add missing PHPDoc for new $displayedData parameter 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-08-02 22:50:01 +02:00
Hugues Peccatte
20735aeff0 Fix #14291 Incorrect linkage from one table's value to another table 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-08-02 22:50:01 +02:00
Hugues Peccatte
0aeb0963ae Fix #15388 Allow rollback if empty statement 
When statement finishes with spaces, there is an "empty" statement. An empty statement is rollbackable.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-07-28 21:16:50 +02:00
Jack Cherng
b89c17c7d7
Fix PHP 7.4 accessing offset on null/bool 
null['xxx'] or false['xxx'] emits a notice in PHP 7.4.

Problematic pages:

- phpMyAdmin/db_tracking.php?db=DB_NAME
- phpMyAdmin/server_privileges.php?adduser=1
- some other pages using POST method...

0e6e2297fc/UPGRADING (L25-L28)

Signed-off-by: Jack Cherng <jfcherng@gmail.com>
 2019-07-27 09:14:13 +08:00
Jack Cherng
b989e825e1
Fix PHP 7.4 deprecation: array/string curly braces access 
Deprecated: Array and string offset access syntax with curly braces is deprecated

0e6e2297fc/UPGRADING (L356-L357)

Signed-off-by: Jack Cherng <jfcherng@gmail.com>
 2019-07-27 08:34:16 +08:00
William Desportes
b42685c63a
Fix errors when reporting errors 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-07-01 11:28:18 +02:00
Maurício Meneghini Fauth
6451c1371f Add description for the _nopad (NO PAD) collation suffix 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-30 00:09:07 -03:00
Maurício Meneghini Fauth
c75b141fd5 Add description for the _ks (kana-sensitive) collation suffix 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-29 23:51:07 -03:00
Maurício Meneghini Fauth
2adab7cb27 Added Russian, Swedish, Slovak and Chinese UCA 9.0.0 collations description 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-29 23:42:01 -03:00
Maurício Meneghini Fauth
48676c2270 Add GB18030 Chinese collations description 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-29 14:54:48 -03:00
William Desportes
cc73250b43
Fix #14918 - Use hex for the session token 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-06-24 22:05:56 +02:00
William Desportes
aab50ab37a
Replace $_REQUEST by $_GET and $_POST for GIS visualisation 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-06-22 14:16:42 +02:00
William Desportes
bbac072fb5
Fix #15334 - export of GIS visualisation not working 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-06-22 14:14:52 +02:00
William Desportes
5e66bdeba2
Fix coding standard errors and phpdoc 
[ci skip]

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-06-22 13:04:38 +02:00
William Desportes
d2caddf5e9
Fix broken foreign key links 
Fixes: #14270 - Middle-click on foreign key link broken
Fixes: #14363 - Broken relational links in tables
Pull-request: #15325

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-06-22 11:41:39 +02:00
Maurício Meneghini Fauth
1b6c564ee2 Fix a TypeError in Import class with PHP 8 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-19 15:43:52 -03:00
William Desportes
fc014c5b72
Harden the HMAC secret by using the blowfish_secret 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-06-13 20:05:11 +02:00
William Desportes
80a7f0a75c
Make the hmac secret a secret for the user 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-06-13 19:05:04 +02:00
William Desportes
c59790b05e
Remove typehints for hhvm 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-06-12 13:36:58 +02:00
William Desportes
4bf8bfcaa1
Fix broken foreign key links 
Fixes: #15225 - Using Command+Click to open in new tab does not work (Firefox/Safari)
Fixes: #14270 - Middle-click on foreign key link broken
Fixes: #14363 - Broken relational links in tables

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-06-12 10:43:15 +02:00
William Desportes
ec74b34010
Fix "logout and try as another user link" 
- I changed the link to not use ajax mode

Try the query 'GRANT PROXY ON 'root'@'localhost' TO 'root'@'localhost' WITH GRANT OPTION' to reproduce

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-06-09 17:15:16 +02:00
William Desportes
64dc20460e
Fix #15315 - Cannot edit or export TIMESTAMP column with default CURRENT_TIMESTAMP in MySQL >= 8.0.13 
Fixes: #15315

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-06-09 16:43:45 +02:00
Isaac Bennetch
e7b73831e5 Prepare for version 4.9.1 
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
 2019-06-04 12:21:25 -04:00
Isaac Bennetch
004848d93f Prepare version 4.9.0.1 
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
 2019-06-04 12:05:18 -04:00
Isaac Bennetch
712e4a2d98 Prepare for 4.9.1-dev 
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
 2019-06-04 11:34:38 -04:00
Isaac Bennetch
519c32bc08 Prepare for release 4.9.0 
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
 2019-06-04 10:45:01 -04:00
Isaac Bennetch
8108eb7ded Merge remote-tracking branch 'security/QA_4_8-security' into QA_4_8 2019-06-04 10:41:26 -04:00
Maurício Meneghini Fauth
015c404038 Retrieve parameters from $_POST in AuthenticationCookie plugin 
Retrieves pma_username and pma_password parameters from $_POST instead of $_REQUEST

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-01 15:50:33 -03:00
Eugene Kazakov
9edcc5e43a Bug #10846 TypeError: Cannot read property 'substring' of undefined 
Signed-off-by: Eugene Kazakov <ekazakov@plesk.com>
 2019-05-31 18:21:30 +02:00
William Desportes
d198598b93
Fix class name 
Introduced-by: 9d586fc539
[ci skip]
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-05-28 00:00:56 +02:00
William Desportes
9d586fc539
#15041 - Fix logo link for internal links 
As documented here: 761a1f623b
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-05-27 21:42:45 +02:00
Maurício Meneghini Fauth
dafc17c52e Add explicit parentheses in nested ternary operators 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-05-22 18:32:42 -03:00
William Desportes
073169f6f3
Fix key block size (sprintf) 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-05-19 22:06:19 +02:00
William Desportes
d0cb22a819
Fix #13854 - Column options are ignored for GENERATED/VIRTUAL/STORED columns 
Fixes: #13854
Pull-request: #15278
Pull-request: #15275
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-05-19 20:10:57 +02:00
William Desportes
966902b7a5
Add support for virtual columns on PerconaDB 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-05-19 20:06:27 +02:00
Michael Voříšek
b09bd204c9 Fix generate field SQL for MySQL virtual columns 
Fix issue #13854, based on official syntax:
column_definition: https://dev.mysql.com/doc/refman/5.7/en/create-table.html

Signed-Off-By: Michael Voříšek <mvorisek@mvorisek.cz>
 2019-05-19 14:10:52 +02:00