Commit Graph

111 Commits

Author SHA1 Message Date
William Desportes
62a17fea45
Fix #14291 - Incorrect linkage from one table's value to another table
Fixes: #14291
Pull-request: #15414

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-20 10:24:43 +02:00
Hugues Peccatte
02225781f2 Add missing PHPDoc for new $displayedData parameter
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-08-02 22:50:01 +02:00
Hugues Peccatte
20735aeff0 Fix #14291 Incorrect linkage from one table's value to another table
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-08-02 22:50:01 +02:00
Jack Cherng
b89c17c7d7
Fix PHP 7.4 accessing offset on null/bool
null['xxx'] or false['xxx'] emits a notice in PHP 7.4.

Problematic pages:

- phpMyAdmin/db_tracking.php?db=DB_NAME
- phpMyAdmin/server_privileges.php?adduser=1
- some other pages using POST method...

0e6e2297fc/UPGRADING (L25-L28)

Signed-off-by: Jack Cherng <jfcherng@gmail.com>
2019-07-27 09:14:13 +08:00
William Desportes
4bf8bfcaa1
Fix broken foreign key links
Fixes: #15225 - Using Command+Click to open in new tab does not work (Firefox/Safari)
Fixes: #14270 - Middle-click on foreign key link broken
Fixes: #14363 - Broken relational links in tables

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-12 10:43:15 +02:00
Hritik Wadhwa
937a120c1d Fix #14948 - Change password is not showing password Strength difference
Cherry-picked-from: 78eed87315
Fixed: #14948
Signed-off-by: Hritik Wadhwa <akkywadhwa@gmail.com>
2019-03-06 16:19:10 +01:00
William Desportes
99cee9e389
Fix #14635 - Git revision error
See: #14762
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-12-21 15:02:13 +01:00
William Desportes
9511484142
Fix #14775 - export to SQL format not available for tables
Fixes: #14775 - export to SQL format not available for tables
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-12-19 15:41:13 +01:00
Madhura Jayaratne
048670f1a5 Merge branch 'QA_4_8' into QA_4_8-security 2018-12-07 16:33:18 +11:00
Madhura Jayaratne
d4ed31339a
Merge pull request #257 from phpmyadmin/bug-245
Fix #245 Remove transformation plugin includes
2018-12-04 19:55:29 +11:00
Maurício Meneghini Fauth
6a1ba61e29 Remove transformation plugin includes
Tranformation plugins should be loaded by the autoloader.

Fixes https://github.com/phpmyadmin/phpmyadmin-security/issues/245

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-27 18:44:30 -02:00
Maurício Meneghini Fauth
5e8642b387 Fix DocBlocks issues
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-26 13:40:00 -02:00
Stephane Proulx
fcfe9aaa2a Change expected variable to array instead of string
Whole array of sort expressions needed to correctly build "sort by key" drop down menu

Fixes bug #14339

Signed-off-by: Stephane Proulx <stephane@m-42.com>
2018-11-25 10:13:48 -04:00
Maurício Meneghini Fauth
5109c1787e Retrieve parameters from $_POST in sql pages
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:58 -02:00
Maurício Meneghini Fauth
c1cdaac2f4 Retrieve parameters from $_POST in export
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:58 -02:00
William Desportes
93ec29933b Fix - #14382 "Visualize GIS data" icon missing
Closes: #14382
Signed-off-by: William Desportes <williamdes@wdes.fr>
(cherry picked from commit b3379d7700)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-07-04 20:42:32 -03:00
William Desportes
632309bad8 Fixes #14370
Fixes error when mysqli::fetch_array returns NULL for 'SELECT * FROM mytable WHERE 0;'

Signed-off-by: William Desportes <williamdes@wdes.fr>
(cherry picked from commit a9dce0b40e)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-13 21:36:10 -03:00
Lakshay arora
0da5857b5d Fix for issues with spatial fields (#14125)
*  Fix for issues with spatial fields

Fixes the following issues:

1.    #14068 SPATIAL fields with no unique index/autoincrement error when clicking
      This error occurs when there is no unique column to uniquely identify a tuple. I've disabled the geomtery view and made view as wkt the default view in such cases.

2.    #14121 View spatial fields as WKT doesn't work

1.    #14067 IS NULL search operator produces no WHERE SQL with spatial fields

Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

* Fix for issues with spatial fields
This commit fixes view as BINARY not working in the previous commit.
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

* Fix for issues with spatial fields

Fixes typo in previous commits.

Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
(cherry picked from commit 9231620c2d)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-12 03:54:28 -03:00
Madhura Jayaratne
e6cc4fbbbc Fix #14264 Linking for 'Distinct values' broken
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2018-05-08 07:10:06 +10:00
Madhura Jayaratne
5872167dc2 Fix #14227 Relational linking broken
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2018-04-30 00:36:03 +10:00
Maurício Meneghini Fauth
d98658187a Replace PhpMyAdmin\Relation static calls
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-25 19:32:13 -03:00
Saksham Gupta
1f70ea3834 Fixes Import Fail (#14085)
* Fixes Import Fail
Fixes: https://github.com/phpmyadmin/phpmyadmin/issues/14072

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

* Fix Import Fail

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2018-03-23 20:16:28 -03:00
Maurício Meneghini Fauth
35eb2da38a Remove @ operator from function_exists
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-01 22:36:35 -03:00
Maurício Meneghini Fauth
0889b52c36 Replace static methods with instance methods
Replace PhpMyAdmin\Sql static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-27 17:39:16 -03:00
Gabriel Caruso
6ff73257e2 Simplify returns
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
2018-01-16 10:16:56 -02:00
Maurício Meneghini Fauth
f45d4a566b Refactor PhpMyAdmin\Display\Export class
The static methods are replaced with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-01-13 23:51:16 -02:00
Maurício Meneghini Fauth
0a933ca060 Refactor exportCheckboxCheck method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-01-13 00:19:42 -02:00
Maurício Meneghini Fauth
81864e549e Use template for getHtmlForExportOptionsOutput
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-01-13 00:11:19 -02:00
Maurício Meneghini Fauth
31b7b9cc14 Use template for getHtmlForExportOptionsOutputSeparateFiles
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-01-12 17:17:09 -02:00
Maurício Meneghini Fauth
ebb22f8600 Use template for getHtmlForExportOptionsOutputRadio
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-01-12 16:44:46 -02:00
Maurício Meneghini Fauth
5b6bd82145 Use template for getHtmlForExportOptionsOutputCompression
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-01-11 18:41:57 -02:00
Maurício Meneghini Fauth
16459bf343 Use template for getHtmlForExportOptionsOutputCharset
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-01-11 15:08:46 -02:00
Maurício Meneghini Fauth
bcb67cb15f Use template for getHtmlForExportOptionsOutputFormat
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-01-10 20:47:53 -02:00
Maurício Meneghini Fauth
11c43ef980 Use template for getHtmlForExportOptionsOutputSaveDir
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-01-10 17:30:00 -02:00
Maurício Meneghini Fauth
0183003195 Use template for getHtmlForExportOptionsQuickExport
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-01-10 15:52:19 -02:00
Maurício Meneghini Fauth
083ae21f51 Use template for getHtmlForExportOptionsRows method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-01-10 15:09:48 -02:00
Maurício Meneghini Fauth
8ee32ab972 Use template for getHtmlForExportOptionsFormat
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-01-10 14:12:55 -02:00
Maurício Meneghini Fauth
b45deaeb4a Use template for getHtmlForExportOptionsFormatDropdown
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-01-10 10:45:27 -02:00
Maurício Meneghini Fauth
b093d7cadd Use template for getHtmlForExportOptionsSelection
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-01-10 01:11:30 -02:00
Maurício Meneghini Fauth
0da1a53cf4 Use template for getHtmlForExportOptionsMethod method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-01-10 00:44:00 -02:00
Maurício Meneghini Fauth
c0ea9039d4 Use template for getOptionsForExportTemplates method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-01-09 22:04:58 -02:00
Maurício Meneghini Fauth
d87245e8d4 Use template for getHtmlForExportTemplateLoading method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-01-07 18:01:46 -02:00
Maurício Meneghini Fauth
0cefaca341 Use template for getHtmlForExportOptionHeader method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-01-07 17:22:44 -02:00
Maurício Meneghini Fauth
0fa3dd7366 Use template for getHtmlForHiddenInput method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-01-07 17:11:11 -02:00
Maurício Meneghini Fauth
47ff231237 Use template for getHtmlForExportSelectOptions method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-01-07 16:34:24 -02:00
Michal Čihař
64476aada9 Merge branch 'QA_4_7' 2017-12-15 13:46:34 +01:00
Michal Čihař
a450d01546 Remove not needed variable
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-12-15 12:28:50 +01:00
Maurício Meneghini Fauth
01fd301003 Use 'elseif' keyword istead of 'else if'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-04 13:31:25 -02:00
Michal Čihař
bed6fb4ebd Avois passing extension to Util::getImage
We do not use it anyway for quite some time and this way it's less
processing to generate the img tag.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-27 14:24:42 +01:00
Maurício Meneghini Fauth
73e558337c Refactor PhpMyAdmin\Display\Import class
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-26 15:38:25 -02:00