Maurício Meneghini Fauth
3b285ff17e
Use identical operator for non-empty strings
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
05c62ad1a8
Fix some PHPStan errors
...
Fixes "Cannot access offset on array" errors.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-02 16:12:07 -03:00
Maurício Meneghini Fauth
f4582e083e
Use early exit when possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
3ae05c785d
Use short list syntax and single line arrays
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 03:32:59 -03:00
Maurício Meneghini Fauth
3baad2eb1c
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
a64393e7f5
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
Maurício Meneghini Fauth
206199105e
Remove useless return type annotations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6b7af13f8f
Reference global funcs and consts via use statement
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 00:33:24 -03:00
Maurício Meneghini Fauth
676f48349a
Reference global funcs and consts via use statement
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
42166cac37
Remove use statements within the same namespace
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 19:47:56 -03:00
Maurício Meneghini Fauth
5e0f539d2f
Fix invalid @var php doc annotations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 13:19:08 -03:00
Maurício Meneghini Fauth
f80d3e3bd4
Remove unnecessary annotations
...
@package, @subpackage and others.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf
Use one line for comments with a single line
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
c231652c67
Remove useless comments in PHP docs
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 14:38:49 -03:00
Maurício Meneghini Fauth
39f42f848b
Remove some useless docblock comments
...
Fixes docblock spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
dd06cd38f8
Defines rules for double quote usage
...
Makes sure that any use of double quotes strings are warranted.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
William Desportes
519aeadbc8
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-03 15:58:13 +01:00
William Desportes
c7f7f9c6c0
Merge branch 'QA_4_9' into QA_5_0
...
Revert: 45d46a6316
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-03 15:52:51 +01:00
William Desportes
a3d77ce84b
Fix #14184 - HTTPS/HTTP cookie separation issue (aka Failed to set session cookie. Maybe you are using HTTP instead of HTTPS)
...
Duplicate-of-pull-request: #14420
Fixes : #14184
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-10-30 00:06:12 +01:00
Maurício Meneghini Fauth
1a14b3e4d3
Remove vim modelines
...
These settings are no longer required as they are guaranteed through
other coding standard tools.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
Hugues Peccatte
0d8f6a3a93
Merge isset and unset calls
...
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-07-16 23:21:25 -03:00
William Desportes
3fc92c60e4
Merge branch 'QA_4_9'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-07-01 11:41:17 +02:00
William Desportes
b42685c63a
Fix errors when reporting errors
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-07-01 11:28:18 +02:00
Maurício Meneghini Fauth
e1f9ae00cd
Add a trailing comma in multi-line arrays
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-14 14:09:26 -03:00
Maurício Meneghini Fauth
c8f84fc748
Replace is_null with identical comparison with null
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 13:28:22 -03:00
Maurício Meneghini Fauth
7be0f6bfae
Reference class names in use statements
...
Sort use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 00:14:26 -03:00
Hugues Peccatte
9abd308837
Inject dependencies ( #15271 )
...
Inject dependencies instead of building them.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-06-01 15:13:41 -03:00
Hugues Peccatte
052e22c1a6
Use magic variables when possible
...
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-07 22:59:13 +02:00
William Desportes
c94aec8695
Fix coding standard warning and removed typehint
...
Fix 'Usage of ELSE IF is discouraged; use ELSEIF'
Removed typehint because it creates an exception because sending functions return mixed and not string
You can see this was expected on error_report.php 'if ($server_response === false) {'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-01 21:54:13 +02:00
William Desportes
0bdf3486f3
Merge branch 'QA_4_8'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-01 21:34:05 +02:00
William Desportes
07389d12aa
Fixed error reporting (current web page url, JS file name sanitization)
...
- Added tests on master branch
- Added support for js/*.js files
- Added support for slashes and dots in file paths
- Added back support for 'url' (the current webpage)
All js files where reported as 'index.php' now they are reported as their real name
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-01 21:31:11 +02:00
William Desportes
fbd89fb882
Merge branch 'QA_4_8'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-01 17:53:24 +02:00
William Desportes
4909352c88
Fix #14992 - Fixed php notices when reporting errors
...
Fixes : #14992
I reverted a minor issue introduced by a10e2b0b96 that prevented sending the stack trace to the reporting server
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-01 16:30:31 +02:00
William Desportes
40cc2dc813
Fix @var comments to match the phpdoc reference
...
See: http://docs.phpdoc.org/references/phpdoc/tags/var.html
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-01 10:54:43 +02:00
Maurício Meneghini Fauth
23c3579804
Format array declarations
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
4cee0cbc12
Adds space after not (!) and type cast
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:56:34 -02:00
Maurício Meneghini Fauth
76d8bfdafa
Merge branch 'QA_4_8'
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-12 21:04:19 -02:00
Tomas Votruba
637fe6de06
[cs] remove unused brackets, clean unused property assign
...
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
2018-11-26 17:54:40 +01:00
Tomas Votruba
bf720bad29
remove unused and fix @param, @var and @return annotation values
...
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
2018-11-24 21:47:26 +01:00
Maurício Meneghini Fauth
737ac997f9
Retrieve parameters from $_POST in error report
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:59 -02:00
Maurício Meneghini Fauth
e28de31b5d
Add some tests to ErrorReport class
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-09-20 18:56:51 -03:00
Maurício Meneghini Fauth
d4b4124a5e
Remove $GLOBALS['dbi'] from Relation class
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-08-30 19:05:09 -03:00
Maurício Meneghini Fauth
2d58411bee
Some coding style fixes
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 21:30:06 -03:00
Maurício Meneghini Fauth
244d4e8e81
Replace Template::get calls in libraries/classes
...
Uses Template::render() instead of Template::get().
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 18:18:24 -03:00
Isaac Bennetch
8a74345f7e
Fix #14350 , Uncaught TypeError with error reporting
...
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2018-06-02 19:46:02 -04:00
Maurício Meneghini Fauth
6cf8ee0831
Enable strict mode in some classes
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-15 01:03:57 -03:00
Maurício Meneghini Fauth
675be84d97
Add type declarations to ErrorReport
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-07 02:08:55 -03:00
Piyush Vijay
4304a66995
Duplicate hidden token input field issue solved ( #14211 )
...
* Duplicate hidden token input fields: #14209 issue fixed
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
* duplicate hidden input for token removed from error reporting form.
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
2018-05-03 21:47:05 -03:00
Maurício Meneghini Fauth
d98658187a
Replace PhpMyAdmin\Relation static calls
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-25 19:32:13 -03:00
Maurício Meneghini Fauth
67e65d91bf
Fix some coding style
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-09 21:54:02 -02:00