Maurício Meneghini Fauth
47f0960dce
Add return type declaration to test methods
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-07 11:31:33 -03:00
Maurício Meneghini Fauth
dfa5f92c31
Add return type declaration to fetch row methods
...
DatabaseInterface's fetchArray, fetchAssoc, fetchRow and fetchSingleRow
methods.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-29 20:32:04 -03:00
William Desportes
a300a25319
Replace assertEquals({false,true} by assert{false,true}
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-26 13:13:15 +02:00
Maurício Meneghini Fauth
3ae05c785d
Use short list syntax and single line arrays
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 03:32:59 -03:00
Maurício Meneghini Fauth
3baad2eb1c
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
9269d75fb4
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 20:22:18 -03:00
William Desportes
7e81b0b3d7
Merge callProtectedMethod and callPrivateFunction into callFunction
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 22:59:29 +02:00
William Desportes
ae575ffb14
Fix running tests in --process-isolation
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 16:21:20 +02:00
William Desportes
0964470643
Use parent::setGlobalConfig();
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 13:19:23 +02:00
William Desportes
8f7d3d1fa7
Fix test cases after backupGlobals = false
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 02:07:45 +02:00
William Desportes
a7490fcb6c
Make AbstractTestCase manage GLOBALS cleanup and config loading
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
Some minor improvements
Signed-off-by: William Desportes <williamdes@wdes.fr>
Force sql-parser to reload the new language
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 02:07:45 +02:00
William Desportes
6eaa55e805
Call parent's setUp and tearDown
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 21:31:13 +02:00
William Desportes
8ef5143901
Use AbstractTestCase on all unit tests
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 21:15:06 +02:00
Maurício Meneghini Fauth
a64393e7f5
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
Maurício Meneghini Fauth
ae0d7127e0
Extract the drop_db action from mult_submits
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-20 20:00:52 -03:00
Maurício Meneghini Fauth
0721fbbc1e
Fix Server/Status/AdvisorControllerTest tests
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-13 13:27:18 -03:00
Maurício Meneghini Fauth
e656f341ef
Redesign the server status advisor page
...
Uses an accordion instead of a table to show the issues.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-13 02:56:16 -03:00
Maurício Meneghini Fauth
1a3416da8d
Add support for Bootstrap modals
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-12 20:33:48 -03:00
Maurício Meneghini Fauth
8029ea9875
Move request handling from routes to controllers
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-12 15:00:02 -03:00
Maurício Meneghini Fauth
f5c970639c
Move response handling from routes to controllers
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-12 14:59:42 -03:00
Maurício Meneghini Fauth
206199105e
Remove useless return type annotations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
676f48349a
Reference global funcs and consts via use statement
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4
Remove unnecessary annotations
...
@package, @subpackage and others.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf
Use one line for comments with a single line
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
50bc4ab37f
Remove useless PHP docs for functions
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 13:20:01 -03:00
Maurício Meneghini Fauth
dcf87edbd1
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 03:18:59 -03:00
Maurício Meneghini Fauth
59ce2dbd67
Fix MonitorControllerTest
...
Fixes Server\Status\MonitorControllerTest when runned in isolation.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-07 22:46:27 -03:00
Maurício Meneghini Fauth
08afb43653
Remove replication.inc.php file
...
Extracts the replication.inc.php code to the ReplicationInfo class and
removes the file.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-07 14:31:46 -03:00
Maurício Meneghini Fauth
3f522e8ae2
Fix some tests when running them in isolation
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-26 21:16:30 -03:00
Maurício Meneghini Fauth
62eecc8f5d
Fix Server\Status\MonitorControllerTest tests
...
Adds missing $response->setAjax(true) calls.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-26 14:10:08 -03:00
Maurício Meneghini Fauth
39f42f848b
Remove some useless docblock comments
...
Fixes docblock spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
77518d341e
Remove unused use statements
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 21:20:58 -03:00
Maurício Meneghini Fauth
dd06cd38f8
Defines rules for double quote usage
...
Makes sure that any use of double quotes strings are warranted.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
Hugues Peccatte
3255e4ad7b
Split Util class regarding the responsabilities ( #15567 )
...
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.
There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.
* Split Util class regarding the responsabilities
* Split the buttonOrImage function
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-11-21 20:20:05 -03:00
Maurício Meneghini Fauth
8a0aa251fe
Replace some custom CSS utilities with Bootstrap equivalents
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-11-12 19:35:37 -03:00
Maurício Meneghini Fauth
e8c5ba4f80
Convert Messages to Bootstrap Alerts
...
Replaces Messages custom styles with a Bootstrap Alerts theme
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-11-12 15:28:47 -03:00
Maurício Meneghini Fauth
bad2b8eca9
Move server variables entry point to routes file
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-27 15:21:59 -03:00
Maurício Meneghini Fauth
ed6d079f25
Move server status entry point logic to routes file
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-26 14:54:26 -03:00
Maurício Meneghini Fauth
6dd961c8f3
Refactor server engines entry point
...
Moves server engines entry point logic to the routes files and moves the
request parameters to the route parameter.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-26 12:55:54 -03:00
Maurício Meneghini Fauth
9372bae319
Move server collation entry point to routes.php
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-26 12:15:29 -03:00
Maurício Meneghini Fauth
3814d88e2c
Refactor server binlog entry point
...
Moves entry point logic to the routes file.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-21 11:05:12 -03:00
Maurício Meneghini Fauth
87c1133fb1
Merge pull request #15466 from mauriciofauth/entry-points-refactor
...
Refactor the server databases entry point
2019-10-13 13:34:35 -03:00
Maurício Meneghini Fauth
441a33d1fc
Merge branch 'QA_5_0'
2019-10-05 12:10:02 -03:00
Maurício Meneghini Fauth
4bb1a2d80e
Fix missing version key on AdvisorControllerTest
...
Related to 88821f8248
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-05 12:07:04 -03:00
William Desportes
d33122867f
Merge branch 'QA_5_0' into master
2019-09-22 20:14:45 +02:00
William Desportes
bbf94a7f40
Merge branch 'QA_4_9' into QA_5_0
...
Pull-request: #15457
Closes : #15457
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-09-22 20:13:09 +02:00
Maurício Meneghini Fauth
0c99e03a1e
Refactor the server databases entry point
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-09 22:45:56 -03:00
Maurício Meneghini Fauth
1a14b3e4d3
Remove vim modelines
...
These settings are no longer required as they are guaranteed through
other coding standard tools.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
59f411639f
Use the router for the server status variables page
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-12 17:06:16 -03:00
Maurício Meneghini Fauth
31db3b7e42
Use the router for the server status processes page
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-12 14:26:06 -03:00