Commit Graph

2149 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
3bb1337e90 Refactor ServerBinlogController
Refactors PhpMyAdmin\Controllers\Server\ServerBinlogController.

- Moves request and response handling back to server_binlog.php
- Extracts and groups all HTML into server/binlog/index template

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-13 21:33:36 -02:00
Maurício Meneghini Fauth
6870da15ca Fix broken ServerDatabasesControllerTest
Related to a8a5139bd7

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-07 20:23:38 -02:00
Maurício Meneghini Fauth
845e943568 Fix some coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-30 16:22:36 -02:00
Maurício Meneghini Fauth
8e7bd8cd3f Create TransformationOverviewController
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-30 15:44:30 -02:00
Maurício Meneghini Fauth
b068a0d639 Refactor ServerCollationsController
Refactors PhpMyAdmin\Controllers\Server\ServerCollationsController.

- Moves response handling back to server_collations.php.
- Groups all HTML in templates/server/collations/index.twig.
- Improves unit tests.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-29 00:56:20 -02:00
Maurício Meneghini Fauth
32e83d9097 Refactor ServerDatabasesController
Refactors PhpMyAdmin\Controllers\Server\ServerDatabasesController.

- Renames variables and methods to camelCase format.
- Moves request and response handling back to server_databases.php.
- Groups all HTML into templates/server/databases/index.twig.
- Improves unit tests.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-26 16:29:33 -02:00
Maurício Meneghini Fauth
7eb2bbc102 Remove libraries/check_user_privileges.inc.php
Replaces with CheckUserPrivileges::getPrivileges

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-22 18:18:21 -02:00
Maurício Meneghini Fauth
938723f4d6 Fix space after not operator
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-18 19:31:50 -02:00
Maurício Meneghini Fauth
a770c71782 Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-18 19:18:53 -02:00
Maurício Meneghini Fauth
12c9fc7458 Add tests with dbase extension enabled to build matrix
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-18 18:54:17 -02:00
Maurício Meneghini Fauth
f8f8d2ae05 Extract HTML from Display\Results::_getTableNavigation
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-15 23:12:12 -02:00
Maurício Meneghini Fauth
1532675036 Fix Util::formatNumber tests
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-15 16:01:21 -02:00
Maurício Meneghini Fauth
ca66136d99 Extract HTML from Sql::getHtmlForProfilingChart
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-14 02:33:33 -02:00
Maurício Meneghini Fauth
ae20364830 Upgrade phpmyadmin/coding-standard to v1.0
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-08 01:26:26 -02:00
Maurício Meneghini Fauth
25e480666e Fix doc comments alignment
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 15:09:32 -02:00
Maurício Meneghini Fauth
23c3579804 Format array declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
4cee0cbc12 Adds space after not (!) and type cast
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:56:34 -02:00
Maurício Meneghini Fauth
999b4d14f0 Fix some coding standard errors
- Fixes array identation
- Removes empty statements

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:25:08 -02:00
Maurício Meneghini Fauth
3a7e1503ac Fix some coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-04 19:42:10 -02:00
Maurício Meneghini Fauth
38e5b12c1c Define an absolute path to use for require statements
Fixes #6167

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-22 14:37:31 -02:00
Maurício Meneghini Fauth
ceee227e10 Fix ConfigTest phpcs errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-21 18:15:36 -02:00
William Desportes
fe587e05b4
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-12-21 17:10:11 +01:00
William Desportes
3da7230faf
Merge remote-tracking branch 'williamdes/issues-14635-14762-git-dir-removed' into QA_4_8
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-12-21 16:16:16 +01:00
William Desportes
b6f38940f4
Merge pull request #14799 from williamdes/issue-13788-export-view
Fix #13788 - Exporting a view structure, no database selected error

Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-12-21 16:15:06 +01:00
William Desportes
a8148f1fa7
Add tests for #14635
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-12-21 15:35:59 +01:00
William Desportes
a6b6792cfb
Added tests for Config::checkGitRevision and Config::isGitRevision
#14253
Cherry-Picked-From: 9687dfbfd2
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-12-21 11:48:59 +01:00
William Desportes
d327674d72
Fix tests for #13788 - Exporting a view structure
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-12-21 09:46:28 +01:00
Maurício Meneghini Fauth
a04a596829
Merge pull request #14792 from mauriciofauth/bootstrap-buttons
Use Bootstrap buttons component
2018-12-21 02:01:10 -02:00
Maurício Meneghini Fauth
2edd97a62b Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-21 01:55:50 -02:00
Maurício Meneghini Fauth
ef5d7dd66b Use Bootstrap buttons component
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-21 01:01:12 -02:00
Maurício Meneghini Fauth
12f898d871 Fix issue when adding user on MySQL 8.0.11
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-19 22:23:46 -02:00
Maurício Meneghini Fauth
9eba565bf4 Remove unnecessary HTML closing tags
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-19 00:12:54 -02:00
Maurício Meneghini Fauth
129086398f Remove unnecessary superglobals declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-12 21:17:06 -02:00
Maurício Meneghini Fauth
76d8bfdafa Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-12 21:04:19 -02:00
Madhura Jayaratne
048670f1a5 Merge branch 'QA_4_8' into QA_4_8-security 2018-12-07 16:33:18 +11:00
Madhura Jayaratne
d4ed31339a
Merge pull request #257 from phpmyadmin/bug-245
Fix #245 Remove transformation plugin includes
2018-12-04 19:55:29 +11:00
William Desportes
f0b51c144f
Remove unused code in tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-29 19:15:41 +01:00
Maurício Meneghini Fauth
6a1ba61e29 Remove transformation plugin includes
Tranformation plugins should be loaded by the autoloader.

Fixes https://github.com/phpmyadmin/phpmyadmin-security/issues/245

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-27 18:44:30 -02:00
ales-bulko
0be9c13689 Fixes #14658 - Regression on multi table query (#14681)
Added functionality to generate SELECT query with JOINs of requested tables. It was mentioned that it's just a bug and it was working in previous versions, but I did not see any code fragments that would make it possible. Please, feel free to suggest any better solution if you don't like that one.

Fixes #14658

Signed-off-by: Aleš Buľko <ales.bulko@student.tuke.sk>
(cherry picked from commit 23ce7cec52)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-26 20:59:58 -02:00
ales-bulko
23ce7cec52 Fixes #14658 - Regression on multi table query (#14681)
Added functionality to generate SELECT query with JOINs of requested tables. It was mentioned that it's just a bug and it was working in previous versions, but I did not see any code fragments that would make it possible. Please, feel free to suggest any better solution if you don't like that one.

Fixes #14658

Signed-off-by: Aleš Buľko <ales.bulko@student.tuke.sk>
2018-11-26 20:34:09 -02:00
Maurício Meneghini Fauth
5e8642b387 Fix DocBlocks issues
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-26 13:40:00 -02:00
William Desportes
cc2665121d
phpstan level 2 - fixes
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-25 13:57:57 +01:00
William Desportes
ca8a424ed8
phpstan level 2 - Fix some tests
- Fix plugin tests
- Fix message tests

Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-25 13:57:56 +01:00
William Desportes
bcefdd79fa
phpstan level 2 - Fix phpdoc
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-25 13:57:55 +01:00
Maurício Meneghini Fauth
25c20dc176 Remove phpmyadmin.css.php
Loads theme.css directly

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-15 01:46:12 -02:00
Maurício Meneghini Fauth
557b34a5f2 Remove layout.inc.php and svg_gradient.php
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-15 01:46:11 -02:00
Maurício Meneghini Fauth
59eef96b97 Prepare Theme class for Sass
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-15 01:46:11 -02:00
Maurício Meneghini Fauth
d7affca556 Fix uncaught TypeError in Util::printableBitValue
Fixes #14718

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-12 21:50:42 -02:00
Maurício Meneghini Fauth
d745d1ce01 Retrieve parameters from $_POST in Table class
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:59 -02:00
Maurício Meneghini Fauth
6fd9bfb75b Retrieve parameters from $_POST in table search
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:59 -02:00