Commit Graph

95 Commits

Author SHA1 Message Date
Hugues Peccatte
fb48bff1b4 Update PHPDoc.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-26 23:21:27 +02:00
Hugues Peccatte
faba0fb75d Use 'static::' when needed.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-26 23:13:01 +02:00
Hugues Peccatte
0f80756fe6 Use pre-increment when possible.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-26 23:12:09 +02:00
Hugues Peccatte
6ccb7ff44f Use php5 syntax instead of php4 for properties declaration.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-26 22:40:10 +02:00
Madhura Jayaratne
8dcb93c631 More server level Drizzle functions removed
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-09-10 01:02:35 +10:00
Madhura Jayaratne
23518f3e1a bug #4886 Clicking on external links in advisor rules give JS error
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-05-04 10:17:59 +05:30
Madhura Jayaratne
5857fe163d Fix spacing after opening brace
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-04-28 11:05:08 +05:30
Marc Delisle
775d1dca70 Best practice: remove PHP closing tag
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-04-24 11:33:29 -04:00
Hugues Peccatte
42e0bdd47a Fix typos.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-11-02 18:32:42 +01:00
Hugues Peccatte
e17de11c74 Improve multibytes string manipulation performances.
Review SQL import process.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-10-30 17:40:09 +01:00
Ann + J.M
b1a7039ae3 Convert PMA_URL_getCommon calls to new style
Rewritten tests need validation
Signed-Off-By: Ann + J.M. <phpMyAdmin@ZweiSteinSoft.de>
2014-10-18 19:42:29 +02:00
Hugues Peccatte
49ababac08 Replace mb functions by standard string functions.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-10-04 10:09:06 +02:00
Hugues Peccatte
3de88162ff Replace PMA_String uses by mb_* calls.
Remove part of unused  variables.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-09-28 20:53:01 +02:00
Hugues Peccatte
9b77d746ab Mass modifications to use PMA_String.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-09-06 10:44:03 +02:00
Hugues Peccatte
66f82fbfac Update PHPDoc and remove useless variables and methods to fix scrutinizer errors.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-06-19 22:09:18 +02:00
Ann + J.M
ddf78c212b Re-merge b3dbec1...9207203, changes got lost on original merge from QA_4_2
Signed-off-by: Ann + J.M <phpMyAdmin@ZweiSteinSoft.de>
2014-05-26 10:39:50 +02:00
Hugues Peccatte
9dd5c4ca6e Fix typo in PHP variable.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-05-18 14:38:46 +02:00
Michal Čihař
b8a879cef2 Document when the function is called
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-10 12:09:08 +02:00
Madhura Jayaratne
d0fd5acc0f Revert 33a30ad7ae. Those funcitons are infact used.
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-05-10 12:04:36 +02:00
Madhura Jayaratne
c154b1b9c5 Explicitly stating the visibility
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-05-10 11:54:49 +02:00
Madhura Jayaratne
33a30ad7ae These functions do not seem to be used anywhere, removing...
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-05-10 11:51:03 +02:00
Michal Čihař
e47566f9fd Fix code docblocks
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-08 15:22:21 +02:00
Michal Čihař
e84e6c0305 Merge pull request #1165 from nijel/cleanup
Various code cleanups
2014-05-06 14:13:11 +02:00
Michal Čihař
9be2467109 Adjust docs to match current code
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-06 14:09:18 +02:00
Michal Čihař
5cf56a9f06 This paramterer is a string
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-06 14:07:49 +02:00
Michal Čihař
39550be909 This variable is always set to other value
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-06 13:12:25 +02:00
Marc Delisle
f46865c660 Fix coding style
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-04-11 09:34:51 -04:00
Michal Čihař
c6cc2f70b1 Merge branch 'QA_4_1' 2014-04-02 09:15:25 +02:00
Michal Čihař
b80e73979b Fixed PHP Parse error in Advisor
There is one rule which needs to pass more values to format string and
the code did not properly handle this. Now evaluating params and passing
them to vsprintf to process the format string.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-04-02 09:14:15 +02:00
Michal Čihař
f5fc2ab76b Move implode to the code rather than having it in the data
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-04-02 08:59:01 +02:00
Michal Čihař
9fbabd6202 Backport Advisor cleanups from master
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-03-14 13:24:03 +01:00
Michal Čihař
53cc186591 Fixed ob_start/eval problems in phpunit
When running in phpunit, the eval can raise exception, so treat it same
as it would be output returned by the eval. Without catching it, output
buffering gets one more level of nesting leading to occassional
timeouts in Travis-CI.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-03-14 13:05:55 +01:00
Michal Čihař
eb85831fe1 Fixed ob_start/eval problems in phpunit
When running in phpunit, the eval can raise exception, so treat it same
as it would be output returned by the eval. Without catching it, output
buffering gets one more level of nesting leading to occassional
timeouts in Travis-CI.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-03-13 13:51:40 +01:00
Michal Čihař
2f1dc89d0a Simplify translation evaluation
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-03-13 13:42:28 +01:00
Michal Čihař
6917afbb19 Remove no longer used ignoreUntil parameter of PMA_Advisor::ruleExprEvaluate
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-02-27 15:17:01 +01:00
Michal Čihař
a908df0034 Simplify formatting string in advisor
We don't need to evaluate whole printf, it's enough to evalue the
parameter.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-02-27 15:17:01 +01:00
Hugues Peccatte
ab42fd2ac9 PHPCS update.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2013-12-17 18:53:14 +01:00
Madhura Jayaratne
728d3f32a3 Doc comment improvements 2013-11-29 23:23:19 +05:30
Hugues Peccatte
464ec23ad8 Huge PHPDoc update. 2013-11-10 23:04:58 +01:00
Hugues Peccatte
2fc0ca777d Update PHPDoc. 2013-11-10 10:28:05 +01:00
Michal Čihař
0a3d1d5be8 Better names for URL generating functions 2013-08-07 10:58:17 +02:00
Michal Čihař
107a727864 Various coding style fixes 2013-07-30 13:52:40 +02:00
Michal Čihař
9e2260632e Merge remote-tracking branch 'origin/QA_4_0' 2013-07-23 11:24:22 +02:00
Michal Čihař
81dba57b6a Better injection of variables into eval'd code 2013-07-23 11:20:56 +02:00
xmujay
376e8027ea fix the UT error 2013-07-17 21:04:14 +08:00
Madhura Jayaratne
ce85ebd950 Merge branch 'master' into OOP_DBI 2013-05-24 19:06:45 +05:30
Madhura Jayaratne
650a8cdda3 Convert database interface to a class 2013-05-24 17:30:59 +05:30
Michal Čihař
9dc1282ae9 These are sentences so make them have final stop 2013-05-24 10:51:36 +02:00
Michal Čihař
e8e7c74164 Wrap some long lines 2013-05-02 10:43:30 +02:00
Michal Čihař
0f7f7bf72e Merge remote-tracking branch 'origin/QA_4_0' 2013-05-02 10:29:24 +02:00