Commit Graph

295 Commits

Author SHA1 Message Date
Hugues Peccatte
fe452a7240 Make Scrutinizer happier.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-09-06 13:56:42 +02:00
Hugues Peccatte
9b77d746ab Mass modifications to use PMA_String.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-09-06 10:44:03 +02:00
Chirayu Chiripal
a4e2472108 check null checkbox for datetime with default value null
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-09-06 13:47:06 +05:30
Chirayu Chiripal
1be86d1062 fix parameter types
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-08-07 19:20:02 +05:30
Chirayu Chiripal
11ae13f177 Improve validation on insert page
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-08-04 02:19:25 +05:30
Ashutosh Dhundhara
508f0a752b RFE#919: Multiple-column foreign key relation.
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Fix missing master column.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Fix failing test.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Fix coding styles.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Fix function doc.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Fix coding styles.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
2014-08-01 19:50:12 +05:30
Marc Delisle
119049f7b3 Remove unused parameter
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-07-14 10:32:47 -04:00
Marc Delisle
ca32396de2 Fix typos
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-07-13 07:43:17 -04:00
Chirayu Chiripal
1f324be4b1 RFE-637: Custom field handlers (input transformations)
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-07-12 01:52:32 +05:30
Chirayu Chiripal
b527dc74a1 bugfix-4415,4453,4452,4451: Complete makeover of rfe-1518
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-06-13 23:56:24 +05:30
Marc Delisle
de6ad93d24 Merge pull request #1209 from ashutoshdhundhara/rfe_1145
RFE#1145: Preview SQL instead of executing it.
2014-06-07 06:39:32 -04:00
Ashutosh Dhundhara
99b9e8d83c RFE#1145: Preview SQL instead of executing it.
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
2014-06-07 00:27:39 +05:30
Michal Čihař
01955f90a4 Correct types in documentation
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-06 13:18:13 +02:00
Michal Čihař
db42258823 Correct type for text direction and special chars
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-06 13:16:06 +02:00
Michal Čihař
8c1482816a Fix type annotations
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-06 13:11:13 +02:00
Michal Čihař
dc825e82be Correctly document parameter types
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-06 12:58:50 +02:00
Madhura Jayaratne
9455673a26 Merge branch 'QA_4_2' 2014-06-05 16:48:57 +05:30
Madhura Jayaratne
2e645ede7f bug #4436 Insert form numeric field with function drop-down list
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-06-05 16:47:41 +05:30
Hugues Peccatte
ceddfffac4 Update PHPDoc.
Add return.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-06-03 21:35:25 +02:00
Ann + J.M
ddf78c212b Re-merge b3dbec1...9207203, changes got lost on original merge from QA_4_2
Signed-off-by: Ann + J.M <phpMyAdmin@ZweiSteinSoft.de>
2014-05-26 10:39:50 +02:00
Chirayu Chiripal
85390a7169 rfe-982: Support for editing binary fields in hexadecimal
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-05-21 21:42:21 +05:30
Ann + J.M
d9bd81a2a1 Code style fixes
Signed-off-by: Ann + J.M <phpMyAdmin@ZweiSteinSoft.de>
2014-05-19 22:40:24 +02:00
Chanaka Indrajith
52bf8f03ed Fixed coding style issue in inser_edit.lib.php file, raised by scrutinizer
Signed-off-by: Chanaka Indrajith <pe.chanaka.ck@gmail.com>
2014-05-17 23:43:46 +05:30
Marc Delisle
b9b06845ff Merge commit '7f445f9' 2014-05-16 07:53:38 -04:00
Chirayu Chiripal
7f445f99e3 Bug fix #4411 Protect Binary when set to no in settings still does not allow insert binary data
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>

test case fix

Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-05-15 20:05:52 +05:30
Chirayu Chiripal
c3f2abe873 FR #1487: Browse Foreign Values should be modal dialog
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-05-14 17:30:11 +05:30
Madhura Jayaratne
9079749206 Fix coding style violations
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-05-10 13:12:03 +02:00
Marc Delisle
b288a1676a Remove dead code
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-05-09 18:12:57 +02:00
Michal Čihař
7f564b6f9a Correctly specify types in docblock
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-08 18:04:07 +02:00
Michal Čihař
6e6c513eed Fix typo in type name
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-08 18:04:07 +02:00
Marc Delisle
76d1ed64d6 Fix coding style
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-05-07 14:06:22 +02:00
Michal Čihař
a40ce0eda7 Support AES_DECRYPT as well
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-03-25 13:59:29 +01:00
Hugues Peccatte
9b1f025fb7 PHPCS updates.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-03-14 23:06:46 +01:00
Marc Delisle
50738aa639 Merge pull request #1049 from D-storm/FR-1501
Feature Request #1501 add maxlength by field with length-spec
2014-03-13 13:14:18 -04:00
Chirayu Chiripal
ef6dd51514 Feature Request #1501 add maxlength by field with length-spec
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-03-12 22:21:36 +05:30
Aditya Sastry
eca20557e2 Fixes the action panel problem when editing rows in chrome(Bug 4228)
The action panel which is a fieldset is rendered differently in chrome.
Also the rows are listed in a random fashion unlike in firefox where
they are sorted by the primary key. I fixed this problem by enclosing the
rows in a div tag with float left and clear both styles.

Signed-off-by: Aditya Sastry <ganeshaditya1@gmail.com>
2014-03-08 18:09:06 +05:30
Marc Delisle
ae163e4d67 Merge commit '2453a15' 2014-02-03 12:30:23 -05:00
Viduranga Wijesooriya
2453a15174 #1498 Add timepicker for 'TIME' type
Signed-off-by: Viduranga Wijesooriya <vpowerrc@gmail.com>
2014-02-03 09:28:20 +05:30
Michal Čihař
45c11eae77 Add missing full stops at the end of a sentence 2014-02-02 11:19:15 +01:00
Hugues Peccatte
ddf0b8d632 Minor PHPCS corrections.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-01-31 21:59:29 +01:00
Hugues Peccatte
e729237a2d Minor PHPCS corrections.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-01-31 21:45:05 +01:00
Marc Delisle
c60ad1145b Merge branch 'QA_4_1' 2014-01-31 11:50:52 -05:00
Marc Delisle
9a77d256e0 Fix incorrect patch
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-01-31 11:50:25 -05:00
Marc Delisle
2463fb01e6 Merge branch 'QA_4_1' 2014-01-31 11:38:46 -05:00
Marc Delisle
482232a4c6 Fractional seconds incorrect in displayed default value
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-01-31 11:38:02 -05:00
Marc Delisle
82a549714e Fix merge conflict
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-01-31 08:22:29 -05:00
Marc Delisle
2bca34d2f8 Fix merge conflict
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-01-31 08:10:08 -05:00
Viduranga Wijesooriya
4616eb093e bug#4257 - readded something missed
Signed-off-by: Viduranga Wijesooriya <vpowerrc@gmail.com>
2014-01-31 12:17:24 +05:30
Viduranga Wijesooriya
8cc01b38ae bug#4257 - fixed test failures
Signed-off-by: Viduranga Wijesooriya <vpowerrc@gmail.com>
2014-01-31 12:09:46 +05:30
Viduranga Wijesooriya
b93e426998 bug#4257 - fixed datetimepicker view of record edit page
Signed-off-by: Viduranga Wijesooriya <vpowerrc@gmail.com>
2014-01-31 01:52:52 +05:30
Marc Delisle
1b639952d6 Merge commit '8ee7fc8' 2014-01-30 13:24:56 -05:00
Marc Delisle
8ee7fc8a9c bug #4265 Missing datepicker icon for DATETIME(length)
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-01-30 13:23:31 -05:00
Marc Delisle
0e88efbf9b Merge branch 'QA_4_1' 2014-01-22 08:37:58 -05:00
Marc Delisle
7064e047a3 bug #4218 Chrome behavior with date fields
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-01-22 08:37:32 -05:00
Madhura Jayaratne
84e9ce4946 Spaces around . operator
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-01-08 17:26:27 +05:30
Marc Delisle
1c28058dc1 Merge branch 'QA_4_1' 2014-01-06 09:24:23 -05:00
Marc Delisle
cbaa45d340 bug #4217 Current value not highlighted when browsing foreign values
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-01-06 09:23:31 -05:00
Madhura Jayaratne
beaafa4ae5 Merge branch 'QA_4_1'
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2013-12-19 19:40:26 +05:30
Madhura Jayaratne
a7e316d799 bug #4190 Fractional seconds cause row update even if the value is not changed
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2013-12-19 19:35:55 +05:30
Hugues Peccatte
493f9c5a1a Don't use function in for loop test.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2013-12-18 21:29:34 +01:00
Marc Delisle
61feb946a5 Fix typo
Signed-off-by: Marc Delisle <marc@infomarc.info>
2013-12-14 09:02:55 -05:00
Hugues Peccatte
008b1fa8d3 Rewrite to decrease number of nested levels.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2013-12-07 22:16:16 +01:00
Madhura Jayaratne
ab9a1273ee Drizzle compatibility 2013-11-28 00:02:49 +05:30
Madhura Jayaratne
ca5494c320 Fix spacing in doc comments 2013-11-27 23:11:57 +05:30
Madhura Jayaratne
7842d5f0e0 bug #4165 unsigned integer is not used for input limit on line copy 2013-11-27 22:45:02 +05:30
Marc Delisle
1a0eff3a9c Fix typos 2013-11-12 07:16:20 -05:00
Hugues Peccatte
473d3cd4a2 PHPDoc update. 2013-11-11 18:12:46 +01:00
Hugues Peccatte
464ec23ad8 Huge PHPDoc update. 2013-11-10 23:04:58 +01:00
Marc Delisle
e321e5d6df Function name was incorrect 2013-10-19 06:31:44 -07:00
Madhura Jayaratne
20608589c3 Remove trailing white spaces 2013-10-19 14:29:05 +05:30
Marc Delisle
88da7eeba0 Fixes many coding style "line too long" 2013-10-17 05:41:51 -04:00
Dieter Adriaenssens
70d9f27213 remove trailing space 2013-09-15 12:37:39 +02:00
Marc Delisle
df21b2cebe Fix codestyle 2013-09-15 06:09:25 -04:00
Marc Delisle
90accaef3b Fix failing test 2013-09-14 12:26:14 -04:00
Marc Delisle
2dbc95d110 Fix typos 2013-09-14 11:00:38 -04:00
Marc Delisle
d4a480328b Use proper term (SQL column) 2013-09-14 10:59:38 -04:00
Spun Nakandala
17ce188db4 value tab offset error corrected 2013-09-14 19:35:37 +05:30
Spun Nakandala
e60f53599d extracted methods to insert_edit.lib.php 2013-09-14 18:40:51 +05:30
Marc Delisle
d71b354876 Merge branch 'QA_4_0' 2013-09-13 12:52:03 -04:00
Marc Delisle
4a4b22c59f bug #4091 Insert ignore option does not work 2013-09-13 12:50:25 -04:00
Dieter Adriaenssens
a329ebee4e fix multiple parameter comment issues 2013-09-09 18:19:00 +02:00
Madhura Jayaratne
b25ba604e9 Fix failing tests. Make tests run independently. 2013-08-28 07:32:32 +05:30
Madhura Jayaratne
0dbf3fc819 Revert 23dee32a29 2013-08-27 22:34:06 +05:30
Madhura Jayaratne
23dee32a29 Fix failing test 2013-08-27 22:07:23 +05:30
Madhura Jayaratne
1b681d9c80 Fix syntax error 2013-08-27 21:32:47 +05:30
Isaac Bennetch
fa87bcec06 Merge pull request #582 from kasunchathuranga/fractionalSecs
Use fractional seconds in time, datetime and timestamp
2013-08-27 06:37:30 -07:00
Marc Delisle
a3f15a34d8 Browse foreigners did not work since commit b2e1f81c0c 2013-08-26 13:26:42 -04:00
Isaac Bennetch
eddf53cc16 Merge pull request #613 from kasunchathuranga/rowEditor
Bug #1193 -- Use a text area when input of size $cfg['LimitChars'] is not enough
2013-08-24 08:49:25 -07:00
Marc Delisle
cd6e2f1e0f Fix typo 2013-08-24 08:48:26 -04:00
Marc Delisle
6d53e8a6e9 Clarification will be needed 2013-08-24 08:47:47 -04:00
Marc Delisle
85eb3fbc25 Fix merge conflict 2013-08-24 08:09:09 -04:00
Marc Delisle
8cdc448484 Other incorrect tabindex (page footer controls) 2013-08-24 08:01:24 -04:00
Michal Čihař
5c3744aa58 Merge pull request #609 from mynetx/feature/input-field-type-password-html5-required
HTML5 input field enhancements
2013-08-20 22:30:12 -07:00
ayushchd
33f4871c9c Undefined variable and testuite fixes 2013-08-21 02:21:28 +05:30
J.M
3d3416184b Use type=date, type=time for DATE and TIME fields
(cannot use for DATETIME and TIMESTAMP because of CURRENT_TIMESTAMP)
2013-08-18 15:44:17 +02:00
J.M
0a0b404321 HTML5 input min=, max= attributes for inserting/editing *int data 2013-08-18 15:44:14 +02:00
J.M
06e965db72 Fix typo in phpdoc for PMA_getHTMLinput function 2013-08-18 15:44:12 +02:00
J.M
422c6ea490 Use type=number for editing int, tinyint and longint data 2013-08-18 15:42:51 +02:00
Kasun Chathuranga
1ec6858d7e Use a text area when input of size $cfg['LimitChars'] is not enough 2013-08-17 20:27:58 +05:30
Kasun Chathuranga
7066c582c6 Remove spaces 2013-08-17 20:11:48 +05:30