Commit Graph

181 Commits

Author SHA1 Message Date
Madhura Jayaratne
071a26de7f Use the local variable
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-09-18 08:19:19 +10:00
Jason
fffcb7bc8b Add tests for TableStructureController and TableRelationController
Signed-off-by: Jason <jason.daurus@gmail.com>
2015-08-18 02:35:18 +08:00
Jason
3613f2b6bd Introduce the ResponseStub
Signed-off-by: Jason <jason.daurus@gmail.com>
2015-08-12 16:50:09 +08:00
Jason
59b11954f4 Recover tests for PMA_Table and rename sGetStatusInfo to getStatusInfo
Signed-off-by: Jason <jason.daurus@gmail.com>
2015-08-12 16:48:40 +08:00
Jason
6fd29078b6 Fix test failures
Signed-off-by: Jason <jason.daurus@gmail.com>
2015-07-23 11:46:40 +08:00
Hugues Peccatte
a1cf9a24e3 Coding style modification.
Make PHPCS happy.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-07-22 22:08:24 +02:00
Madhura Jayaratne
a281d9c70f Use spaces in place of tabs
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-07-17 14:32:55 +05:30
Atul Pratap Singh
ca61c3ace8 Achieve constructor injection usign the introduced DIC
Signed-off-by: Atul Pratap Singh <atulpratapsingh05@gmail.com>
2015-07-06 12:49:19 +05:30
Jason
d1e2c58ee4 Test & fix TableGisVisualizationController
Also fix typos in controllers.

Signed-off-by: Jason <jason.daurus@gmail.com>
2015-07-03 23:04:19 +08:00
Jason
104c68d681 Introduce Controllers for tbl related scripts
Signed-off-by: Jason <jason.daurus@gmail.com>
2015-06-24 01:55:45 +08:00
Jason
cb771052c8 Finish refactoring tbl_*.lib.php
Signed-off-by: Jason <jason.daurus@gmail.com>
2015-06-17 01:14:27 +08:00
Hugues Peccatte
37f6b992da Fix typos.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-06-14 13:50:57 +02:00
Rahul Kadyan
4d308ba364 Remove unneeded closing tags
Closing tags at the end of file are not mandatory. It is often
suggested to omit to closing tags at the end of file to prevent
unwanted effects as PHP will start output buffering if there is
any character after closing tag.

Reference: http://php.net/manual/en/language.basic-syntax.phptags.php

Signed-off-by: Rahul Kadyan <hi@znck.me>
2015-03-06 23:37:35 +05:30
Madhura Jayaratne
8403bd6c7e rfe #1235 Relation view: move to main "Structure" page
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-02-09 12:07:43 +05:30
Marc Delisle
15c13e613c Fix code execution path warning
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-11-03 13:27:29 -05:00
Madhura Jayaratne
91b21184ba Use post params directly
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-11-03 21:24:21 -08:00
Madhura Jayaratne
f65871c100 Success message for display column change. Update display column in the database only if it has changed from the original value.
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-11-03 21:03:09 -08:00
Madhura Jayaratne
15a806824f Success message for internal relations
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-11-03 20:18:09 -08:00
Madhura Jayaratne
efa06c360b Function does not handle null values even if it was documented to handle them
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-10-04 19:13:34 +05:30
Ashutosh Dhundhara
60610f9b83 Fix issues reported by Scrutinizer.
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
2014-08-17 02:20:05 +05:30
Ashutosh Dhundhara
9191c1aa4e Bug#4511: QBE fails to generate LEFT join for InnoDB foreign keys in absence of configuration storage.
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
2014-08-11 03:58:19 +05:30
Ashutosh Dhundhara
508f0a752b RFE#919: Multiple-column foreign key relation.
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Fix missing master column.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Fix failing test.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Fix coding styles.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Fix function doc.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Fix coding styles.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
2014-08-01 19:50:12 +05:30
Ann + J.M
ec1943b0ed tbl_relation.php: check if $existrel_foreign is defined before using it
Signed-off-by: Ann + J.M <phpMyAdmin@ZweiSteinSoft.de>
2014-02-03 14:16:54 +01:00
Dieter Adriaenssens
c6c3883ff4 fix coding style : indentation 2013-09-06 17:37:52 +02:00
Spun Nakandala
ae6e495458 remove global variables and use super global variables 2013-08-30 21:51:11 +05:30
Spun Nakandala
207ee1ffc3 errors corrected 2013-08-29 21:58:35 +05:30
Spun Nakandala
bf2c85c877 added method PMA_handleUpdateForForeignKey 2013-08-29 21:45:15 +05:30
Spun Nakandala
73380973be added method PMA_handleUpdatesForForeignKeys 2013-08-28 20:47:55 +05:30
Spun Nakandala
011ec24ef5 added methods PMA_handleUpdatesForInternalRelations, PMA_getQueryForInternalRelationUpdate 2013-08-28 20:00:01 +05:30
Spun Nakandala
e7cca79a19 added methods PMA_handleUpdateForDisplayField, PMA_getQueryForDisplayUpdate 2013-08-28 13:34:36 +05:30
Spun Nakandala
864d21a391 added methods PMA_sendHtmlForTableOrColumnDropdownList, PMA_sendHtmlForColumnDorpdownList, PMA_sendHtmlForTableDropdownList 2013-08-28 13:03:10 +05:30
Spun Nakandala
6a2bf642be extracted methods from tbl_relation.php to tbl_relation.lib.php for rendering html 2013-08-28 12:38:35 +05:30
Michal Čihař
0a3d1d5be8 Better names for URL generating functions 2013-08-07 10:58:17 +02:00
Michal Čihař
d1bb142e87 Remove unused param from PMA_Util::showMySQLDocu 2013-08-07 08:48:50 +02:00
Marc Delisle
6734b64056 Add hints for the new relational view dropdowns 2013-06-26 13:03:28 -04:00
Kasun Chathuranga
247e79b840 Merge branch 'master' into relView
Conflicts:
	tbl_relation.php
2013-06-25 00:27:17 +05:30
Spun Nakandala
23b7f42a16 functions in the tbl_relation.php added to a new file libraries/tbl_relation.lib.php 2013-06-24 01:31:56 +05:30
Kasun Chathuranga
05e8465324 Pass parameter values without backquotes to avoid confusions 2013-06-19 10:49:57 +05:30
Kasun Chathuranga
1e0e37c14a Improved relation view interface 2013-06-19 09:38:35 +05:30
Madhura Jayaratne
3dd99512f0 These constants are better as a part of DatabaseInterface class 2013-05-26 21:15:24 +05:30
Madhura Jayaratne
650a8cdda3 Convert database interface to a class 2013-05-24 17:30:59 +05:30
Kasun Chathuranga
556bcb9f9d PMA_DBI_num_rows --> PMA_DBI_numRows 2013-05-04 08:39:43 +05:30
Kasun Chathuranga
a242ed1ae5 PMA_DBI_fetch_row --> PMA_DBI_fetchRow 2013-05-04 08:31:22 +05:30
Kasun Chathuranga
6b1f6ae046 Merge branch 'master' into DBI_naming_cleanUp
Conflicts:
	libraries/database_interface.lib.php
	libraries/db_table_exists.lib.php
	libraries/relation.lib.php
	libraries/rte/rte_triggers.lib.php
	libraries/schema/Dia_Relation_Schema.class.php
	libraries/schema/Visio_Relation_Schema.class.php
	tbl_addfield.php
2013-05-01 00:51:15 +05:30
Kasun Chathuranga
32e6c06324 PMA_DBI_get_columns --> PMA_DBI_getColumns 2013-04-30 23:36:47 +05:30
Kasun Chathuranga
d933575811 PMA_DBI_try_query --> PMA_DBI_tryQuery 2013-04-30 23:05:18 +05:30
Michal Čihař
2fbb4cee0d Consistently include colon in strings to translate
In some languages this makes difference in translating, so it's better
to give translators full context.
2013-04-25 14:22:31 +02:00
Madhura Jayaratne
466a7645c7 PHP keywords must be lowercase 2013-04-12 21:45:02 +05:30
Madhura Jayaratne
cdb85e28cf Display the error returned by MySQL rather than the ambiguous "Error" message. 2013-03-28 18:56:37 +05:30
Madhura Jayaratne
b3db1f0d6f Change mysqlDie() to return the error message when $exit parameter is false 2013-03-28 17:34:40 +05:30