Commit Graph

620 Commits

Author SHA1 Message Date
Hugues Peccatte
3de88162ff Replace PMA_String uses by mb_* calls.
Remove part of unused  variables.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-09-28 20:53:01 +02:00
Hugues Peccatte
9b77d746ab Mass modifications to use PMA_String.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-09-06 10:44:03 +02:00
Ashutosh Dhundhara
60610f9b83 Fix issues reported by Scrutinizer.
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
2014-08-17 02:20:05 +05:30
Hugues Peccatte
50849a8757 Fix typos.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-08-10 00:41:44 +02:00
Marc Delisle
5aee521030 Merge branch 'QA_4_2' 2014-07-07 06:36:11 -04:00
Marc Delisle
ca9ad6015a Undefined variable when grid editing a foreign key column
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-07-07 06:35:30 -04:00
Atul Pratap Singh
dc7bdf48c6 Merge commit 'b756cc6'
Conflicts:
	js/makegrid.js
	js/multi_column_sort.js
2014-07-02 14:11:11 +05:30
Atul Pratap Singh
b756cc66de update js for add/remove modify columns in multi sort
Signed-off-by: Atul Pratap Singh <atulpratapsingh05@gmail.com>
2014-07-02 00:37:14 +05:30
Chanaka Indrajith
39b5f07dfb Fixed some documentation issues raised by scrutinizer
Signed-off-by: Chanaka Indrajith <pe.chanaka.ck@gmail.com>
2014-05-18 00:14:27 +05:30
Ashutosh Dhundhara
5ea6345adb Filter rows option on "Browse" table page.
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Filter rows feature on "Browse" table page.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Included table filter plugin in tbl_select.php.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
2014-03-31 17:52:48 +05:30
Aditya Sastry
a05ab9640b Multicolumn sorting feature request(1507)
This patch completely implements the feature requested and it modifies 4
existing files and adds one extra Javascript file. The existing system for
one column sorting has been refactored to be used for multicolumn sort.

Files messages.php and makegrid.js where modified to add the tool tip.

File sql.php was modified to add the import statement for the newly added JS
file.

The newly added columndelete.js is responsible for shift deleting the columns.
It gets the url of the link that was shift clicked and removes the name of the
column which we want to remove from the order by clause.

Finally, most of the crux of this feature request is implemented through
changes to the DisplayResult.class.php. 4 methods of this class have been
refactored to accomodate the required change. getsortparams() which process
the order by clause text remains the same, just the output parameters have
been turned into a array for each order by clause column. isInSort() has been
modified to check multiple order by clauses. The smart ordering feature in
to form a new function makeURL, which makes the url for multiple sorted table's
header's button's targets.

Signed-off-by: Aditya Sastry <ganeshaditya1@gmail.com>
2014-03-24 02:17:54 +05:30
Marc Delisle
effa00f209 Bug #4135 When searching, error "No database selected" 2013-10-15 15:36:13 -04:00
Madhura Jayaratne
71950aaf08 Make these long parameter lists a bit easier to read 2013-10-15 07:03:14 +05:30
Atul Pratap Singh
ec6f20fac9 Database was being set at wrong place 2013-10-15 00:08:50 +05:30
Michal ฤŒihaล™
40a0aec442 Fix typo 2013-08-07 19:53:52 +02:00
Michal ฤŒihaล™
b2e1f81c0c Use PMA_URL_getCommon for generating all params 2013-08-07 17:00:52 +02:00
Michal ฤŒihaล™
0a3d1d5be8 Better names for URL generating functions 2013-08-07 10:58:17 +02:00
Marc Delisle
76ba0b03cd No longer needed 2013-07-22 15:33:54 -04:00
Marc Delisle
e186cffe2d Clarify code path 2013-07-22 06:03:03 -04:00
Spun Nakandala
36a4ba240a corrected error display shown when browsing a table for the first time after logging 2013-07-20 21:13:50 +05:30
Spun Nakandala
d15028ead2 sorted column not remembering error corrected 2013-07-19 21:42:35 +05:30
Spun Nakandala
f31bb7a196 renamed methods to better reflect their usage. 2013-07-18 20:39:43 +05:30
Spun Nakandala
e8994364a8 added methods PMA_executeQueryAndSendResponse, PMA_sendResponse 2013-07-18 19:35:06 +05:30
Marc Delisle
55746b58ec Clarify the origin of $text_dir (text direction) global 2013-07-16 09:33:05 -04:00
Spun Nakandala
0fee81639e extracted method PMA_sendResponseForResultsReturned 2013-07-16 14:01:56 +05:30
Spun Nakandala
76de6049d6 unset variable notice corrected 2013-07-15 20:52:59 +05:30
Spun Nakandala
c60b65abd6 removed redundant parameter 2013-07-15 20:15:35 +05:30
Marc Delisle
8ce9acb65b Merge pull request #503 from scnakandala/gsoc_2013_2
Refactoring SQL executor
2013-07-14 13:05:14 -07:00
Marc Delisle
22884539af No need for this to be a global variable 2013-07-14 15:55:44 -04:00
Spun Nakandala
6c9da035ff check for CALL transferred to the sql parser 2013-07-14 21:19:28 +05:30
Spun Nakandala
116687e873 phpcs coding standard violations corrected 2013-07-14 17:29:42 +05:30
Spun Nakandala
c7feab8dc5 bookmarking error corrected 2013-07-14 17:18:55 +05:30
Spun Nakandala
3bbcd64df4 default $sql_limit_to_append transfered to the else condition. 2013-07-14 14:36:11 +05:30
Spun Nakandala
ec35836b41 print view bookmark form display error corrected 2013-07-14 12:53:13 +05:30
Spun Nakandala
e96b7d6b27 error corrected 2013-07-09 23:05:24 +05:30
Spun Nakandala
cc6da648c7 error corrected 2013-07-09 22:38:04 +05:30
Spun Nakandala
503df0a6a7 removed redundant methods 2013-07-09 22:32:02 +05:30
Spun Nakandala
4acc14051e error corrected 2013-07-09 21:35:26 +05:30
Spun Nakandala
07cd7234cf removed method PMA_getHtmlForPrintView and changed the method PMA_getHtmlForPrintViewHeader 2013-07-09 21:12:00 +05:30
Spun Nakandala
419876ee4c changed method PMA_getHtmlForProfilingChart 2013-07-09 21:03:16 +05:30
Spun Nakandala
765a3e464a changed PMA_getHtmlForBookmark function 2013-07-09 19:32:33 +05:30
Spun Nakandala
9c14ce3ee8 added method PMA_getHtmlForPrintView 2013-07-09 18:27:24 +05:30
Spun Nakandala
e5f3f7e0ac added methods PMA_getHtmlForPrintButton, PMA_getHtmlForIndexesProblems, PMA_getMessageIfMissingColumnIndex, PMA_getHtmlForPreviousUpdateQuery, PMA_getHtmlForSqlQueryResultsTable, PMA_getBookmarkCreatedMessage 2013-07-09 18:05:17 +05:30
Spun Nakandala
ebef06fa0d added method PMA_getHtmlForSqlQueryResults 2013-07-09 16:27:34 +05:30
Spun Nakandala
f2b268b137 All the requests will be ajax 2013-07-09 15:03:10 +05:30
Spun Nakandala
27859550cf added methods PMA_getHtmlForTableMaintenanceResponse, PMA_sendResponseOrGetHtmlForTableMaintenance 2013-07-09 14:17:08 +05:30
Spun Nakandala
bc055fe4b7 can be done only once 2013-07-09 11:55:41 +05:30
Spun Nakandala
4c912a6ae7 added method PMA_sendResponseForGridEdit 2013-07-09 11:29:48 +05:30
Spun Nakandala
ab0b933c44 removed dead code from PMA_sendResponseForNoResultsReturned 2013-07-05 23:10:08 +05:30
Spun Nakandala
b02a22cc24 added methods PMA_sendResponseForNoResultsReturned, PMA_sendAjaxResponseForNoResultsReturned, PMA_getMessageForNoRowsReturned, PMA_deleteTransformationInfo to the libraries/sql.lib.php 2013-07-02 19:48:20 +05:30