* Remove $GLOBALS['PMA_PHP_SELF']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Remove $GLOBALS['PMA_PHP_SELF'] from tests
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Moved cleanupPathInfo to Routing
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Remove parse_url from getRootPath
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Update baselines
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Remove invalid tests
Surely, we never expect PATH to be backslash delimited. The code is not designed to handle this and the tests for this don't make much sense.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Fix trailing slash in path
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
---------
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
The route is retrieved from the request, so it makes sense to move the
method to the Http\ServerRequest class.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
These classes were added by 6408b7179a.
However they aren't exactly the same as thead-light classes that exists
in Bootstrap 4.
Related to https://github.com/phpmyadmin/phpmyadmin/issues/17455.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
* Remove redundant conditions
They were always true. First, the variable is set to -1.
If the variable is -1, then set it to Message.
If the variable is Message then set the JSON array. All of this is
redundant.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* $sqlQuery is not used anywhere
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Enforce $selected to be an array
I can't remove it as it is a global. Previously, it was set to a POST
variable. Since we validate that the variable is set and is not null,
we can use the value from $params. If we validate that it's also an
array we can replace for loop with foreach.
There is no passing by reference, so this change should be safe.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Replace $rebuildDatabaseList with input validation
The validation message says 'No databases selected.' so I assume that
we should check that we actually got at least one entry in the list.
If that is true, then the $rebuildDatabaseList is not needed and the
condition redundant.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* drop_selected_dbs is always set and is redundant
I am not sure if this is necessary. The AJAX request sends a value of "1"
but the code doesn't really do anything with it other than checking if
it is actually set. Is there some other path possible?
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Flatten the array with a single element
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Remove redundant isset
The variable is set, so !isset === is_null. Why check for null if we can
check just for !is_array.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Update psalm-baseline.xml
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Adhere to the coding standard
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
