Commit Graph

302 Commits

Author SHA1 Message Date
Michal Čihař
298efcf139 Merge branch 'QA_4_6' 2016-04-06 10:19:37 +02:00
Michal Čihař
ec984877d8 Improve performance of database structure page
There is no need to get full list of tables twice, it's enough to do it
in the controller itself.

Fixes #12129

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-04-06 10:17:56 +02:00
Michal Čihař
d8d9ab421e Always set correct sub_part request
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-04-06 09:59:22 +02:00
Deven Bansod
3b227209a1 Make phpcs happy
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-03-22 11:50:22 +05:30
Madhura Jayaratne
2fb291bbb0 Move packages for better organization
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-11-18 12:29:00 +11:00
Hugues Peccatte
f9d582bd09 Make PHPCS happy.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-11-08 15:58:48 +01:00
Hugues Peccatte
17274d9a54 Move PMA/DI namespace to PMA\libraries\di.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-02 22:02:46 +02:00
Hugues Peccatte
5207ba43a7 Update controllers' namespace.
Move table controllers into 'table' folder.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:56:14 +02:00
Hugues Peccatte
e5e447e937 Set namespace on config classes.
Update config classes.
Add @noinspection tag.
Update documentation and script.
Set ConfigGenerator in a namespace.
Rename ConfigGenerator filename.
Remove ConfigGenerator requires.
Fix namespaces of mock objects.
Remove useless require.
Add missing 'use'.
Add missing require.
Update PHPDoc.
Fix class test typo.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:30:23 +02:00
Hugues Peccatte
7f8f34e89d Remove classes require_once.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:30:22 +02:00
Hugues Peccatte
0761fb1801 Rename classes files.
Rename classes.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:30:21 +02:00
Hugues Peccatte
f0ba28fc1d Set namespace on Advisor, Config, Console and Util classes.
Set namespace on DbQbe.
Set namespace to 'DbSearch'.
Split Advisor.class.php file.
Change Advisor namespace.
Rename DbQbe class and file.
Set namespace on DisplayResults.
Set namespace on Error.
Use namespace for ErrorHandler.
Add class autoloader.
Change ErrorHandler filename.
Remove some require.
Update Config namespace path.
Update PMA_Util to PMA\libraries\Util.
Rename Font and File classes files.
Use namespace for Footer.
Set namespace in all libraries classes.
Namespace OutputBuffering.
Export SubPartition.
Rename Partition file.
Namespace PDF.
Namespace RecentFavoriteTable.
Replace PMA_Response by Response and PMA_Message by Message.
Update uses and calls.
Fix unit tests.
Fix SqlParser autoload.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:22:52 +02:00
Hugues Peccatte
04422d972b Set namespace on config classes.
Update config classes.
Add @noinspection tag.
Update documentation and script.
Set ConfigGenerator in a namespace.
Rename ConfigGenerator filename.
Remove ConfigGenerator requires.
Fix namespaces of mock objects.
Remove useless require.
Add missing 'use'.
Add missing require.
Update PHPDoc.
Fix class test typo.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-08-30 22:16:35 +02:00
Hugues Peccatte
f54bbe7a70 Remove classes require_once.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-08-29 23:02:10 +02:00
Hugues Peccatte
567a628947 Rename classes files.
Rename classes.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-08-29 22:29:21 +02:00
Hugues Peccatte
2fe6ff4655 Set namespace on Advisor, Config, Console and Util classes.
Set namespace on DbQbe.
Set namespace to 'DbSearch'.
Split Advisor.class.php file.
Change Advisor namespace.
Rename DbQbe class and file.
Set namespace on DisplayResults.
Set namespace on Error.
Use namespace for ErrorHandler.
Add class autoloader.
Change ErrorHandler filename.
Remove some require.
Update Config namespace path.
Update PMA_Util to PMA\libraries\Util.
Rename Font and File classes files.
Use namespace for Footer.
Set namespace in all libraries classes.
Namespace OutputBuffering.
Export SubPartition.
Rename Partition file.
Namespace PDF.
Namespace RecentFavoriteTable.
Replace PMA_Response by Response and PMA_Message by Message.
Update uses and calls.
Fix unit tests.
Fix SqlParser autoload.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-08-29 16:27:21 +02:00
Marc Delisle
bb01f9b2b7 Refactor db_info.inc.php
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-08-25 11:16:59 -04:00
Jason
3613f2b6bd Introduce the ResponseStub
Signed-off-by: Jason <jason.daurus@gmail.com>
2015-08-12 16:50:09 +08:00
Madhura Jayaratne
a599b61534 Create separate controllers from table and database structure pages
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-08-10 15:09:17 +05:30
Jason
3fe4f63f62 Remove structure.lib.php and display_structure.inc.php
Signed-off-by: Jason <jason.daurus@gmail.com>
2015-07-31 13:55:52 +08:00
Jason
1c28e6a8ab Creating StructureController
Signed-off-by: Jason <jason.daurus@gmail.com>
2015-07-31 01:04:30 +08:00
Jason
2a5a91e9f3 Refactor PMA_getHtmlForShowCreate, PMA_tableHeader, PMA_getHtmlForMoveColumnsDialog, PMA_getHtmlForStructureTableRow
Signed-off-by: Jason <jason.daurus@gmail.com>
2015-07-26 21:09:07 +08:00
Jason
8ac6c15b32 Refactor PMA_getHtmlForDisplayTableStats and move template calls into db_structure.php and tbl_structure.php
Signed-off-by: Jason <jason.daurus@gmail.com>
2015-07-26 21:05:47 +08:00
Jason
6636153071 Resolve conflicts from upstream
Signed-off-by: Jason <jason.daurus@gmail.com>
2015-07-23 11:29:53 +08:00
Hugues Peccatte
37f6b992da Fix typos.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-06-14 13:50:57 +02:00
Isaac Bennetch
af658d27ee Merge pull request #1708 from devenbansod/rfe701_using_css
RFE#701 - Print View using CSS - Rewrite
2015-06-01 14:50:04 -04:00
Deven Bansod
7c37657cc5 RFE#1676 : Actually a Bug
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2015-06-01 13:34:15 +05:30
Deven Bansod
aeae86d7cc RFE#701 - Print View using CSS - Rewrite
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2015-06-01 03:57:50 +05:30
Nisarg Jhaveri
d19104fa72 Fix bug#4925
- Don't show page-settings when not needed in db_structure

Signed-off-by: Nisarg Jhaveri <nisargjhaveri@gmail.com>
2015-05-26 14:53:17 +05:30
Nisarg Jhaveri
e115adb533 Page-related settings, rfe#1559
Signed-off-by: Nisarg Jhaveri <nisargjhaveri@gmail.com>
2015-05-18 20:38:07 +05:30
Marc Delisle
3d86f1ae41 Merge branch 'QA_4_4' 2015-04-28 08:41:48 -04:00
Marc Delisle
4a5541f2a0 bug: Table overhead stats: missing space before the unit
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-04-28 08:41:05 -04:00
Marc Delisle
4eccae5290 Merge pull request #1547 from znck/master
Remove unneeded closing tags
2015-03-26 07:56:45 -04:00
Chirayu Chiripal
72b07cae86 Fix some more coding style
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2015-03-07 20:37:17 +05:30
Rahul Kadyan
4d308ba364 Remove unneeded closing tags
Closing tags at the end of file are not mandatory. It is often
suggested to omit to closing tags at the end of file to prevent
unwanted effects as PHP will start output buffering if there is
any character after closing tag.

Reference: http://php.net/manual/en/language.basic-syntax.phptags.php

Signed-off-by: Rahul Kadyan <hi@znck.me>
2015-03-06 23:37:35 +05:30
Hugues Peccatte
cb94250d08 Minor coding style modifications.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-11-10 16:50:18 +01:00
Hugues Peccatte
7a60853443 Replace $replication_info by a global variable.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-11-09 19:14:26 +01:00
Hugues Peccatte
49836e6e6f Use $replication_info everywhere, instead of $server_* variables.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-11-09 16:30:07 +01:00
Ann + J.M
a540e6ba87 More fixes to new PMA_URL_getCommon style
Signed-off-by: Ann + J.M <phpMyAdmin@ZweiSteinSoft.de>
2014-10-18 19:42:39 +02:00
Ann + J.M
b1a7039ae3 Convert PMA_URL_getCommon calls to new style
Rewritten tests need validation
Signed-Off-By: Ann + J.M. <phpMyAdmin@ZweiSteinSoft.de>
2014-10-18 19:42:29 +02:00
Wojciech Mleczek
998f969d5e rfe1547 - Wrap message with message box
Signed-off-by: Chanaka Dharmarathna <pe.chanaka.ck@gmail.com>
2014-10-17 01:16:21 +05:30
Marc Delisle
6fd724cb24 Refactor duplicate code
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-09-25 11:57:28 -04:00
Ashutosh Dhundhara
60610f9b83 Fix issues reported by Scrutinizer.
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
2014-08-17 02:20:05 +05:30
Madhura Jayaratne
22e3a0d19f Fix some coding style violations
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-05-18 14:44:10 +05:30
Ashutosh Dhundhara
0a5d1ad757 RFE: #1448 Allow clicking an approximate row count to get a correct one.
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
2014-05-10 20:23:15 +05:30
Michal Čihař
7cccfc1b6d Remove unused variable
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-06 19:38:27 +02:00
Marc Delisle
c61475ee24 Refactoring: PMA_addRemoveFavoriteTables()
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-05-06 12:29:04 -04:00
Chanaka Indrajith
e936515a0a Remove empty else block
Signed-off-by: Chanaka Indrajith <pe.chanaka.ck@gmail.com>
2014-04-21 20:38:54 +05:30
Chanaka Indrajith
a7e8820820 Limited the access to _tables variable in PMA_RecentFavoriteTable class
Signed-off-by: Chanaka Indrajith <pe.chanaka.ck@gmail.com>
2014-04-20 22:47:14 +05:30
Marc Delisle
3e3d7db2c0 Merge pull request #1129 from WhaleWatching/navigation
Improve Navigation
2014-04-08 10:15:57 -04:00