Commit Graph

34 Commits

Author SHA1 Message Date
Kartik Kathuria
9054d1f673 Added LOCK=NONE
Signed-off-by: Kartik Kathuria <kathuriakartik0@gmail.com>
2020-01-17 20:42:09 +05:30
William Desportes
e17a787acc
Merge #15420 - Add #15312 Implement ONLINE transaction (ALGORITHM=INPLACE)
Pull-request: #15420
Fixes: #15312
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-17 14:05:42 +01:00
Kartik Kathuria
a439082dba Change ALTER ONLINE to ALGORITHM=INPLACE at required position
Signed-off-by: Kartik Kathuria <kathuriakartik0@gmail.com>
2020-01-17 13:36:06 +05:30
Maurício Meneghini Fauth
10395f9ea8 Create Table\AddFieldController controller
Moves the add field entry point logic the controller and removes the
entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-23 20:51:40 -03:00
Maurício Meneghini Fauth
f6a17433a2 Use null coalesce operator when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 20:16:58 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
Hugues Peccatte
3255e4ad7b Split Util class regarding the responsabilities (#15567)
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.

There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.

* Split Util class regarding the responsabilities
* Split the buttonOrImage function

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-11-21 20:20:05 -03:00
William Desportes
acba81e091
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-10 21:06:25 +01:00
William Desportes
df0543694c
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-10 20:54:15 +01:00
William Desportes
8aad190ae0
Fix #14951 - Moving Columns with DEFAULT NULL doesn't work on MariaDB 10.2+
Ref: 98a7479174
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-09 23:08:54 +01:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
William Desportes
f428277bad
Merge branch 'QA_4_9' into 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-20 11:08:28 +02:00
Maurício Meneghini Fauth
a862694bc8 Use the router for the table create page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-15 22:37:51 -03:00
Maurício Meneghini Fauth
3c6c087c40 Use the router for the table addfield page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-15 21:18:40 -03:00
Maurício Meneghini Fauth
69d279d68c Use the router for the table replace page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-15 20:30:43 -03:00
William Desportes
990323e8db
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-15 23:51:19 +02:00
William Desportes
cfa1be5916
Fix #14950 - Left database overview "add column" triggers error
Fixes: #14950
Fixes: #15430
Pull-request: #15431

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-15 20:42:52 +02:00
Shen Chen
e9ca69dcb7 [Bugfix] update if statement to make sure the field is not empty.
Signed-off-by: Shen Chen <schen89@live.com>
2019-08-13 23:59:32 -04:00
Hugues Peccatte
3243a9158d Remove use of unexisting variables
Remove useless variables

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-11 00:34:57 +02:00
Maurício Meneghini Fauth
23c3579804 Format array declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
4cee0cbc12 Adds space after not (!) and type cast
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:56:34 -02:00
Maurício Meneghini Fauth
76d8bfdafa Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-12 21:04:19 -02:00
Tomas Votruba
637fe6de06 [cs] remove unused brackets, clean unused property assign
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
2018-11-26 17:54:40 +01:00
Tomas Votruba
bf720bad29 remove unused and fix @param, @var and @return annotation values
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
2018-11-24 21:47:26 +01:00
Madhura Jayaratne
d6e04ca09b Fix #249 CSRF to CREATE TABLE query
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2018-11-10 20:48:58 -02:00
Maurício Meneghini Fauth
6cf8ee0831 Enable strict mode in some classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-15 01:03:57 -03:00
Maurício Meneghini Fauth
5070d3c64d Add type declarations to CreateAddField
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-28 05:13:36 -03:00
Maurício Meneghini Fauth
79ab4f4a50 Use DI for DatabaseInterface instance
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-15 15:04:37 -02:00
Maurício Meneghini Fauth
a1e088d5f8 Fix coding style issues
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-15 14:12:43 -02:00
Maurício Meneghini Fauth
dc04987a68 Replace static methods with instance methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-15 12:31:04 -02:00
Michal Čihař
c26375a066 Merge branch 'QA_4_7' 2017-11-27 18:26:06 +01:00
Maurício Meneghini Fauth
b041c13a0c Fix CreateAddField methods visibility
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-10 09:06:41 -02:00
Maurício Meneghini Fauth
1d4125f15c Add array type declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-24 23:49:59 -03:00
Maurício Meneghini Fauth
360d0ad62e Refactor create_addfield functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-11 22:43:07 -03:00