Commit Graph

21201 Commits

Author SHA1 Message Date
William Desportes
4499e75901
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-16 02:49:36 +02:00
William Desportes
34acbcdc38
Fix calls to fetchRow using two parameters but function has only one parameter
None of our fetchRow methods have more than one parameter

Thank you Psalm for catching this !

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-16 02:28:03 +02:00
William Desportes
587536b766
Remove non used variables
Running: composer run psalm -- --alter --issues=UnusedVariable
And removing the false positives I reported upstream

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-16 02:13:27 +02:00
William Desportes
ef84f770d1
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-16 00:02:00 +02:00
William Desportes
a36dd1126b
Fix #17006 - Disable the URL limit for the MariaDB analyser feature
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-15 21:32:56 +02:00
Maurício Meneghini Fauth
f2871b89fd
Merge branch 'QA_5_1' 2021-07-15 13:09:21 -03:00
Maurício Meneghini Fauth
2535853fcc
Fix duplicate quote in navigation nodes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-15 13:07:31 -03:00
William Desportes
fcd0a2393a
Fix coding standard issues
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-15 02:44:05 +02:00
William Desportes
5f8bfbbae1
Ref #16939 - Remove not used params from Header::getJsParams
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-15 02:43:41 +02:00
William Desportes
8f77a9f29d
Ref #15247 - Remove defined('TESTSUITE') from ReplaceController and remove an exit
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-15 02:39:14 +02:00
William Desportes
d1ed1a10d4
Ref #15247 - Remove defined('TESTSUITE') from Util::date
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-15 02:39:14 +02:00
William Desportes
45d6336b90
Ref #15247 - Remove defined('TESTSUITE') from Relation::setHistory
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-15 02:39:13 +02:00
William Desportes
43a29b7a5a
Ref #15247 - Remove defined('TESTSUITE') from Session::secure
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-15 02:39:13 +02:00
William Desportes
c830c1e93a
Merge branch 'origin/QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-15 02:34:29 +02:00
William Desportes
4fcbd2ae45
Merge #17013 - Fix #16985 - Fixing the case-sensitive issue of innodb_file_format
Fixes: #16985
Pull-request: #17013

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-15 02:25:12 +02:00
William Desportes
f724f648e1
Fix #16976 - Wrong link when a table is moved from a database to another
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-15 02:13:03 +02:00
William Desportes
f490ee8867
Fix a coding standard mistake
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-15 00:49:21 +02:00
Fawzi E. Abdulfattah
751d415216 fixing the case-sensitive issue of innodb_file_format
Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
2021-07-15 00:02:57 +02:00
S. B. Hunter
a0410aa77d
Replace REQUEST to POST in Routines.php (#16904)
Signed-off-by: Akihiro Asahara <akihiro.asahara@gmail.com>

Co-authored-by: Akihiro Asahara <akihiro.asahara@gmail.com>
2021-07-14 14:24:08 -03:00
William Desportes
8500a6c5a1
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-13 22:43:26 +02:00
William Desportes
7c17889d78
Ref #17010 - Fix #16994 - Be sure to always pass a string value
Pull-request: #17010
Ref: #16994

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-13 22:29:47 +02:00
William Desportes
a552b15efc
Merge #17008 - Fix #16975 - Fixing the null issue with datetime in insert mode
Pull-request: #17008
Fixes: #16975

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-13 22:18:24 +02:00
William Desportes
d84e3cde28
Fix psalm detected errors
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-13 21:45:34 +02:00
William Desportes
10fca6b03f
Ref #16945 - Fix a coding standard mistake
Pull-request: #16945

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-13 21:39:51 +02:00
Fawzi E. Abdulfattah
5005c38d9d Fixing the issue when assigning database to user with '_'
Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
2021-07-13 21:25:15 +02:00
William Desportes
c82f87b749
Merge #16945 - Add suport for Mroonga engine
Pull-request: #16945

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-13 20:54:48 +02:00
William Desportes
0b81db92fa
Merge #16767 - Fix #16138 - Ignore the length of the integer types and show a warning
Fixes: #16138
Pull-request: #16767

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-13 20:52:57 +02:00
Maurício Meneghini Fauth
e4ed0cc8be
Replace fopen, fwrite and fclose with file_put_contents
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-13 11:51:57 -03:00
William Desportes
e6e496f67b
Code improvements for Html/Generator::getSupportedDatatypes
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-13 15:52:13 +02:00
Fawzi E. Abdulfattah
9954c47577
Fix #16138 - ignore the length of integer types, and show a warning
Fixes: #16138

Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
2021-07-13 15:42:57 +02:00
Fawzi E. Abdulfattah
90793f6e88 Fixing the null issue with datetime in insert mode
Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
2021-07-13 03:03:49 +02:00
William Desportes
05f134c91b
Documentation and typo fixes
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-11 22:05:30 +02:00
Josep Sanz
de1c381f23
Add suport to the Mroonga engine: with this patch you can see the size
of the Mroonga's tables

Apply an optimization suggested

In reality, I have applied 2 optimizations, the first consists in filter by the object type as @williamdes suggested to me and the second is because we don't need to store all data of each mroonga object, we only need the name of the object that is used to compare with the tables names, thanks @williamdes by the optimization idea

Signed-off-by: Josep Sanz <josep.sanz@saltos.org>
2021-07-11 21:22:06 +02:00
Maurício Meneghini Fauth
340759e444
Replace scripts/fix-po-twig with a Console command
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-11 13:58:25 -03:00
Maurício Meneghini Fauth
ed45c51d59
Add Stringable interface to classes with __toString
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-10 14:11:51 -03:00
Maurício Meneghini Fauth
1835ebb4fc
Replace mb_strpos !== false with str_contains
See: https://wiki.php.net/rfc/str_contains#case-insensitivity_and_multibyte_strings

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-10 13:43:40 -03:00
Maurício Meneghini Fauth
6ae07c96fb
Replace strpos !== false with str_contains
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-09 22:30:42 -03:00
Maurício Meneghini Fauth
bcdb7e40fb
Replace strncmp === 0 with str_starts_with
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-09 19:14:30 -03:00
Maurício Meneghini Fauth
355f6d9d20
Remove PhpMyAdmin\Config::enableBc method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-09 13:59:04 -03:00
Maurício Meneghini Fauth
e8c28d1883
Remove some globals from Config::enableBc method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-08 19:49:26 -03:00
Liviu-Mihail Concioiu
7c0d82d363
Fix table width on Insert page
Pull-request: #16986

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2021-07-08 15:40:38 +02:00
William Desportes
4f74043e1a
Merge branch 'origin/QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-08 15:39:08 +02:00
William Desportes
65d262c170
Fix #17001 - adjust function signatures and handle no table name case
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-08 14:52:18 +02:00
Maurício Meneghini Fauth
519533a202
Merge branch 'QA_5_1'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-07 14:19:49 -03:00
Maurício Meneghini Fauth
028b1d5b40
Fix configuration error handler registration
Registers Config::fatalErrorHandler as a shutdown function before
constructing the Config class.

Introduced by 33477fe024.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-07 14:14:52 -03:00
Maurício Meneghini Fauth
262cbe45b9
Move some Core methods to Common class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-06 16:52:54 -03:00
Maurício Meneghini Fauth
a0d91ec153
Move common.inc.php to classes/Common.php
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-06 14:00:44 -03:00
Maurício Meneghini Fauth
dc37d436cc
Extract common.inc.php logic to Common::run method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-06 13:48:11 -03:00
Maurício Meneghini Fauth
17f4e09a6b
Extract some common checks from common.inc.php
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-06 13:27:14 -03:00
Maurício Meneghini Fauth
1a2d7804d2
Add ServerRequest::getParsedBodyParam method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-06 12:24:02 -03:00