gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
122,008 Commits 12 Branches 481 Tags 2.4 GiB
4499e75901
Commit Graph

433 Commits

Author SHA1 Message Date
William Desportes
4499e75901
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-16 02:49:36 +02:00
William Desportes
34acbcdc38
Fix calls to fetchRow using two parameters but function has only one parameter 
None of our fetchRow methods have more than one parameter

Thank you Psalm for catching this !

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-16 02:28:03 +02:00
Maurício Meneghini Fauth
1835ebb4fc
Replace mb_strpos !== false with str_contains 
See: https://wiki.php.net/rfc/str_contains#case-insensitivity_and_multibyte_strings

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-10 13:43:40 -03:00
Maurício Meneghini Fauth
6ae07c96fb
Replace strpos !== false with str_contains 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-09 22:30:42 -03:00
Maurício Meneghini Fauth
8e4d6229a9
Fix some errors found by Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-06 00:37:27 -03:00
Maurício Meneghini Fauth
9adaa912e1
Rename Response class to ResponseRenderer 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-30 12:35:22 -03:00
Maurício Meneghini Fauth
b1c936a0f3
Fix some errors found by Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-25 15:03:05 -03:00
William Desportes
0a1f083990
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-06-23 20:36:21 +02:00
William Desportes
8e148afc9e
Fix two possible PHP errors with int data 
Actually, one poped out on tests after #16935
Ref: #14936

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-06-22 00:29:32 +02:00
William Desportes
6549c11361
Fix #16896 - Distinct URLs are broken on nullable text fields 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-06-22 00:29:32 +02:00
Maurício Meneghini Fauth
b3f088e9fd
Extract HTML from Results::getTableHeadersForColumns 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-17 22:40:53 -03:00
Maurício Meneghini Fauth
c3b453aa3a
Extract the HTML from sorted table header 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-17 17:09:18 -03:00
Maurício Meneghini Fauth
fa12894e5f
Add unit tests for Display\Results::setConfigParamsForDisplayTable 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-16 20:26:24 -03:00
Maurício Meneghini Fauth
39c0908af5
Remove display/results/sort_by_key template 
Merges it with the `display/results/table` template.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-16 13:03:32 -03:00
William Desportes
300e835edb
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-06-16 01:10:11 +02:00
Maurício Meneghini Fauth
8f992a4fbf
Fix some errors found by PHPStan and Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-15 18:49:37 -03:00
William Desportes
f09ead5e07
Fix code using relative path 
if (chdir('/tmp') === false) {
    die('Could not change dir');
}

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-06-15 22:24:30 +02:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors 
Related to 62f142c9fa.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-03 16:50:33 -03:00
Maurício Meneghini Fauth
9928882de3
Fix some errors found by Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-05-23 00:24:59 -03:00
William Desportes
87526f2b5d
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-05-03 01:50:55 +02:00
William Desportes
27a9986a1b
Revert fix for #16783 to Fix #16874 and Fix #16802 and fix back #16783 
This reverts 176ff6a99c
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-05-03 01:44:26 +02:00
Maurício Meneghini Fauth
8d0c2a339c
Move both operands of an assignment to the same line 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-04-20 22:35:21 -03:00
William Desportes
592dedb8c2
Revert 4c5592e632 for old PHP compat 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-20 21:22:31 +02:00
Maurício Meneghini Fauth
90778eecf7
Upgrade phpmyadmin/coding-standard to 3.0.0 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-04-19 02:20:46 -03:00
William Desportes
856145297f
Merge branch 'origin/QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-13 17:46:06 +02:00
William Desportes
721e927f12
Fix #16791 - Undefined index table_schema and "DESCRIBE FILES" broken links 
Reverts: ca0244f06b because the code was guessing what the parent had already found but the code did not fine the same results between the parent and the child.

Now passing the result from the parent to the child will remove one guessing

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-12 22:26:51 +02:00
William Desportes
927689554e
Remove impossible code since #1208 
Ref: 26dc919e68

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-12 21:50:51 +02:00
William Desportes
b5cde44e17
Document special schema links array format 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-12 21:48:26 +02:00
William Desportes
85afe9a14f
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-12 19:01:36 +02:00
Maurício Meneghini Fauth
ca0244f06b
Fix a type error when getting the special schema links 
Reproduced by running "DESCRIBE `FILES`;" inside the information_schema
database.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-04-09 14:02:39 -03:00
William Desportes
9f0fc40cdb
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-02 13:40:28 +02:00
William Desportes
26cca2133d
Add ChangeLog entries for #16604, 700108ba90, 8597ec6814, ec04f6ebac 
Entry for #16604 already exists

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-01 18:58:22 +02:00
William Desportes
176ff6a99c
Fix #16783 - Incorrect linkage from one table's value to another table (varchar FK) 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-31 19:30:39 +02:00
William Desportes
c70552651f
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-31 17:02:17 +02:00
William Desportes
4d2c311b59
Fix some phpdoc blocks on Results class 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-31 16:27:29 +02:00
Maurício Meneghini Fauth
3d539b78e6
Merge branch 'QA_5_1' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-27 16:07:09 -03:00
Maurício Meneghini Fauth
b8bb6e06e3
Extract the HTML from Display\Results::getRowData 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-22 23:19:31 -03:00
Maurício Meneghini Fauth
035e29a80b
Extract GIS related methods from Util class 
Creates the PhpMyAdmin\Utils\Gis class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-22 15:03:39 -03:00
William Desportes
8992ef095f
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-14 11:54:03 +01:00
William Desportes
c62e27d650
Fix #16724 - Remove old unstable code to make column order work 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-13 01:19:58 +01:00
Maurício Meneghini Fauth
d3ce67593d
Fix some errors found by PHPStan 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-09 17:22:03 -03:00
Maurício Meneghini Fauth
2c2127b369
Rename PMA_Theme global variable to theme 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-07 15:15:27 -03:00
Maurício Meneghini Fauth
86b6fb5817
Rename variables to use the camel case format 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-06 01:29:46 -03:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 14:18:35 -03:00
Maurício Meneghini Fauth
47dca2cd45
Fix Selenium\Table\BrowseTest::testSortRecords test 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-02-28 22:43:19 -03:00
William Desportes
c5155ecae9
Refactor field flags to use an object an not strpos 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-02-24 23:56:33 +01:00
William Desportes
76839932fe
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-02-17 01:57:36 +01:00
William Desportes
39e524c2cf
Fix #16614 - Correct the dataseek offset on MySQLI extension 
Fixes #16614
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-02-17 01:48:24 +01:00
Maurício Meneghini Fauth
1e5fbd57fc
Create Twig\AssetExtension and image Twig function 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-01-28 16:09:17 -03:00