Commit Graph

192 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
ce18740be4
Remove passing null to Relation's constructor
Related to d296860a67.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-17 12:09:14 -03:00
Maurício Meneghini Fauth
857a9d3337
Remove unnecessary @var annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-11-18 12:15:30 -03:00
Maurício Meneghini Fauth
220ed30ef8
Remove printview.css theme files
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-10-31 17:35:55 -03:00
Maurício Meneghini Fauth
67e96cf40c
Get default config values from Config\Settings classes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-30 12:04:47 -03:00
Maurício Meneghini Fauth
3e0856c77b
Remove useless string concatenations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-27 21:40:22 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
9f3510d11a
Add bool return type where possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-14 20:11:51 -03:00
Maurício Meneghini Fauth
6ae07c96fb
Replace strpos !== false with str_contains
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-09 22:30:42 -03:00
Maurício Meneghini Fauth
355f6d9d20
Remove PhpMyAdmin\Config::enableBc method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-09 13:59:04 -03:00
Maurício Meneghini Fauth
e8c28d1883
Remove some globals from Config::enableBc method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-08 19:49:26 -03:00
Maurício Meneghini Fauth
a0d91ec153
Move common.inc.php to classes/Common.php
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-06 14:00:44 -03:00
Maurício Meneghini Fauth
8e4d6229a9
Fix some errors found by Psalm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-06 00:37:27 -03:00
Maurício Meneghini Fauth
76aabc9826
Remove PMA_MINIMUM_COMMON constant
Replaces it with the `$isMinimumCommon` global variable.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-07-02 01:29:07 -03:00
William Desportes
c7ee30a3fe
Document more static vars
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-06-17 15:22:37 +02:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors
Related to 62f142c9fa.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-03 16:50:33 -03:00
William Desportes
db01d6a9da
Remove some else conditions by using early exits or moving code
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-29 01:18:39 +02:00
Maurício Meneghini Fauth
8d0c2a339c
Move both operands of an assignment to the same line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-20 22:35:21 -03:00
William Desportes
a8f63ca458
Add PHP typehints to the filter config closure
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-20 22:41:58 +02:00
William Desportes
6d0e4b546e
Revert 8767499594 "Avoid using ARRAY_FILTER_USE_KEY" for HHVM compat
This reverts commit 8767499594

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-20 21:27:13 +02:00
fliespl
ef6fb5e3bc drop nocache & server query string param from theme.css stylesheet
Signed-off-by: Arkadiusz Rzadkowolski <a.rzadkowolski@gmail.com>
2021-03-20 22:48:07 +01:00
Maurício Meneghini Fauth
33d711215d
Remove the PMA_VERSION constant
Uses the PhpMyAdmin\Version::VERSION constant instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-08 22:22:55 -03:00
Maurício Meneghini Fauth
2c2127b369
Rename PMA_Theme global variable to theme
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-07 15:15:27 -03:00
William Desportes
819c9433d3
Drop unused PMA_THEME_VERSION and PMA_THEME_GENERATION
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-05 21:30:51 +01:00
William Desportes
b5263d44c8
Replace PMA_MAJOR_VERSION by Version::SERIES
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-05 21:22:42 +01:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 14:18:35 -03:00
Maurício Meneghini Fauth
92965c6945
Add the PhpMyAdmin\Version class generator
Creates the PhpMyAdmin\Command\SetVersionCommand class.

Usage: ./scripts/console set-version 5.1.0-dev

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-02-22 00:18:24 +01:00
William Desportes
f28fbe06e4
Improve the release script for versionning
Signed-off-by: William Desportes <williamdes@wdes.fr>

Improve the version handling

Signed-off-by: William Desportes <williamdes@wdes.fr>

Simplify the version handling

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-22 00:18:24 +01:00
Isaac Bennetch
952f9797b5 Prepare for 5.1.0-rc2
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2021-02-09 14:28:02 -05:00
Saksham Gupta
a2626d5ec0 Fixes: https://github.com/phpmyadmin/phpmyadmin/issues/16544
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2021-01-21 17:20:05 +05:30
Isaac Bennetch
6c842cb904 Prepare for 5.1.0-rc1
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2020-12-17 22:14:25 -05:00
William Desportes
35cdaf4356
Fix #16512 - Add some code securities when the themes folder does not exist
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-12-07 15:02:06 +01:00
William Desportes
5abcae9255
Fixed some typos in the code base
I used code spell checker and did all the libraries/classes/*.php files one by one.
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-11-01 22:46:01 +01:00
William Desportes
e7feedd28f
Merge #16386 - Fixes #16316 - Support Cookie SameSite=Strict
Fixes: #16316
Pull-request: #16386

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-11-01 22:13:22 +01:00
Rajat Jain
8e5d4d4708 Use of SameSite=Strict
Signed-off-by: Rajat Jain <rajatjain.ix@gmail.com>

Update Config.php

Polyfilled

version fixes

Signed-off-by: Rajat Jain <rajatjain.ix@gmail.com>

Update libraries/classes/Config.php

Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

phpcs fixes

samesite made as configuration directive

bugfix, sets sameSite as global configuration directive

CodeReviewed

Changed config.rst

IETF RFC link aded

Version added

Trailing whitespace fixed.

RFC hyperlink added

trailing whitespace
2020-10-17 16:36:31 +05:30
Maurício Meneghini Fauth
ac9bccf67d Replace $GLOBALS['dbi'] with global $dbi
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-11 09:24:21 -03:00
Maurício Meneghini Fauth
e66be179ca Use camel case naming for class members
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-05 10:37:07 -03:00
Maurício Meneghini Fauth
f2e49a92c6 Fix some type errors detected by PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-30 19:23:01 -03:00
William Desportes
bcf21c4081
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-28 18:12:30 +02:00
William Desportes
0e344b6a50
Fix #16256 - Warning: error_reporting() has been disabled for security reasons on php 7.x
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-25 19:49:52 +02:00
Maurício Meneghini Fauth
500bea5643 Extract method for get LoginCookieValidity from cache
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-24 23:13:51 -03:00
Maurício Meneghini Fauth
2358b9c4f9 Fix missing property type hints
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-22 21:42:22 -03:00
Maurício Meneghini Fauth
3b285ff17e Use identical operator for non-empty strings
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-10 18:06:29 -03:00
Gemorroj
ecdf1ccb32
Avoid check permissions on windows 2020-06-07 00:50:26 +03:00
charliewindred
ca3c5e17b0 Remove underscore prefix from method names
Removed underscore from method names for PSR-12 compliance.
Signed-off-by: charliewindred <charliewindred@gmail.com>
2020-06-02 16:44:16 +01:00
William Desportes
802797c176
Move getConnectionParams to Config class
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 16:01:38 +02:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
82c2964bb8 Remove useless elses
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 22:27:45 -03:00
Maurício Meneghini Fauth
2d02a15de3 Add static to closures that don't use $this
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 18:30:57 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00