Commit Graph

72 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
9f3510d11a
Add bool return type where possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-14 20:11:51 -03:00
William Desportes
8d19bef81d
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-22 23:19:15 +02:00
William Desportes
38c263359e
Ref #17084 - comment the code and add a new test case
And fix the modified test

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-20 02:30:02 +02:00
Craig McNeill
af835bc52c Fix ErrorHandler sliceErrors not returning errors
Signed-off-by: Craig McNeill <craig@mmddata.ca>
2021-08-18 14:40:52 -04:00
Maurício Meneghini Fauth
04d3c83559
Fix some errors found by PHPStan/Psalm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-05 16:09:08 -03:00
Maurício Meneghini Fauth
9adaa912e1
Rename Response class to ResponseRenderer
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-30 12:35:22 -03:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors
Related to 62f142c9fa.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-03 16:50:33 -03:00
Maurício Meneghini Fauth
9c32a55def
Turn errors into exceptions when in development env
Changes error messages into ErrorException when using
`$cfg['environment'] = 'development';`.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-03 11:53:54 -03:00
Maurício Meneghini Fauth
3d539b78e6
Merge branch 'QA_5_1'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-27 16:07:09 -03:00
Maurício Meneghini Fauth
6b0a10d8ca
Rename the error_handler global to use camel case
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-16 12:11:51 -03:00
William Desportes
8992ef095f
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-14 11:54:03 +01:00
William Desportes
c4c32c374d
Fix #16729 - fix silencing code for PHP >= 8.0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-12 19:23:03 +01:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 14:18:35 -03:00
Maurício Meneghini Fauth
4f574e53c3
Replace error report jquery-ui's dialog with a modal
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-12 17:28:23 -03:00
Maurício Meneghini Fauth
00151b5f1c
Remove some custom CSS utilities
Uses Bootstrap equivalents instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-22 13:18:58 -03:00
Maurício Meneghini Fauth
db3da81056 Remove some useless comments
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-13 19:56:56 -03:00
Maurício Meneghini Fauth
e66be179ca Use camel case naming for class members
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-05 10:37:07 -03:00
William Desportes
bcf21c4081
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-28 18:12:30 +02:00
William Desportes
0e344b6a50
Fix #16256 - Warning: error_reporting() has been disabled for security reasons on php 7.x
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-25 19:49:52 +02:00
Maurício Meneghini Fauth
3f01cd8c13 Remove Message::display method
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-20 19:43:46 -03:00
Maurício Meneghini Fauth
3b285ff17e Use identical operator for non-empty strings
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
bd979dd1ff Remove useless elseif with if
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 22:53:44 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
William Desportes
0cbba2aef2
Add some properties typehints
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-02 01:41:59 +02:00
Isaac Bennetch
6efdd77483 Merge branch 'QA_5_0' 2020-03-20 22:50:16 -04:00
Isaac Bennetch
0d4c7c66a5 Merge branch 'QA_4_9' into QA_5_0 2020-03-20 22:01:14 -04:00
Maurício Meneghini Fauth
13e6a01838 Add support for E_USER_DEPRECATED in the error handler
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-17 19:37:31 -03:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824 Use short versions of scalar types in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
6b7af13f8f Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 00:33:24 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
42166cac37 Remove use statements within the same namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 19:47:56 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
c231652c67 Remove useless comments in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 14:38:49 -03:00
Maurício Meneghini Fauth
8ec4209002 Fix some coding standard issues
- Inverts yoda comparisons
- Removes parentheses from return
- Removes useless ternary operators
- Adds paretheses to new instances
- Adds trailing array comma

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 00:38:34 -03:00
Maurício Meneghini Fauth
285907991e Add coding standard rules for whitespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 22:29:54 -03:00
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-13 21:15:00 -03:00
William Desportes
4534c4b519
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-24 17:44:27 +01:00
William Desportes
3ebcf62e78
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-24 17:43:06 +01:00
William Desportes
8f470aaa2f
Fix #15592 - Hide user warning, errors and notices
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-24 17:14:22 +01:00
William Desportes
2f0fff5fa1
Fix #15592 - Add all errors since we do not have access to error_reporting function
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-24 17:07:04 +01:00
William Desportes
5f5dc024a1
Fix #15592 - Warning: error_reporting() has been disabled for security reasons
Fixes: #15592
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-24 15:54:02 +01:00
Maurício Meneghini Fauth
4fabc68f95 Move error report entry point logic to routes file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-11-06 22:32:41 -03:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
a2308ee965 Extract HTML from login form
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-21 21:10:47 -03:00
Maurício Meneghini Fauth
084f366cca Use the router for error report entry point
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-19 20:43:18 -03:00