Maurício Meneghini Fauth
9d12039264
Fix ProcessesControllerTest
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-25 21:05:32 -03:00
Maurício Meneghini Fauth
2074be7eab
Create Server\Status\VariablesController
...
Extracts server_status_variables.php and Server\Status\Variables logic
to the controller.
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-25 19:02:54 -03:00
Maurício Meneghini Fauth
e149a6188f
Create Server\Status\QueriesController
...
Extracts server_status_queries.php and Server\Status\Queries logic to
the controller.
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-25 00:53:57 -03:00
Maurício Meneghini Fauth
92cc67fbf7
Replace assertContains() with assertStringContainsString()
...
Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.
Using assertNotContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringNotContainsString() or assertStringNotContainsStringIgnoringCase() instead.
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-24 16:32:28 -03:00
Maurício Meneghini Fauth
c485c311aa
Create Server\Status\ProcessesController
...
Extracts server_status_processes.php and Server\Status\Processes logic
to controller.
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-21 23:25:30 -03:00
Maurício Meneghini Fauth
12ae5553a6
Create Server\Status\MonitorController
...
Moves server_status_monitor.php logic to controller
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-21 02:23:23 -03:00
Maurício Meneghini Fauth
c9a31450fa
Create server status abstract controller
...
Create PhpMyAdmin\Controllers\Server\Status\Controller abstract
controller.
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-19 17:13:48 -03:00
Maurício Meneghini Fauth
5368c151b4
Create Server\Status\StatusController
...
- Extracts Server\Status and server_status.php logic to controller
- Extracts HTML to server/status/status/index template
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-18 15:59:59 -03:00
Maurício Meneghini Fauth
4bf6ad1952
Create Server\Status\AdvisorController
...
- Moves PhpMyAdmin\Server\Status\Advisor and server_status_advisor.php
logic to the controller.
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-17 16:03:09 -03:00
Maurício Meneghini Fauth
02a9fd371c
Refactor Server\VariablesController
...
- Moves request and response handling to server_variables.php
- Extracts and groups all HTML in server/variables/index template
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-17 13:01:10 -03:00
Maurício Meneghini Fauth
20cccfd53b
Refactor Server\PluginsController
...
- Moves response handling to server_plugins.php
- Renames server/plugins/main to server/plugins/index
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-16 15:05:05 -02:00
Maurício Meneghini Fauth
d6dfb3eed6
Refactor Server\EnginesController
...
- Moves request and response handling back to server_engines.php
- Rename templates
- Refactor tests
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-15 20:35:00 -02:00
Maurício Meneghini Fauth
c29d4005b4
Rename ServerVariablesController to VariablesController
...
Renames PhpMyAdmin\Controllers\Server\ServerVariablesController to
PhpMyAdmin\Controllers\Server\VariablesController.
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-14 13:42:04 -02:00
Maurício Meneghini Fauth
798f76fdb0
Rename ServerPluginsController to PluginsController
...
Renames PhpMyAdmin\Controllers\Server\ServerPluginsController to
PhpMyAdmin\Controllers\Server\PluginsController.
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-14 13:26:28 -02:00
Maurício Meneghini Fauth
b51e6eebc0
Rename ServerEnginesController to EnginesController
...
Renames PhpMyAdmin\Controllers\Server\ServerEnginesController to
PhpMyAdmin\Controllers\Server\EnginesController.
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-13 22:34:28 -02:00
Maurício Meneghini Fauth
b80403b304
Rename ServerDatabasesController to DatabasesController
...
Renames PhpMyAdmin\Controllers\Server\ServerDatabasesController to PhpMyAdmin\Controllers\Server\DatabasesController.
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-13 22:20:14 -02:00
Maurício Meneghini Fauth
7235eb055d
Rename ServerCollationsController to CollationsController
...
Renames PhpMyAdmin\Controllers\Server\ServerCollationsController to
PhpMyAdmin\Controllers\Server\CollationsController.
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-13 22:14:27 -02:00
Maurício Meneghini Fauth
58c1805925
Rename ServerBinlogController to BinlogController
...
Renames PhpMyAdmin\Controllers\Server\ServerBinlogController to
PhpMyAdmin\Controllers\Server\BinlogController.
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-13 22:08:34 -02:00
Maurício Meneghini Fauth
3bb1337e90
Refactor ServerBinlogController
...
Refactors PhpMyAdmin\Controllers\Server\ServerBinlogController.
- Moves request and response handling back to server_binlog.php
- Extracts and groups all HTML into server/binlog/index template
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-13 21:33:36 -02:00
Maurício Meneghini Fauth
6870da15ca
Fix broken ServerDatabasesControllerTest
...
Related to a8a5139bd7
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-07 20:23:38 -02:00
Maurício Meneghini Fauth
845e943568
Fix some coding standard errors
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-30 16:22:36 -02:00
Maurício Meneghini Fauth
b068a0d639
Refactor ServerCollationsController
...
Refactors PhpMyAdmin\Controllers\Server\ServerCollationsController.
- Moves response handling back to server_collations.php.
- Groups all HTML in templates/server/collations/index.twig.
- Improves unit tests.
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-29 00:56:20 -02:00
Maurício Meneghini Fauth
32e83d9097
Refactor ServerDatabasesController
...
Refactors PhpMyAdmin\Controllers\Server\ServerDatabasesController.
- Renames variables and methods to camelCase format.
- Moves request and response handling back to server_databases.php.
- Groups all HTML into templates/server/databases/index.twig.
- Improves unit tests.
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-26 16:29:33 -02:00
Maurício Meneghini Fauth
23c3579804
Format array declarations
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
999b4d14f0
Fix some coding standard errors
...
- Fixes array identation
- Removes empty statements
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:25:08 -02:00
Maurício Meneghini Fauth
76d8bfdafa
Merge branch 'QA_4_8'
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-12 21:04:19 -02:00
Maurício Meneghini Fauth
34972f0132
Retrieve parameters from $_POST in server binlog
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:59 -02:00
Gaurav Punjabi
04c6c33b56
Fixed testGetColumnOrder in ServerDatabasesControllerTest
...
The testCase for getColumnOrder was failing since the default collation was not updated in it
Signed-off-by: Gaurav Punjabi <gaurav.punjabi6@icloud.com>
2018-11-02 02:14:21 +05:30
William Desportes
3dce65d913
phpstan level 1 ( #14472 )
...
* level +1
* Install sami/sami globaly to avoid dependency clash
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-08-18 14:37:41 -03:00
William Desportes
38009efb65
Add support for MySQL/MariaDB variables documentation
...
- Uses preferential mode MySQL docs for MySQL users and MariaDB docs for MariaDB users
- Unit tests now use data that only exists for tests
- Added package williamdes/mariadb-mysql-kbs
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-07-26 17:12:35 +02:00
Leonardo Strozzi
7dc44b2ea9
Fix tests for server_engine
...
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
2018-06-29 22:27:37 -03:00
Leonardo Strozzi
15ae8d7fe5
Refactor server_databases templates
...
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
2018-06-29 16:36:36 -03:00
William Desportes
e816e45c18
phpstan level 0 ( #14405 )
...
* Fix phpdoc @return
- Fixed @return typehint
Signed-off-by: William Desportes <williamdes@wdes.fr>
* Fix incorrect case on function calls
Signed-off-by: William Desportes <williamdes@wdes.fr>
* Type hint + typo fix
Signed-off-by: William Desportes <williamdes@wdes.fr>
* Fixes
- @return fix
- @var fix
- Class names
- Throws fix
- test/classes/Plugins/Export/ExportSqlTest.php any() invoked with 1 parameter, 0 required
- libraries/classes/Controllers/Table/TableStructureController.php Array has 2 duplicate keys with value 'columns_list'
- Call parent constructor libraries/classes/Error.php
Signed-off-by: William Desportes <williamdes@wdes.fr>
* Update config
Signed-off-by: William Desportes <williamdes@wdes.fr>
* Access to an undefined property
- Access to an undefined property PhpMyAdmin\Plugins\Schema\Pdf\PdfRelationSchema::$diagram_row
- Access to an undefined property PhpMyAdmin\Plugins\Schema\Pdf\Pdf::$cMargin
- Undefined properties
Signed-off-by: William Desportes <williamdes@wdes.fr>
* Update config
Signed-off-by: William Desportes <williamdes@wdes.fr>
* Fix bootstrap-phpstan
Signed-off-by: William Desportes <williamdes@wdes.fr>
* Fix typos and phpstan config
Fixes : #14399
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-06-25 20:34:46 -03:00
Maurício Meneghini Fauth
2d58411bee
Some coding style fixes
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 21:30:06 -03:00
Maurício Meneghini Fauth
2005cca77f
Fix methods and properties visibility issues
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 21:02:26 -03:00
Maurício Meneghini Fauth
285e38e931
Fix some PSR-2 coding standard errors
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96
Use short array syntax instead of long array syntax
...
Replaces array() with [].
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
dc8c92bfd8
Enable strict mode in test files
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-16 04:36:04 -03:00
Maurício Meneghini Fauth
20e4c86815
Fix ServerPluginsControllerTest dependencies
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-20 17:48:25 -02:00
Maurício Meneghini Fauth
40d68b6c56
Fix ServerEnginesControllerTest dependencies
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-20 17:34:22 -02:00
Maurício Meneghini Fauth
5f61e46306
Fix ServerDatabasesControllerTest dependencies
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-20 17:27:20 -02:00
Maurício Meneghini Fauth
29f03d1138
Fix ServerCollationsControllerTest dependencies
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-20 17:27:20 -02:00
Maurício Meneghini Fauth
fc993f5b7e
Fix ServerBinlogControllerTest global dependencies
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-20 16:55:12 -02:00
Michal Čihař
bed6fb4ebd
Avois passing extension to Util::getImage
...
We do not use it anyway for quite some time and this way it's less
processing to generate the img tag.
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-27 14:24:42 +01:00
Maurício Meneghini Fauth
452b624dc4
Move dependencies to outside of abstract controllers
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-04 12:41:57 -02:00
Maurício Meneghini Fauth
ff626c8b16
Fix wrong property value in ServerDatabasesControllerTest
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-03 12:29:57 -02:00
Maurício Meneghini Fauth
2ae2b8b54e
Use template for server databases table
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-03 11:31:01 -02:00
Michal Čihař
2bb01ef0a7
Share code for row filtering
...
Make it generic so that it works in most cases and fixes does not have
to be implemented multiple times.
Issue #13517
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-30 11:25:51 +01:00
Michal Čihař
4fe87fb592
Remove usage of $GLOBALS['controllink']
...
This is now stored internally inside DatabaseInterface instance.
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-25 10:21:18 +02:00
Scrutinizer Auto-Fixer
40f56c0a95
Remove not needed use statements
...
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-23 18:49:37 +02:00