Maurício Meneghini Fauth
4471b1bced
Remove the MaxFileSize HTML generator
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-01 16:03:15 -03:00
Maurício Meneghini Fauth
d612215aab
Remove dropdown field generator
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-30 01:59:03 -03:00
Maurício Meneghini Fauth
db642ab19e
Extract HTML from Index:getHtmlFromIndexes
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-29 23:43:18 -03:00
Maurício Meneghini Fauth
eb2804540f
Extract HTML from Index::getHtmlForDisplayIndexes
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-29 16:09:50 -03:00
Maurício Meneghini Fauth
a7e8b0f67a
Extract HTML from row formats dropdown
...
Removes usage of DropDown::generate() in table operations page.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-27 20:23:40 -03:00
Maurício Meneghini Fauth
558226d78e
Extract HTML from StorageEngine::getHtmlSelect()
...
Renames the method to StorageEngine::getArray().
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-27 19:31:35 -03:00
Maurício Meneghini Fauth
5a54330ee0
Extract HTML from ListAbstract::getHtmlOptions()
...
Renames the method to ListAbstract::getList().
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-27 17:14:49 -03:00
William Desportes
191a0a06ec
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-03-24 22:53:35 +01:00
Isaac Bennetch
095cb4d5a2
Fix phpcs test errors
...
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2020-03-22 23:08:22 -04:00
Isaac Bennetch
6efdd77483
Merge branch 'QA_5_0'
2020-03-20 22:50:16 -04:00
Isaac Bennetch
0d4c7c66a5
Merge branch 'QA_4_9' into QA_5_0
2020-03-20 22:01:14 -04:00
Maurício Meneghini Fauth
fbcce9c121
Extract method for edit row action
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-10 13:35:46 -03:00
Maurício Meneghini Fauth
65233b574c
Extract method for export row action
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-10 13:35:46 -03:00
Maurício Meneghini Fauth
82db7444c3
Extract db_table_exists.inc.php to DbTableExists class
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-02 17:01:26 -03:00
Maurício Meneghini Fauth
c8c2e9d793
Refactor tbl_columns_definition_form.inc.php
...
Extracts the tbl_columns_definition_form.inc.php logic to the
PhpMyAdmin\Table\ColumnsDefinition::displayForm static method.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-17 02:55:20 -03:00
William Desportes
01cd7dc33b
Some code improvements suggested by Scrutinizer
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-14 22:23:16 +01:00
William Desportes
517222ff59
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-13 00:07:11 +01:00
William Desportes
0b2937dd6a
Fix #15781 - Illegal string offset error on structure page of 'information_schema'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-12 23:11:41 +01:00
Maurício Meneghini Fauth
30b5fc46d2
Extract HTML from table operations page
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-24 20:00:13 -03:00
William Desportes
b736f0a79f
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-24 22:00:16 +01:00
William Desportes
36e4cf8f88
Fix after pull-request #15846 - add support for unsigned ints
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-24 21:24:53 +01:00
William Desportes
afce79c4bd
Merge #15846 - Fix #13326 - added Integer Validations on Search page
...
Fixes : #13326
Pull-request: #15846
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-24 21:11:54 +01:00
Manthan Surkar
e92e51d42d
Added: Integer Validations on Search page
...
Signed-off-by: Manthan Surkar <manthan.surkar@gmail.com>
2020-01-25 01:21:19 +05:30
Maurício Meneghini Fauth
206199105e
Remove useless return type annotations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824
Use short versions of scalar types in PHP docs
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
6b7af13f8f
Reference global funcs and consts via use statement
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 00:33:24 -03:00
Maurício Meneghini Fauth
676f48349a
Reference global funcs and consts via use statement
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4
Remove unnecessary annotations
...
@package, @subpackage and others.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf
Use one line for comments with a single line
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
c231652c67
Remove useless comments in PHP docs
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 14:38:49 -03:00
Maurício Meneghini Fauth
50bc4ab37f
Remove useless PHP docs for functions
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 13:20:01 -03:00
Maurício Meneghini Fauth
dcf87edbd1
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 03:18:59 -03:00
Maurício Meneghini Fauth
8ec4209002
Fix some coding standard issues
...
- Inverts yoda comparisons
- Removes parentheses from return
- Removes useless ternary operators
- Adds paretheses to new instances
- Adds trailing array comma
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 00:38:34 -03:00
Maurício Meneghini Fauth
3c22f5e7b2
Add conding standard rule for useless method overrides
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 22:56:23 -03:00
Maurício Meneghini Fauth
285907991e
Add coding standard rules for whitespace
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 22:29:54 -03:00
William Desportes
ae0577ab1e
Merge #15820 - Fix #15797 - Relation view broken
...
Fixes : #15797
Pull-request: #15820
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-19 15:43:59 +01:00
Jayati Shrivastava
5a03410cfa
fixes url.
...
fixes #15797
Signed-off-by: Jayati Shrivastava <gaurijove@gmail.com>
2020-01-19 20:06:03 +05:30
William Desportes
fd036d7f4a
Merge #15808 - Fix #15312 - added LOCK=NONE to ALGORITHM=INPLACE
...
Fixes : #15312
Pull-request: #15808
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-19 13:53:25 +01:00
Maurício Meneghini Fauth
a8acd7a42c
Use Util::backquote in getDataRowAction
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-18 22:13:03 -03:00
Maurício Meneghini Fauth
77d5b1d8d8
Remove extract functions
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-17 19:44:00 -03:00
Kartik Kathuria
9054d1f673
Added LOCK=NONE
...
Signed-off-by: Kartik Kathuria <kathuriakartik0@gmail.com>
2020-01-17 20:42:09 +05:30
Kartik Kathuria
a439082dba
Change ALTER ONLINE to ALGORITHM=INPLACE at required position
...
Signed-off-by: Kartik Kathuria <kathuriakartik0@gmail.com>
2020-01-17 13:36:06 +05:30
Maurício Meneghini Fauth
c5481acebf
Merge branch 'QA_5_0'
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-14 18:54:02 -03:00
Jayati Shrivastava
f14d675308
revert change introduced by pr #15718 and fix #15718
...
Signed-off-by: Jayati Shrivastava <gaurijove@gmail.com>
2020-01-12 18:46:23 +01:00
Maurício Meneghini Fauth
d0f28cef30
Refactor table pages common code
...
Extracts tbl_common.inc.php code to the Common::table() method and
removes the include file.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-07 22:49:24 -03:00
Maurício Meneghini Fauth
385e7f86c0
Refactor database pages common code
...
Extracts db_common.inc.php code to the Common::database() method and
removes the include file.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-07 22:49:24 -03:00
Maurício Meneghini Fauth
a1bcb9f0f3
Refactor server pages common code
...
Extracts server_common.inc.php code to the Common::server() method and
removes the include file.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-07 22:49:24 -03:00
Maurício Meneghini Fauth
96ee3b8ab0
Remove the table structure entry point file
...
Directly calls the controller instead of including the file.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-06 23:15:26 -03:00
Maurício Meneghini Fauth
7837ab81f2
Remove the table sql entry point file
...
Directly calls the controller instead of including the file.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-06 23:15:26 -03:00
Maurício Meneghini Fauth
634c9f38e9
Remove the table replace entry point file
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-06 23:15:26 -03:00