Maurício Meneghini Fauth
5178f76f95
Move fieldset CSS style to the .pma-fieldset class
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-28 19:46:40 -03:00
Maurício Meneghini Fauth
ac4bfaebe7
Remove some custom CSS utilities
...
Uses Bootstrap equivalents.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-26 20:05:03 -03:00
William Desportes
fb5d6159af
Fix Doctum reported phpdoc errors
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-12-18 22:01:51 +01:00
William Desportes
70320f256b
Fix a "PHP Fatal error: Uncaught TypeError: rawurlencode" using sakila database
...
NOTICE: PHP message: PHP Fatal error: Uncaught TypeError: rawurlencode(): Argument #1 ($string) must be of type string, int given in libraries/classes/Database/Designer/Common.php:141
Stack trace:
#0 libraries/classes/Database/Designer/Common.php(141): rawurlencode(1)
#1 libraries/classes/Controllers/Database/DesignerController.php(203): PhpMyAdmin\Database\Designer\Common->getScriptContr(Array)
#2 libraries/classes/Routing.php(92): PhpMyAdmin\Controllers\Database\DesignerController->index(Array)
#3 index.php(18): PhpMyAdmin\Routing::callControllerForRoute('/database/desig...', Object(FastRoute\Dispatcher\GroupCountBased), Object(Symfony\Component\DependencyInjection\ContainerBuilder))
#4 {main}
thrown in libraries/classes/Database/Designer/Common.p...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-12-07 01:20:53 +01:00
Maurício Meneghini Fauth
c698be7a70
Use Bootstrap's table for db triggers page
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-30 23:04:49 -03:00
Maurício Meneghini Fauth
5bad0f74af
Use Bootstrap's table for db routines page
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-30 23:04:48 -03:00
Maurício Meneghini Fauth
d23be36126
Fix some errors found by PHPStan and Psalm
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-26 15:20:44 -03:00
Maurício Meneghini Fauth
2f5f118ce5
Merge pull request #16486 from mauriciofauth/table-css
...
Add support for Bootstrap tables
2020-11-16 21:09:58 -03:00
Maurício Meneghini Fauth
c64b77abe1
Move HTML's table CSS to the pma-table class
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-16 16:36:16 -03:00
William Desportes
ed0c44a621
Update files to follow new coding standard rules
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-11-16 19:36:52 +01:00
Maurício Meneghini Fauth
0a4b10ba5e
Remove toggle button generator
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-14 13:17:03 -03:00
Maurício Meneghini Fauth
a83ec78ebf
Make DatabaseInterface::isUserType method private
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-24 00:40:03 -03:00
Maurício Meneghini Fauth
db3da81056
Remove some useless comments
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-13 19:56:56 -03:00
Maurício Meneghini Fauth
ac9bccf67d
Replace $GLOBALS['dbi'] with global $dbi
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-11 09:24:21 -03:00
Maurício Meneghini Fauth
e66be179ca
Use camel case naming for class members
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-05 10:37:07 -03:00
Maurício Meneghini Fauth
bb32ba6d9c
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-04 12:31:43 -03:00
Maurício Meneghini Fauth
c447bac98d
Move Routines::main to the controller
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-02 23:13:31 -03:00
Maurício Meneghini Fauth
f2e49a92c6
Fix some type errors detected by PHPStan
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-30 19:23:01 -03:00
Maurício Meneghini Fauth
ea163ffcae
Move CentralColumns to the Database namespace
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-30 10:14:22 -03:00
Rajat Jain
13aae49714
Added search in Routines.
...
Signed-off-by: Rajat Jain <rajatjain.ix@gmail.com>
2020-09-24 22:13:24 +05:30
Maurício Meneghini Fauth
c57dda7315
Use DI for Sql class constructor
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-05 15:31:39 -03:00
Maurício Meneghini Fauth
ceac762e09
Remove pmaThemePath and pmaThemeImage PHP globals
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-02 10:57:57 -03:00
Maurício Meneghini Fauth
7936909dbd
Move Operations::getMaintenanceActions to the view
...
Uses Table\MaintenanceController to handle the maintenance actions in
the table operations page.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-28 15:25:14 -03:00
Maurício Meneghini Fauth
c112bfd6d6
Create a new page for Check Table
...
Instead of only showing the query results.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-27 14:22:22 -03:00
Maurício Meneghini Fauth
65b79af29e
Refactor Plugins::getPlugins method
...
Replaces parameters with explicit methods.
- Plugins::getExport
- Plugins::getImport
- Plugins::getSchema
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-19 01:40:27 -03:00
William Desportes
ae86b0aa67
Fixes #16278 - Remove underscore prefix from property names of Qbe class
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-08-06 15:25:21 +02:00
Maurício Meneghini Fauth
2358b9c4f9
Fix missing property type hints
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-22 21:42:22 -03:00
Maurício Meneghini Fauth
3f01cd8c13
Remove Message::display method
...
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258 .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-20 19:43:46 -03:00
Maurício Meneghini Fauth
5afb266763
Merge branch 'QA_5_0'
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-15 19:49:29 -03:00
Maurício Meneghini Fauth
59b71dc299
Fix type errors when using saved searches
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-15 19:29:55 -03:00
William Desportes
d1462e92cb
Fix PhpMyAdmin\Database\Designer\Common::saveDisplayField return type
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-15 22:26:29 +02:00
Maurício Meneghini Fauth
918b1f38c6
Change return type of Sql::executeQueryAndSendQueryResponse
...
Remove Response::addHTML call.
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258 .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-12 15:22:57 -03:00
Maurício Meneghini Fauth
3b285ff17e
Use identical operator for non-empty strings
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
e81146e4b3
Remove useless return annotations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-07 10:30:27 -03:00
Maurício Meneghini Fauth
05c62ad1a8
Fix some PHPStan errors
...
Fixes "Cannot access offset on array" errors.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-02 16:12:07 -03:00
William Desportes
5d933e03b9
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-07 23:40:25 +02:00
William Desportes
1eb7c00c1c
Fix #16157 - relations of tables having spaces or special chars where not showing in the Designer
...
We where comparing encoded strings with non encoded ones, that could not work.
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-07 23:29:37 +02:00
William Desportes
4820175b8a
Fix php error when browsing the designer
...
The condition was not right, shorten to check only table
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-03 16:03:04 +02:00
charliewindred
ca3c5e17b0
Remove underscore prefix from method names
...
Removed underscore from method names for PSR-12 compliance.
Signed-off-by: charliewindred <charliewindred@gmail.com>
2020-06-02 16:44:16 +01:00
William Desportes
7e9d2ae4f9
Move more SQL queries into Query\Generator
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 02:16:02 +02:00
Maurício Meneghini Fauth
58eee2e371
Use early exit when possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 21:46:12 -03:00
Maurício Meneghini Fauth
f4582e083e
Use early exit when possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
bd979dd1ff
Remove useless elseif with if
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 22:53:44 -03:00
Maurício Meneghini Fauth
82c2964bb8
Remove useless elses
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 22:27:45 -03:00
Maurício Meneghini Fauth
3ae05c785d
Use short list syntax and single line arrays
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 03:32:59 -03:00
Maurício Meneghini Fauth
3baad2eb1c
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
9269d75fb4
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 20:22:18 -03:00
Maurício Meneghini Fauth
80a45fa0ae
Break too long lines
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-16 18:08:20 -03:00
William Desportes
1cc7f78012
Split part of the logic of getQueryFromRequest into processFunctionSpecificParameters
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-16 14:39:00 +02:00
William Desportes
f2d349df40
Split part of the logic of getQueryFromRequest into processParamsAndBuild
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-16 14:06:36 +02:00