gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
120,126 Commits 12 Branches 481 Tags 2.4 GiB
4ad6e2ea4e
Commit Graph

93 Commits

Author SHA1 Message Date
William Desportes
fb5d6159af
Fix Doctum reported phpdoc errors 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-12-18 22:01:51 +01:00
William Desportes
70320f256b
Fix a "PHP Fatal error: Uncaught TypeError: rawurlencode" using sakila database 
NOTICE: PHP message: PHP Fatal error:  Uncaught TypeError: rawurlencode(): Argument #1 ($string) must be of type string, int given in libraries/classes/Database/Designer/Common.php:141
Stack trace:
#0 libraries/classes/Database/Designer/Common.php(141): rawurlencode(1)
#1 libraries/classes/Controllers/Database/DesignerController.php(203): PhpMyAdmin\Database\Designer\Common->getScriptContr(Array)
#2 libraries/classes/Routing.php(92): PhpMyAdmin\Controllers\Database\DesignerController->index(Array)
#3 index.php(18): PhpMyAdmin\Routing::callControllerForRoute('/database/desig...', Object(FastRoute\Dispatcher\GroupCountBased), Object(Symfony\Component\DependencyInjection\ContainerBuilder))
#4 {main}
  thrown in libraries/classes/Database/Designer/Common.p...

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-12-07 01:20:53 +01:00
Maurício Meneghini Fauth
db3da81056 Remove some useless comments 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-13 19:56:56 -03:00
Maurício Meneghini Fauth
2358b9c4f9 Fix missing property type hints 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-22 21:42:22 -03:00
Maurício Meneghini Fauth
3b285ff17e Use identical operator for non-empty strings 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
05c62ad1a8 Fix some PHPStan errors 
Fixes "Cannot access offset on array" errors.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-02 16:12:07 -03:00
William Desportes
5d933e03b9
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-06-07 23:40:25 +02:00
William Desportes
1eb7c00c1c
Fix #16157 - relations of tables having spaces or special chars where not showing in the Designer 
We where comparing encoded strings with non encoded ones, that could not work.

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-06-07 23:29:37 +02:00
William Desportes
4820175b8a
Fix php error when browsing the designer 
The condition was not right, shorten to check only table

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-06-03 16:03:04 +02:00
William Desportes
7e9d2ae4f9
Move more SQL queries into Query\Generator 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-31 02:16:02 +02:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
3ae05c785d Use short list syntax and single line arrays 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-26 03:32:59 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
80a45fa0ae Break too long lines 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-16 18:08:20 -03:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-13 00:23:28 -03:00
William Desportes
b7af1364c6
Psalm auto fixes manualy reviewed and edited 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-04-28 23:18:59 +02:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824 Use short versions of scalar types in PHP docs 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
42166cac37 Remove use statements within the same namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-21 19:47:56 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations 
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
8ec4209002 Fix some coding standard issues 
- Inverts yoda comparisons
- Removes parentheses from return
- Removes useless ternary operators
- Adds paretheses to new instances
- Adds trailing array comma

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 00:38:34 -03:00
Maurício Meneghini Fauth
c5481acebf Merge branch 'QA_5_0' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-14 18:54:02 -03:00
Tabraiz
c6206a301d
Fix for page name already existing in designer page names 
Signed-off-by: Tabraiz Malik <tabraizmalik96@gmail.com>
 2020-01-12 21:35:05 +01:00
William Desportes
4512ada9eb
Fix php error when creating a relation between a table and a view in Designer 
Yes, that does not make sense but it should not throw and error
"Uncaught TypeError: mb_strtoupper() expects parameter 1 to be string"

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-01-12 18:29:34 +01:00
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments 
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
dd2b05330a Remove useless parentheses 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-12 00:18:01 -03:00
Maurício Meneghini Fauth
77518d341e Remove unused use statements 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-11 21:20:58 -03:00
Maurício Meneghini Fauth
f6a17433a2 Use null coalesce operator when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-11 20:16:58 -03:00
William Desportes
5f13152857
Fix some PHPStan level 3 errors 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-12-06 09:02:41 +01:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage 
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-01 14:10:07 -03:00
William Desportes
4e4670e9c2
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-23 00:08:27 +01:00
William Desportes
293d273632
Merge branch 'QA_4_9' into QA_5_0 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-23 00:06:39 +01:00
William Desportes
3f9ac1dc98
Fix engine can be null 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-23 00:05:55 +01:00
William Desportes
9965009cce
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-20 12:52:11 +01:00
William Desportes
68cfb777a5
Merge branch 'QA_4_9' into QA_5_0 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-20 12:37:58 +01:00
William Desportes
97ccafa06a
Add a message for misconfigured designer (displaywork) 
- When adding a column as display column in designer

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-20 12:30:14 +01:00
William Desportes
770f30aa86
Fix display field in Designer 
Introduced by: a23f2ba51a

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-20 12:29:07 +01:00
William Desportes
eda044cbac
Improve code after Scrutinizer report 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-11 21:33:25 +01:00
William Desportes
7f0949ad00
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-11 20:54:26 +01:00
William Desportes
5a83a289d8
Merge branch 'QA_4_9' into QA_5_0 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-11 20:31:34 +01:00
William Desportes
e070256fe4
Fix #13912 and #15123 - Tables of phpMyAdmin storage are not accessible 
Fixes: #13912
Fixes: #15123

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-11 12:02:54 +01:00
William Desportes
f52f3afff3
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-09 15:48:34 +01:00
William Desportes
c16891cb40
Merge branch 'QA_4_9' into QA_5_0 2019-11-09 15:41:21 +01:00
William Desportes
4ae14a3da9
Improve l10n context for translators and fix a typo 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-11-09 15:35:59 +01:00
Maurício Meneghini Fauth
fae64caf60 Merge branch 'QA_5_0' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-10-21 10:26:31 -03:00
Maurício Meneghini Fauth
dca01a5f77 Merge branch 'QA_4_9' into QA_5_0 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-10-21 10:11:34 -03:00
Maurício Meneghini Fauth
1a2cef1ae1 Fix some coding standard issues detected by PHPCS 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-10-21 09:57:06 -03:00
Maurício Meneghini Fauth
441f8daa1a Use gender-neutral pronouns 
Replaces gender-specific pronouns with gender-neutral pronouns.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-10-18 09:13:08 -03:00