William Desportes
b4f1e14e80
fix or ignore phpstan 0.12.63 errors
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-12-18 22:17:18 +01:00
Maurício Meneghini Fauth
bb32ba6d9c
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-04 12:31:43 -03:00
William Desportes
d077836a50
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-09-07 14:08:41 +02:00
William Desportes
330747998d
Fix #15634 - Only use session_set_cookie_params once on PHP >= 7.3.0 versions
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-09-07 14:02:24 +02:00
William Desportes
4f42cc8695
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-29 12:03:32 +02:00
William Desportes
96797ab79b
Fix #16058 - Clicking on table header don't sort by fieldname when using SignON Auth
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-29 00:44:04 +02:00
Maurício Meneghini Fauth
f4582e083e
Use early exit when possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
82c2964bb8
Remove useless elses
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 22:27:45 -03:00
Maurício Meneghini Fauth
2d02a15de3
Add static to closures that don't use $this
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 18:30:57 -03:00
Maurício Meneghini Fauth
3ae05c785d
Use short list syntax and single line arrays
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 03:32:59 -03:00
Maurício Meneghini Fauth
3baad2eb1c
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
a64393e7f5
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
William Desportes
cc82f092ce
Fix MissingClosureParamType errors
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-29 01:08:40 +02:00
Maurício Meneghini Fauth
206199105e
Remove useless return type annotations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824
Use short versions of scalar types in PHP docs
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
676f48349a
Reference global funcs and consts via use statement
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
585fdaea5a
Fix PHP doc spacing and order
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 18:07:37 -03:00
Maurício Meneghini Fauth
f80d3e3bd4
Remove unnecessary annotations
...
@package, @subpackage and others.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
39f42f848b
Remove some useless docblock comments
...
Fixes docblock spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
1a14b3e4d3
Remove vim modelines
...
These settings are no longer required as they are guaranteed through
other coding standard tools.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
Hugues Peccatte
ae77d630b1
Use constants when possible
...
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-07-16 23:21:25 -03:00
William Desportes
010df8e4ec
Merge branch 'QA_4_9'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 12:16:36 +02:00
William Desportes
80a7f0a75c
Make the hmac secret a secret for the user
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-13 19:05:04 +02:00
William Desportes
42d36a75f2
Use exit; instead of exit(); because exit; is most common in codebase
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-11 00:53:57 +02:00
Maurício Meneghini Fauth
45dc342666
Fix coding standard errors
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-10 19:07:02 -03:00
William Desportes
31ab2cb4e8
Merge branch 'QA_4_8'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-11 00:03:16 +02:00
William Desportes
47c3f131b4
Fix #14412 - AuthenticationSignon.php's showFailure function does not consider SignonCookieParams
...
Fixes : #14412
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-05 13:48:29 +02:00
Hugues Peccatte
7f304c1154
Remove useless proxies
...
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 23:39:19 +01:00
Maurício Meneghini Fauth
4cee0cbc12
Adds space after not (!) and type cast
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:56:34 -02:00
Maurício Meneghini Fauth
285e38e931
Fix some PSR-2 coding standard errors
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96
Use short array syntax instead of long array syntax
...
Replaces array() with [].
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
0998a50e9e
Enable strict mode in Plugins classes
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-16 01:09:16 -03:00
Maurício Meneghini Fauth
d23ed47666
Refactor PhpMyAdmin\IpAllowDeny static methods
...
Replaces static methods with instance methods.
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-03 14:06:13 -03:00
Gabriel Caruso
a8bd364e02
Clean elses
...
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
2017-12-14 22:02:17 -02:00
Michal Čihař
8e8f4bd3bb
Avoid using PHP_AUTH_USER and PHP_AUTH_PW globals for auth
...
Use object attributes to store the actual credentials and avoid
messing up with global variables.
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-20 19:44:28 +02:00
Michal Čihař
62535ea5b9
Pass failure reason to showFailure
...
This way we can avoid relying on global variables to check it.
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-20 19:44:28 +02:00
Michal Čihař
026d722178
Rationalize AuthenticationPlugin API
...
Make the API more consistent, remove not needed auth prefix and stop
talking about advanced authentication which has been there about 10
years ago.
API changed:
- authCheck is now readCredentials
- authSetUser is now storeCredentials
- auth is now showLoginForm
- authFails is now showFailure
- storeUserCredentials is now rememberCredentials
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-20 18:14:56 +02:00
Michal Čihař
56c1c9fc5c
Share base code for AuthenticationPlugin::authSetUser
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-20 18:14:56 +02:00
Michal Čihař
4a83171c30
Merge branch 'QA_4_7'
2017-08-01 09:09:19 +02:00
Maurício Meneghini Fauth
2631bcedba
Move plugins classes to PhpMyAdmin namespace
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-07-20 11:50:12 -03:00