Commit Graph

153 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
cb842fd079
Fix some errors found by PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-14 14:44:05 -03:00
Saksham Gupta
6cdb3779d2
Fix #15652 - Remove deprecated FOUND_ROWS()
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2020-11-12 12:49:46 +01:00
Maurício Meneghini Fauth
bb32ba6d9c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-04 12:31:43 -03:00
William Desportes
aecdfc80cb
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-10-04 00:29:04 +02:00
Petr Duda
661af18061 Fix #16377 Uncaught ReferenceError: Stickyfill is not defined
Signed-off-by: Petr Duda <petrduda@seznam.cz>
2020-10-01 21:39:49 +02:00
Maurício Meneghini Fauth
3c21cf1853 Remove url_query PHP global
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-08 13:32:25 -03:00
Maurício Meneghini Fauth
c57dda7315 Use DI for Sql class constructor
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-05 15:31:39 -03:00
Maurício Meneghini Fauth
992af332a0 Extract Sql::parseAndAnalyze method to SqlTest class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-05 13:58:51 -03:00
Maurício Meneghini Fauth
ceac762e09 Remove pmaThemePath and pmaThemeImage PHP globals
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-02 10:57:57 -03:00
Maurício Meneghini Fauth
7936909dbd Move Operations::getMaintenanceActions to the view
Uses Table\MaintenanceController to handle the maintenance actions in
the table operations page.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-28 15:25:14 -03:00
Maurício Meneghini Fauth
c112bfd6d6 Create a new page for Check Table
Instead of only showing the query results.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-27 14:22:22 -03:00
Maurício Meneghini Fauth
03d8314bba Create the PhpMyAdmin\Profiling class
Extracts Profiling related methods to the Profiling class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-26 16:02:30 -03:00
Maurício Meneghini Fauth
3e71690a0b Extract profiling methods from Sql::executeTheQuery
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-25 22:00:55 -03:00
Maurício Meneghini Fauth
622241c15f Fix profiling table not incrementing calls
Fixes #16318

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-25 20:54:45 -03:00
Maurício Meneghini Fauth
e7e9bd770f Remove the Sql::getHtmlForProfilingChart method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-25 20:31:15 -03:00
Maurício Meneghini Fauth
99abf3ab3c Remove the Sql::getHtmlForSetColumn method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-24 22:59:17 -03:00
Maurício Meneghini Fauth
dd8eb261f8 Remove the Sql::getHtmlForBookmark method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-24 20:47:33 -03:00
Maurício Meneghini Fauth
3a5ad0a011 Extract HTML from query results operations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-21 20:53:09 -03:00
Maurício Meneghini Fauth
f6215b6f7a Extract HTML from Sql::getQueryResponseForNoResultsReturned
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-20 17:27:09 -03:00
William Desportes
e97d82061d
Coding standard fixes after #14340
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-22 17:52:51 +02:00
William Desportes
d75b83d452
Fix #15247 - Move and rename the exit for sendResponseForGridEdit to getResponseForGridEdit
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-21 23:42:39 +02:00
Maurício Meneghini Fauth
b9165e6c30 Extract Sql::addBookmark to controller
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-14 21:23:42 -03:00
Maurício Meneghini Fauth
918b1f38c6 Change return type of Sql::executeQueryAndSendQueryResponse
Remove Response::addHTML call.

Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-12 15:22:57 -03:00
Maurício Meneghini Fauth
971a773cc7 Make Sql::isJustBrowsing method static
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-10 23:25:34 -03:00
Maurício Meneghini Fauth
3b285ff17e Use identical operator for non-empty strings
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
05c62ad1a8 Fix some PHPStan errors
Fixes "Cannot access offset on array" errors.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-02 16:12:07 -03:00
William Desportes
7e9d2ae4f9
Move more SQL queries into Query\Generator
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 02:16:02 +02:00
William Desportes
761045bcc9
Move getSystemSchemas and isSystemSchema to Query\Utilities
If you think the class name could be better, feel free to improve it.
Everybody know naming classes is difficult ^^
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 01:42:53 +02:00
Maurício Meneghini Fauth
58eee2e371 Use early exit when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 21:46:12 -03:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
William Desportes
6d123fe452
Some minor codebase fixes and improvements
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-24 15:25:56 +02:00
Maurício Meneghini Fauth
e050f0096c Merge branch 'QA_5_0'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-16 01:54:05 -03:00
Maurício Meneghini Fauth
ad1ff14cc6 Fix typo in a condition in the Sql class
Related to 503df0a6a7

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-16 01:50:42 -03:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
William Desportes
fd61e03ea6
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-03 00:18:14 +02:00
William Desportes
a06c62ef04
Fix #16104 - Overwriting bookmarked query causes PHP Fatal error
Introduced-by: 3dce65d913
Fixes: #16104
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-03 00:10:32 +02:00
Maurício Meneghini Fauth
db642ab19e Extract HTML from Index:getHtmlFromIndexes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-29 23:43:18 -03:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824 Use short versions of scalar types in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
6b7af13f8f Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 00:33:24 -03:00
William Desportes
8040e0367e
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-22 22:52:03 +01:00
William Desportes
3116e91498
Fix #15833 - TypeError when submitting unchanged data
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-22 22:50:02 +01:00
Maurício Meneghini Fauth
42166cac37 Remove use statements within the same namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 19:47:56 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
c231652c67 Remove useless comments in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 14:38:49 -03:00
Maurício Meneghini Fauth
8ec4209002 Fix some coding standard issues
- Inverts yoda comparisons
- Removes parentheses from return
- Removes useless ternary operators
- Adds paretheses to new instances
- Adds trailing array comma

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 00:38:34 -03:00
Maurício Meneghini Fauth
285907991e Add coding standard rules for whitespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 22:29:54 -03:00
Maurício Meneghini Fauth
0b7a83dd2b Extract action from SqlController::index
Extracts the set-column-preferences action from the SqlController index
method to a new route.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-18 17:59:55 -03:00