Fixes: #15225 - Using Command+Click to open in new tab does not work (Firefox/Safari)
Fixes: #14270 - Middle-click on foreign key link broken
Fixes: #14363 - Broken relational links in tables
Signed-off-by: William Desportes <williamdes@wdes.fr>
Fixes#14514Fixes#14515
Possible fix for #14516#14514 Tables which enable the new MariaDB 10.3 versioning show up as "SYSTEM VERSIONED" instead of "BASE TABLE" inside of information schema. This patch now checks for both, so these new table types don't incorrectly display as views.
#14515 MariaDB 10.3 also supports INVISIBLE columns, which is optionally paired with SYSTEM VERSIONED tabled (or implemented separately). This patch helps handle this new column attribute.
#14516 This patch cannot be fully tested and verified with current MariaDB builds. Version 10.3.9 (currently unreleased) corrects an issue with column information for SYSTEM VERSIONED columns that this patch relies on. https://jira.mariadb.org/browse/MDEV-16804 - the reason for checking with preg_match instead of adding to the list is because there are now combined "extra" information for columns, such as INVISIBLE columns. Just matching entire strings also has a bug with these other "extra" parameters.
Signed-off-by: Vincent Milum Jr <git@darkain.com>
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
(cherry picked from commit 3f6e360a4e)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
* Fix for issues with spatial fields
Fixes the following issues:
1. #14068 SPATIAL fields with no unique index/autoincrement error when clicking
This error occurs when there is no unique column to uniquely identify a tuple. I've disabled the geomtery view and made view as wkt the default view in such cases.
2. #14121 View spatial fields as WKT doesn't work
1. #14067 IS NULL search operator produces no WHERE SQL with spatial fields
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
* Fix for issues with spatial fields
This commit fixes view as BINARY not working in the previous commit.
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
* Fix for issues with spatial fields
Fixes typo in previous commits.
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
(cherry picked from commit 9231620c2d)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Move HTTP requests related methods from Util class to
PhpMyAdmin\Utils\HttpRequest class.
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
- themes can easier customize their look
- this better deals with previous JS code who relied on sprites (fixes#13815)
Signed-off-by: Michal Čihař <michal@cihar.com>
It did not behave as documented for ages, it only influenced
whether additional text was added to the link.
Callers should use parameters to Util::getIcon to achieve this
(if it is actually needed somewhere)
Signed-off-by: Michal Čihař <michal@cihar.com>
The passed parameter should be already valid, we should avoid expensive
processing of the data such as calling strip_tags on every text
containing <img.
Signed-off-by: Michal Čihař <michal@cihar.com>
We no longer create form, but rather rather tag the link to be handled
as POST on the client side.
This way the code is way simpler without need on any special case
handling on server side.
Fixes#13649
Signed-off-by: Michal Čihař <michal@cihar.com>
The data is constant for theme, so we don't have to deal with cache
invalidation in testsuite and in corner cases.
Signed-off-by: Michal Čihař <michal@cihar.com>
