gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
118,861 Commits 12 Branches 481 Tags 2.4 GiB
4e8484229a
Commit Graph

79 Commits

Author SHA1 Message Date
William Desportes
3f0b7390e2
Fix documentation after removing _ from private methods 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-06-02 23:56:48 +02:00
charliewindred
7d792e88f6
Removed underscores from unit test methods 
Removed underscore prefixes from unit test method calls.

Signed-off-by: charliewindred <charliewindred@gmail.com>
 2020-06-02 23:52:32 +02:00
Maurício Meneghini Fauth
e2eac49ad2 Use closures to call private methods as callback 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-30 13:14:06 -03:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
3ae05c785d Use short list syntax and single line arrays 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-26 03:32:59 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
9269d75fb4 Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 20:22:18 -03:00
William Desportes
4134f34b54
Fix tests for seed 590128958 
Seed: 590128958

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-22 09:50:27 +02:00
William Desportes
49a6d6e8d0
Use AbstractTestCase instead of PmaTestCase for all tests not needing mockResponse 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-22 01:45:50 +02:00
William Desportes
ae575ffb14
Fix running tests in --process-isolation 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-21 16:21:20 +02:00
William Desportes
fe32a359dc
Move PMA_VERSION calls into defineVersionConstants() for tests 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-21 13:26:48 +02:00
William Desportes
0964470643
Use parent::setGlobalConfig(); 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-21 13:19:23 +02:00
William Desportes
8f7d3d1fa7
Fix test cases after backupGlobals = false 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-21 02:07:45 +02:00
William Desportes
6eaa55e805
Call parent's setUp and tearDown 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-20 21:31:13 +02:00
William Desportes
8ef5143901
Use AbstractTestCase on all unit tests 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-20 21:15:06 +02:00
William Desportes
f063c553f2
Fix some tests executed in random order 
Using: ./vendor/bin/phpunit --order-by=random --random-order-seed=1589977275 --exclude=selenium --no-coverage --filter=FormDisplayTest

Seeds: 1590000479, 1589977275, 1589998302, x1590001040, x1590001183

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-20 21:10:32 +02:00
William Desportes
0b2c24ee26
Use ::class in tests 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-20 12:15:40 +02:00
William Desportes
947f9ad04f
Remove some unused code detected by codacy 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-15 23:57:22 +02:00
William Desportes
43aecb2f3b
Fix failing FormDisplayTemplateTest::testDisplayTabsTop after merge of #15915 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-04-12 02:59:49 +02:00
William Desportes
8a829f0554
Add some comments for a deprecation in phpunit 10 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-04-05 16:05:33 +02:00
William Desportes
7f90a6172a
Fix some broken tests on Windows CI because of line endings 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-02-22 17:52:00 +01:00
William Desportes
3059c99bda
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-01-28 19:47:20 +01:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 13:03:29 -03:00
William Desportes
6dfa603f0c
Add test for Form::cleanGroupPaths 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-01-22 23:07:40 +01:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations 
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
50bc4ab37f Remove useless PHP docs for functions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 13:20:01 -03:00
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments 
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
77518d341e Remove unused use statements 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-11 21:20:58 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage 
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-01 14:10:07 -03:00
Maurício Meneghini Fauth
8a0aa251fe Replace some custom CSS utilities with Bootstrap equivalents 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-11-12 19:35:37 -03:00
Oleg Abrazhaev
c0a93fadf7 fix test 
Signed-off-by: Oleg Abrazhaev <seyferseed@gmail.com>
 2019-10-27 15:05:34 +01:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines 
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
333b68eb45 Fix PageSettingsTest failing test 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-08-23 14:50:56 -03:00
Maurício Meneghini Fauth
8ab7e28a98 Fix selfurl not containing the route parameter 
Adds route parameter and removes empty parameters from selfurl.

Fixes #15418

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-08-08 01:59:48 -03:00
Maurício Meneghini Fauth
4537dcc774 Fix failing tests 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-07-20 18:16:08 -03:00
William Desportes
996975262f
Improve ConfigFileTest::tearDown 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-06-22 17:41:54 +02:00
William Desportes
6cc352ac12
phpstan level 3 fixes 
21 errors left

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-06-22 14:37:38 +02:00
Maurício Meneghini Fauth
e1f9ae00cd Add a trailing comma in multi-line arrays 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-14 14:09:26 -03:00
Maurício Meneghini Fauth
7be0f6bfae Reference class names in use statements 
Sort use statements

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-12 00:14:26 -03:00
Maurício Meneghini Fauth
6f8e53cf5c Rename js/config.js variables to use camel case 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-05-30 00:42:22 -03:00
Maurício Meneghini Fauth
26a6a8dd4c Merge branch 'QA_4_8' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-05-01 01:56:27 -03:00
Maurício Meneghini Fauth
6b443266c7 Fix failing test of Config\FormDisplayTemplateTest 
Related to 2a4729c18e

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-05-01 01:46:51 -03:00
Maurício Meneghini Fauth
5254ec1b65 Refactor Navigation\NavigationTree 
- Extract HTML from renderState() and renderDbSelect()
- Use DI for $dbi instead of global
- Fix tests

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-04-24 02:25:48 -03:00
Nupur Agrawal
b09d9565df Deleted redundant help/tool tip on page settings (#15061) 
Removed redundant help/tool tip in page settings "Query history length" area.

Fixes issue #15029

Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
 2019-03-24 19:31:58 -04:00
Maurício Meneghini Fauth
74105ab85c Replace readAttribute() and assertAttributeEquals() 
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-24 16:32:28 -03:00
Maurício Meneghini Fauth
92cc67fbf7 Replace assertContains() with assertStringContainsString() 
Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.
Using assertNotContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringNotContainsString() or assertStringNotContainsStringIgnoringCase() instead.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-24 16:32:28 -03:00
Maurício Meneghini Fauth
182491a73f Add void return type declaration for tests 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-22 21:33:55 -03:00
Maurício Meneghini Fauth
23c3579804 Format array declarations 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-07 14:31:39 -02:00